Author Topic: Old OXCE+ discussion thread  (Read 264055 times)

Offline Player701

  • Sergeant
  • **
  • Posts: 27
    • View Profile
Re: [OXCE+] Original discussion thread
« Reply #1590 on: July 24, 2018, 08:09:56 pm »
In OXCE+ the aliens can be transferred to other bases instead of dying.
If you turn on the "Enforce storage limits" option, you will get the message about not sufficient alien containment.

Without the option turned on, it just goes into minus (and you are not forced to remove or transfer the alien).

But I guess there is still a logical error there... you should be able to go into minus let's say from 10 to -7, but not from 0 to -7 (i.e. when you don't have any alien containment).
I'll fix it accordingly.

PS: as for "<=" vs "<".... "<" is correct

I thought storage limits only affected items, not captive aliens. I am aware you can exceed your general stores capacity after recovering items from a successful mission (vanilla behavior), but there has always been a requirement to have an alien containment at your base to store live aliens. At least it is like this in plain OpenXcom (and AFAIK in vanilla as well).

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 5715
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: [OXCE+] Original discussion thread
« Reply #1591 on: July 24, 2018, 08:15:01 pm »
I thought storage limits only affected items, not captive aliens. I am aware you can exceed your general stores capacity after recovering items from a successful mission (vanilla behavior), but there has always been a requirement to have an alien containment at your base to store live aliens. At least it is like this in plain OpenXcom (and AFAIK in vanilla as well).

Storage limits affect alien containment in Openxcom too.

And the requirement to have alien containment in the base (or transfer to another base that has it) will be fixed.

Offline Player701

  • Sergeant
  • **
  • Posts: 27
    • View Profile
Re: [OXCE+] Original discussion thread
« Reply #1592 on: July 24, 2018, 09:25:20 pm »
Storage limits affect alien containment in Openxcom too.

And the requirement to have alien containment in the base (or transfer to another base that has it) will be fixed.

I see.

Also, regarding
PS: as for "<=" vs "<".... "<" is correct

Sorry, then. Too much advanced logic seems to have been introduced here so I guess I don't understand it all. Just thought I'd better ask about it...


Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 5715
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: [OXCE+] Original discussion thread
« Reply #1593 on: July 26, 2018, 05:52:15 pm »
Finally fixed, took a lot longer than I thought... corner cases of corner cases of corner cases, sigh.

Here's the fix: https://github.com/MeridianOXC/OpenXcom/commit/c867b6bf53ae72907a6a70b3747153b458b9aa11

Here's a new build: https://lxnt.wtf/oxem/builds//ExtendedPlus/Extended+-3.10b-88ae4fdc2-2018-07-26-win32.7z

I would appreciate if someone could test all the combinations of:
 - storage limits option turned on/off
 - having alien containment in the base or not
 - having alien containment in any other base or not

Offline Player701

  • Sergeant
  • **
  • Posts: 27
    • View Profile
Re: [OXCE+] Original discussion thread
« Reply #1594 on: July 26, 2018, 06:36:04 pm »
Finally fixed, took a lot longer than I thought... corner cases of corner cases of corner cases, sigh.

Here's the fix: https://github.com/MeridianOXC/OpenXcom/commit/c867b6bf53ae72907a6a70b3747153b458b9aa11

Here's a new build: https://lxnt.wtf/oxem/builds//ExtendedPlus/Extended+-3.10b-88ae4fdc2-2018-07-26-win32.7z

I would appreciate if someone could test all the combinations of:
 - storage limits option turned on/off
 - having alien containment in the base or not
 - having alien containment in any other base or not

Using the save file I attached earlier, I am now presented with an alien containment management screen at the end of the mission. I guess this is intended behavior. Perhaps the message could be changed, though (it says I must remove excess aliens from containment even though I don't have one). Wish it were possible to turn off the ability to transfer the aliens, but then I might as well just not use it.
 
The only thing which looks weird to me is that the "Alien containment limits exceeded" popup window seems to appear before its animation starts playing (i.e. first I see the message, and then the "window frame" animation and sound play). I think I saw this effect one or two times back when I didn't have any alien containment in any of my bases, but then I thought it was just a fluke (perhaps I pressed a button too fast or something); however, this time it can be reproduced reliably.

I wish I could test more, but unfortunately I don't have much time in the following two days. Thank you anyway, though. (guess OpenXcom could probably benefit from some kind of unit testing framework...)

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 5715
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: [OXCE+] Original discussion thread
« Reply #1595 on: July 26, 2018, 07:04:29 pm »
Using the save file I attached earlier, I am now presented with an alien containment management screen at the end of the mission. I guess this is intended behavior.

Yes.

Perhaps the message could be changed, though (it says I must remove excess aliens from containment even though I don't have one).

This could be easily rephrased, if it's bothering you.
I left it as in original, because it's not bothering me :)

Wish it were possible to turn off the ability to transfer the aliens, but then I might as well just not use it.

It would be one more dimension to an already overcomplicated situation (and I didn't even tell you there is an unlimited number of alien containment types for various groups of creatures... by far my least favourite oxce+ feature).
I only hope that benefits from having after-mission-transfers (for other players) outweigh your non-vanilla frustration.

Offline Player701

  • Sergeant
  • **
  • Posts: 27
    • View Profile
Re: [OXCE+] Original discussion thread
« Reply #1596 on: July 26, 2018, 07:48:38 pm »
Yes.

This could be easily rephrased, if it's bothering you.
I left it as in original, because it's not bothering me :)

It would be one more dimension to an already overcomplicated situation (and I didn't even tell you there is an unlimited number of alien containment types for various groups of creatures... by far my least favourite oxce+ feature).
I only hope that benefits from having after-mission-transfers (for other players) outweigh your non-vanilla frustration.

There is no frustration, just expressing my thoughts. Like I said, it might be easier to simply not use this feature instead. Especially since you say the situation is overcomplicated (well, I think I already got that when looking at the code and comparing it to plain OpenXcom). Maybe I will even try out one of those mods someday which make use of different alien containment types :)

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 5715
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: [OXCE+] Original discussion thread
« Reply #1597 on: July 29, 2018, 08:13:28 pm »
New OXCE+ version is up.

2018-07-29
 - Option to get a country back after they signed a pact with aliens: https://openxcom.org/forum/index.php/topic,5932.msg100448.html#msg100448
 - Added support for alien mission interruption: https://openxcom.org/forum/index.php/topic,6456.msg100411.html#msg100411
 - Fixed mission wave/objective mismatch: https://openxcom.org/forum/index.php/topic,5717.msg100406.html#msg100406
 - Added a 50-200% damage calculation type: https://openxcom.org/forum/index.php/topic,6455.msg100319.html#msg100319
 - Night vision can always be enabled
 - Grenade indicator in hand UI is now animated (same as in the Inventory)
 - Refactored hand UI drawing (now supports OXCE animation)
 - Fixed alien containment handling when limits are not enforced
 - Fixed crash when not all soldiers could be deployed and craft was lost
 - "New Battle" mode now has 2 ammo of each type instead of 1 by default
 - Fixed damage bonus from "strengthApplied" not showing in stats for nerds

Download: https://lxnt.wtf/oxem/builds//ExtendedPlus/Extended+-3.10b-7e4188c64-2018-07-29-win32.7z
« Last Edit: August 26, 2018, 11:12:54 pm by Meridian »

Offline Player701

  • Sergeant
  • **
  • Posts: 27
    • View Profile
Re: [OXCE+] Original discussion thread
« Reply #1598 on: July 30, 2018, 06:55:17 pm »
There seems to be a minor regression issue between builds 2018-07-29 and 2018-07-26. The weapon sprite in the status panel seems to disappear randomly while firing. Note that it has always done that once after clicking on the target (just before firing), but in that case everything in the panel disappears also (soldier stats, name etc.). In 2018-07-29 it seems to disappear randomly during the firing sequence, leaving only the ammo counter visible. This is most noticeable with auto shots.

Offline LouisdeFuines

  • Commander
  • *****
  • Posts: 589
    • View Profile
Re: [OXCE+] Original discussion thread
« Reply #1599 on: July 30, 2018, 08:03:00 pm »
@Meridian:
How do I activate the base-retake option?

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 5715
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: [OXCE+] Original discussion thread
« Reply #1600 on: July 30, 2018, 11:11:20 pm »
@Meridian:
How do I activate the base-retake option?

You don't... let the modders do it.
It's not a user option, it's a modding parameter.

Offline new_civilian

  • Commander
  • *****
  • Posts: 749
    • View Profile
Re: [OXCE+] Original discussion thread
« Reply #1601 on: August 03, 2018, 12:33:34 pm »
And a good one, just recoverd Spain in my recent campaign!  :D
Thanks so much for all your work here, Meridian.

Offline Player701

  • Sergeant
  • **
  • Posts: 27
    • View Profile
Re: [OXCE+] Original discussion thread
« Reply #1602 on: August 03, 2018, 10:53:13 pm »
Hi again.

Found another bug in the latest build (2018-07-29).

Steps to reproduce:
  • Load save1.sav
  • Intercept the UFO with any craft (they are all armed), DO NOT SHOOT THE UFO DOWN, minimize the interception window instead
  • Load save2.sav
  • BOOM - segmentation fault

Unfortunately, these steps are not reliable (the crash doesn't always happen). But it appears the memory becomes corrupted after performing steps 1-3 and any further action taken may result in a crash or freeze. I had OXCE+ lock up completely when trying to load save2.sav again after it loaded normally for the first time. In another attempt to reproduce the bug, I had OXCE+ crash when exiting the game. I couldn't reproduce this in vanilla OpenXcom (though it might be subject to this bug as well, considering the apparent randomness in how it can manifest itself).

Tested on a clean installation - no mods used and no mods present. OS is Windows 10 x64, using build from the URL in the corresponding forum post (win32). BTW, the win64 build doesn't seem to work at all on my system (it just doesn't start, no error message or anything).

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 5715
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: [OXCE+] Original discussion thread
« Reply #1603 on: August 04, 2018, 03:41:06 pm »
Yeah, trying to access already deleted objects... also applies to vanilla.

Offline Player701

  • Sergeant
  • **
  • Posts: 27
    • View Profile
Re: [OXCE+] Original discussion thread
« Reply #1604 on: August 05, 2018, 12:46:48 pm »
Yeah, trying to access already deleted objects... also applies to vanilla.

I see. Hope it can be fixed in future vanilla and OXCE+ builds, then. Maybe file a report on the bug tracker for that one?

Here is another, this time OXCE+ exclusive issue (maybe I should create separate threads for them?): Chryssalid's "built-in" weapon has no sprite in the status panel (viewable when mind controlled), while in vanilla OXC it does have one. Not sure why, as the corresponding resource is present and rulesets appear to be identical. All other "built-in" weapons (Celatid, Silacoid, Reaper, Zombie) have their sprites correctly displayed. See the attached screenshot and save file.