Author Topic: OXCE (OpenXcom Extended) main thread  (Read 229755 times)

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 7362
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #885 on: September 29, 2021, 09:28:42 am »
Not sure if this is a bug but it didn't happen before.
When moving units or firing weapons, the bottom UI blanks out.
Using 7.1, Happens in both X-COM Files, and Vanilla game.

It happened before for firing weapons (e.g. during autoshots).
It didn't happen when moving units, that's a bug.
Fixed here: https://github.com/MeridianOXC/OpenXcom/commit/18a9c23b55310f8f6445954ef308ddffac12aa89

You can wait for next version or download a snapshot here: https://lxnt.wtf/oxem/builds//Extended/Extended-7.1.1-8be08dd42-2021-09-29-win64.7z

Offline Yankes

  • Moderator
  • Commander
  • ***
  • Posts: 2683
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #886 on: September 29, 2021, 11:05:25 am »
Another thing fixed in 7.1.1 is crash when unit with reaction 0 react to attack.
As consequence of this fix y-script hooks for reactions have new argument `reaction_count` where is stored sequence number of current reaction to same event.

Offline mercy

  • Colonel
  • ****
  • Posts: 337
    • View Profile
    • Email
Re: OXCE (OpenXcom Extended) main thread
« Reply #887 on: September 29, 2021, 06:48:22 pm »
TRANSFER screen shortcut request:

Right after finishing a mission I can ship the looted equipment to my research base. Can we please have a shortcut key "X" on that screen that transfers all equipment from the left side to the right side, so everything can be shipped to an other base (not where my ship is from) at a flip of a switch?
Thank You!
« Last Edit: September 29, 2021, 07:14:02 pm by mercy »

Offline Finnik

  • Colonel
  • ****
  • Posts: 383
  • Finnik#0257
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #888 on: September 29, 2021, 07:16:02 pm »
Another thing fixed in 7.1.1 is crash when unit with reaction 0 react to attack.
As consequence of this fix y-script hooks for reactions have new argument `reaction_count` where is stored sequence number of current reaction to same event.

How is it possible?

Offline Yankes

  • Moderator
  • Commander
  • ***
  • Posts: 2683
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #889 on: September 30, 2021, 01:10:34 pm »
when "action unit" have too zero reaction because of stats of depletion of TU

Offline Yankes

  • Moderator
  • Commander
  • ***
  • Posts: 2683
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #890 on: October 02, 2021, 03:51:47 pm »
In recent version of OXCE 7.1.2 changed logic that now unit can access psi, skill and special item buttons at once, previously only one buttons was visible.

Offline Ethereal

  • Commander
  • *****
  • Posts: 520
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #891 on: October 06, 2021, 04:27:33 am »
I'm sorry, but I'm staying on version 7.0. I'm tired of error messages that were not considered errors before. In addition, this update does not carry any useful functions for my modification. Bug fixes that I've never encountered are also of dubious utility.

I wish you a successful removal of restrictions in the future and not to ruin what works.

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 7362
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #892 on: October 06, 2021, 08:15:16 am »
I'm sorry, but I'm staying on version 7.0. I'm tired of error messages that were not considered errors before. In addition, this update does not carry any useful functions for my modification. Bug fixes that I've never encountered are also of dubious utility.

I wish you a successful removal of restrictions in the future and not to ruin what works.

Just for the record, all those things were considered errors before, and were causing issues and crashes.

We will definitely not remove any validations (unless proven we made a mistake somewhere -- we're only humans too); the number of validations will only grow and grow to ensure we provide the best quality possible.

Offline Nord

  • Commander
  • *****
  • Posts: 1409
  • The Gate is open.
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #893 on: October 09, 2021, 01:38:32 pm »
Encountered possible bug.
When attacking by psi-amp "use", script hook "damageUnit" must know damage type from psi-amp. But both "damaging_type" parameter and "RuleDamageType.getResistType" from "weapon_item" always returns 0.
Or is it work some other way?

Offline Yankes

  • Moderator
  • Commander
  • ***
  • Posts: 2683
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #894 on: October 09, 2021, 03:18:48 pm »
Do you correctly set it in psi-amp? Stats for nerd should show what damage type is set for this item.
Rest of code should handle damage types same as any other item in game.

Offline Nord

  • Commander
  • *****
  • Posts: 1409
  • The Gate is open.
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #895 on: October 09, 2021, 03:48:08 pm »
Spoiler:
Code: [Select]
  - type: STR_MENTAL_WEAPON_2 #Mentat master panic
    categories: [STR_SPELLS_WEAPONS, STR_PSI, STR_MENTAL_DAMAGE]
    maxRange: 25
    hitSound: 36
    psiAnimation: 40
    hitAnimation: 176
    battleType: 9
    LOSRequired: false
    power: 1
    manaRequired: true
    manaExperience: 150
    experienceTrainingMode: 26
    accuracyPanic: 30 #bonus equal to Vanilla x2
    accuracyUse: 20
    accuracyMultiplier:
      firing: 0.0
      psiSkill: 1.0   
    damagetype: 13
    damageBonus:
      psiStrength: 0.5
    damageAlter:
      RandomType: 3
      ArmorEffectiveness: 0
      ToWound: 0
      ToArmor: 0
    costUse:
      time: 0
      mana: 0
    tuPanic: 0
    tuMindControl: 0
    tuUse: 0
    flatRate: true
    clipSize: -1
    fixedWeapon: true
    specialUseEmptyHand: false
    recover: false
#    specialIconSprite: 6
    targetMatrix: 7
Maybe a thing is that attack can be done via skill?
Spoiler:
Code: [Select]
  - type: STR_MIND_BLAST_SKILL #mentat master, deal damage.
    tags:
      SKILL_ID: 12
    costUse:
      time: 25
      mana: 25
    flatUse:
      mana: true
    targetMode: 11
    compatibleWeapons: [STR_MENTAL_WEAPON_2]
    checkHandsOnly: false
It does nothing scripted though.

Offline Yankes

  • Moderator
  • Commander
  • ***
  • Posts: 2683
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #896 on: October 09, 2021, 04:05:43 pm »
Code: [Select]
damagetype: 13
this is incorrect, `T` should be upper case.

Offline Nord

  • Commander
  • *****
  • Posts: 1409
  • The Gate is open.
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #897 on: October 09, 2021, 04:06:11 pm »
Code: [Select]
damagetype: 13
this is incorrect, `T` should be upper case.
Oh. Shame on me.

Offline Yankes

  • Moderator
  • Commander
  • ***
  • Posts: 2683
    • View Profile
Re: OXCE (OpenXcom Extended) main thread
« Reply #898 on: October 09, 2021, 04:16:36 pm »
This is why I ask you to check SfN as it can detect errors like this

Offline mercy

  • Colonel
  • ****
  • Posts: 337
    • View Profile
    • Email
Re: OXCE (OpenXcom Extended) main thread
« Reply #899 on: October 09, 2021, 06:00:58 pm »
I would like to request a shortcut to transfer everything from the left to the right (at once on keypress "X") on the Transfer screen, please: