Bugs, crashes, typos & bad taste

[Stoddard]

@Solarius: it crashes "somewhere" in the lighting calculation... I can't even say where, because the stack trace looks like

Wanted to take a look out of curiosity and it doesn't crash for me on neither xenial64 or mingw, or mxe builds under wine.
Any specific steps to take?

It might be the compiler versions. My builds are all gcc 5.3+ :  5.4.0 (native, mxe 5.3.2 (mingw)  while yours is 4.9.4

[Meridian]

Hmm, looks like it doesn't always crash.

It crashed on me the first time I loaded it (right after clicking on Yes button in Confirm landing GUI, just before Briefing GUI).

I tried again now, first 2 attempts were without a crash, third attempt crashed again.

I have save scumming off, so I guess map issue is unlikely, I'd bet on a code issue.

It might be the compiler versions. My builds are all gcc 5.3+ :  5.4.0 (native, mxe 5.3.2 (mingw)  while yours is 4.9.4

I tested in visual studio 2017.

[Yankes]

This all depends on how data is layout in memory, if buged region is closed to end of allocated block it will crash otherwise will access some random unused memory.

[Stoddard]

Okay, valgrind to the rescue!

https://lxnt.wtf/oxem/builds//massif/xfiles-valgrind.txt

Take a look at the last two records. Those happen in the lighting code, and it seems that whatever is passed as lastPount to the "calculateBlock" lambda is out of bounds - that is, outside the map.

Which, depending on what the allocator does, may crash the party, work correctly, or mess up the lightning.

[Dreamsicle]

Noticed that the X Com Origins UFOPedia states that GiB was founded in 1997 even though the new date is December 1996.

[Solarius Scorch]

Good luck with the bug hunt, guys!

Noticed that the X Com Origins UFOPedia states that GiB was founded in 1997 even though the new date is December 1996.

Yeah, I have moved the date back and forth a lot. Thanks

[LuigiWhatif]

I encountered a visual bug during the M.A.G.M.A robotics mission.  The marker for allied tanks on the mini-map was messed up and kept rotating between various glitched forms.  I have no idea how to make a gif, but here are two images as an example.  Also, after the mission I captured the one tank I stunned but I can't research it and it has no sell price.  I did not recover the wrecks of the ones I killed.

[Solarius Scorch]

Hmmm, it shouldn't be recoverable, but fix that.

As for the glitch... No idea what happened (nothing in my mod I think), but I'd like to know how to do that.

[LuigiWhatif]

I also get the glitch when I used the battle creator, if you want to look for yourself.  Is it because it is a 4-space ally unit?  I think that this is the first time I've seen one.

Also, I just got an EXALT mission at the start of February, despite researching their termination at the end of December.  I'm pretty sure they should have left the spawn pool by now, so is this a bug?  I remember someone else mentioning something similar.  I'll post again if it shows up again next month.

[Solarius Scorch]

Oh shit... You're right. Sorry, try this hotfix.

[LuigiWhatif]

I downloaded the hotfix but now its causing a new problem.  This message pops up and the game closes.  When I restart XCOMFiles is disabled and trying to turn it on just causes the message again.

[Meridian]

I encountered a visual bug during the M.A.G.M.A robotics mission.  The marker for allied tanks on the mini-map was messed up and kept rotating between various glitched forms.  I have no idea how to make a gif, but here are two images as an example. 

https://www.ufopaedia.org/index.php/SCANG.DAT

Code: [Select]

//minimap sprite index:
// * 0-2   : Xcom soldier
// * 3-5   : Alien
// * 6-8   : Civilian
// * 9-11  : Item
// * 12-23 : Xcom HWP
// * 24-35 : Alien big terror unit(cyberdisk, ...)

Civilian big units don't exist (there are no corresponding red minimap images in the spriteset)... so game just takes index 6-15... which are the funky effects you see.

EDIT: I could maybe change it to just display 4 blinking red dots, see attached

[Solarius Scorch]

I downloaded the hotfix but now its causing a new problem.  This message pops up and the game closes.  When I restart XCOMFiles is disabled and trying to turn it on just causes the message again.

Arrrgh! I had no idea it would prevent the mod from launching! Why do these safety measures only work when they aren't supposed to?!

Just find and remove this part from the missionScripts_Xcomfiles.rul:

Code: [Select]

  - type: VampireCastle
    firstMonth: 0
    executionOdds: 15
    missionWeights:
      0:
        STR_VAMPIRE_CASTLE: 100
    regionWeights:
      0:
        REGION_VAMPIRE_CASTLE: 100
    researchTriggers:
      STR_FOLLOW_THE_ZOMBIES: true
    useTable: false
    startDelay: 20
    randomDelay: 43500



EDIT: I could maybe change it to just display 4 blinking red dots, see attached

Sure, thanks.

[LuigiWhatif]

That got it working again.  Thanks.

[HT]

Hello, I'm not sure if it counts as a bug, but the FAMAS rifle has a bit of an odd behavior regarding the Ufopaedia: I've been able to "research" it and acquire it for my soldiers, but it doesn't show its relevant article anywhere. Sometimes it does show up after getting Promotion 2 and "researching" similar weapons.

Another one which I believe it has been commented is that I'm given the option to investigate a "Zrbite tank"... Without having found said alien material ingame yet.