OXCE (OpenXcom Extended) main thread

[Meridian]

Big request to return the option - difficultyBasedRetaliationDelay. Or tell me a way to completely avoid the Retaliation missions in the first month.

ok

[Ethereal]

What is "ambienceRandom" attached to? Why is he inherited by the next mission in two-tier missions? If this is intended, then it is very bad. Maybe it should be hard-tie to "terrains.rul", and not to the mission?
There is a bug in version 6.9.6. In version 6.9.1 - no.

[Meridian]

What is "ambienceRandom" attached to?

It's attached to terrain.

There is a bug in version 6.9.6. In version 6.9.1 - no.

I cannot see any difference between 6.9.1 and 6.9.6.

[Ethereal]

And yet in 6.9.6. "ambienceRandom" and "ambience" are carried over from the first mission to the second, which is not in 6.9.1 version. Moreover, if the second has its own "ambience" - then both work. I just put it before the fact.

И тем не менее в 6.9.6. "ambienceRandom" и "ambience" переносятся из первой миссии во вторую, чего в 6.9.1 версии нет. Причём, если во второй есть свой "ambience" - то работают оба. Просто ставлю перед фактом.

[Meridian]

And yet in 6.9.6. "ambienceRandom" and "ambience" are carried over from the first mission to the second, which is not in 6.9.1 version. Moreover, if the second has its own "ambience" - then both work. I just put it before the fact.

И тем не менее в 6.9.6. "ambienceRandom" и "ambience" переносятся из первой миссии во вторую, чего в 6.9.1 версии нет. Причём, если во второй есть свой "ambience" - то работают оба. Просто ставлю перед фактом.

Doesn't happen for me.

If you have a way to reproduce, share the necessary files, saves and steps.

[Ethereal]

Okay.
But first you need to download and install my modification.  https://openxcom.org/forum/index.php/topic,5724.0.html

[Ethereal]

Now for the details. If the first mission has "ambienceRandom" and the second "ambience:", then the "ambience:" of the second mission is added to the "ambienceRandom" list of the first mission. In version 6.9.1 this is definitely not the case. Introduced with installation 6.9.6. Checked it three times on both versions.

Теперь подробности. Если первая миссия имеет "ambienceRandom", а вторая "ambience:", то "ambience:" второй миссии добавляется к списку "ambienceRandom" первой миссии. В версии 6.9.1 такого точно нет. Появилось с установкой 6.9.6. Проверил трижды на обеих версиях.

[Meridian]

The behavior is the same on v6.9.1 and v6.9.6

The different results are caused by RNG.

Your second stage has two different terrains with two different ambient sounds. The result depends on which terrain is picked.

Code: [Select]

  - type: STR_ALIEN_CAVE_MISSION_P2
...
    terrains:
      - UBASE
      - LEVEL


[Ethereal]

No, that's not the point. Both underground locations have NO bird sounds from the surface. UBASE does not have " ambience:". LEVEL has, and its " ambience: "is added to the "ambienceRandom" list from the previous level's location.

Нет, дело не в этом. На обоих подземных локациях НЕТ звуков птиц с поверхности. UBASE не имеет "ambience:". LEVEL имеет, и его "ambience:" добавляется в лист "ambienceRandom" с локации предыдущего уровня.

In short, there is a superimposition of "ambience:" and "ambienceRandom".

[Meridian]

"ambience" cannot be added to "ambienceRandom"... that is absolutely impossible. Variables are kept separated at all times.

On stage one, the variables contain:

Code: [Select]

  ambience: -1
  ambientVolume: 1.25
  ambienceRandom:
    - 1563
    - 1564
    - 1565
    - 1566
    - 1567
    - 1568
    - 1530
    - 1531
    - 1532
    - 1534
    - 1535

On stage two, for first terrain, the attributes contain:

Code: [Select]

  ambience: -1
  ambientVolume: 0.5
  ambienceRandom:
    []

On stage two, for second terrain, the attributes contain:

Code: [Select]

  ambience: 1494
  ambientVolume: 1
  ambienceRandom:
    - 1563
    - 1564
    - 1565
    - 1566
    - 1567
    - 1568
    - 1530
    - 1531
    - 1532
    - 1534
    - 1535

No superimposition.

ambienceRandom is from previous stage, ambience is from next stage and it was not added into the ambienceRandom list

[Ethereal]

I don't know where it came from.

Code: [Select]

alienDeployments:
  - type: STR_ALIEN_CAVE_MISSION
    terrains:
      - CULTACAV
    nextStage: STR_ALIEN_CAVE_MISSION_P2

  - type: STR_ALIEN_CAVE_MISSION_P2
    terrains:
      - UBASE
      - LEVEL

terrains:
  - name: CULTACAV
    script: FARMPCAV
    mapDataSets:
      - BLANKS
      - CULTIVAT
      - BARN
    ambienceRandom: [563, 564, 565, 566, 567, 568, 530, 531, 532, 534, 535]
    ambienceRandomDelay: [8, 16]
    ambientVolume: 1.25

  - name: UBASE
    mapDataSets:
      - BLANKS
      - U_BASE
      - U_WALL02
      - U_PODS
      - BRAIN
      - U_BASE2
      - U_DISEC2
      - U_OPER2
    script: ALIENBASE
    mapBlocks: &Ubase1
      - name: UBASE_00

  - name: LEVEL
    music:
      - GMTACWET
    ambience: 494
    ambientVolume: 1.0
    enviroEffects: STR_Underwater_D
    mapDataSets:
      - BLANKS
      - SEAORGANIC1
      - SEAORGANIC2
      - SEAORGANIC3
      - SEANOM
    script: TLETH_P2_P3
    mapBlocks:
      - name: LEVEL01

[Meridian]

It came from the previous stage.

I still don't get what you want from me:

1/ you said it works differently in 6.9.1 and 6.9.6 ... I have proved to you that it works the same way in both.

2/ I have also proved that the two attributes are not mixed, you can see it in the saved game yourself if you don't believe me

The correct solution is to not mix ambience with ambienceRandom... as it is described on the wiki: https://www.ufopaedia.org/index.php/Ruleset_Reference_Nightly_(OpenXcom)#Terrains
It explicitly says for ambienceRandom: "Doesn't work when ambience is defined."

The correct solution is to replace

Code: [Select]

ambience: 494

with

Code: [Select]

ambienceRandom: [494]

Stick to using either ambience or ambienceRandom, not both.


I can check if I can make it better, but for now it works as described on the wiki and on the forum.

[Ethereal]

I have it nowhere and does not mix.
Do you mean that can use either "ambience:" or "ambienceRandom" in general in the entire modification?
Why then in version 6.9.1 nothing of the kind was observed?

Changed to "ambienceRandom: [494]" - the sound stopped playing at all.

[Meridian]

Do you mean that can use either "ambience:" or "ambienceRandom" in general in the entire modification?

During the same mission, you should use only one of them.

Why then in version 6.9.1 nothing of the kind was observed?

I have observed it today many times in 6.9.1, there's a 50% chance for it to happen.

Attaching a video as proof.

[Ethereal]

I wrote about that that it is good to tie "ambience:" and "ambienceRandom" to "terrains.rul", not to the mission.

During the same mission, you should use only one of them.

Understand.