Author Topic: Bugs & Crash Reports  (Read 669168 times)

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 6824
  • OXCE developer
    • View Profile
    • My Wiki
Re: Bugs & Crash Reports
« Reply #720 on: July 25, 2016, 11:33:16 am »
Alright, just got a super annoying bug that is causing my game to hang indefinitely after winning a base defense.
Kill the last dude around the corner in the save (by the access lift) and watch the 'magic'.

I can reproduce this, will have a look in the evening and fix it.

Btw. turn 140?? :D

Offline Surrealistik

  • Colonel
  • ****
  • Posts: 456
    • View Profile
Re: Bugs & Crash Reports
« Reply #721 on: July 25, 2016, 11:38:17 am »
I can reproduce this, will have a look in the evening and fix it.

Btw. turn 140?? :D

Yeah man, 6 rookies vs an Academy battleship; it was 300 level brutal, only I won.
« Last Edit: July 25, 2016, 11:41:19 am by Surrealistik »

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 6824
  • OXCE developer
    • View Profile
    • My Wiki
Re: Bugs & Crash Reports
« Reply #722 on: July 25, 2016, 12:37:32 pm »
Yeah man, 6 rookies vs an Academy battleship; it was 300 level brutal, only I won.

Your hangar got destroyed during the attack... and the game got into endless loop when trying to delete stuff related to it. It seems to be a bug in vanilla (https://github.com/SupSuper/OpenXcom/blob/master/src/Savegame/Base.cpp#L1603), so instead of fixing it myself, I will open a bug in the bug tracker (https://openxcom.org/bugs/openxcom/issues/1254).

It fails on deleting the craft in transfer (because there are other things in transfer -- 4 soldiers).
I have deleted lines 3446-3602 from your save, now it works, you can do the same... pasting the text to delete below, just in case.

This deletes "Retarded Bank", "Soaring Herring", "Hell Arisu" and "Failin Seagull" from existence... you may want to re-hire them ;)

Code: [Select]
    transfers:
      - hours: 22
        soldier:
          type: STR_SOLDIER_S
          id: 64
          nationality: 0
          name: Retarded Bank
          initialStats:
            tu: 69
            stamina: 44
            health: 51
            psiStrength: 49
            psiSkill: 0
            melee: 46
            bravery: 60
            reactions: 59
            firing: 53
            throwing: 40
            strength: 42
          currentStats:
            strength: 42
            psiStrength: 49
            psiSkill: 0
            melee: 46
            tu: 69
            stamina: 44
            health: 51
            bravery: 60
            reactions: 59
            firing: 53
            throwing: 40
          rank: 0
          gender: 1
          look: 0
          lookVariant: 14
          missions: 0
          kills: 0
          armor: STR_ADVENTURER_OUTFIT_UC
          improvement: 0
          psiStrImprovement: 0
      - soldier:
          currentStats:
            tu: 69
            stamina: 43
            health: 41
            bravery: 20
            reactions: 57
            firing: 56
            throwing: 35
            strength: 40
            psiStrength: 25
            psiSkill: 0
            melee: 87
          initialStats:
            psiSkill: 0
            melee: 87
            tu: 69
            stamina: 43
            health: 41
            bravery: 20
            reactions: 57
            firing: 56
            throwing: 35
            strength: 40
            psiStrength: 25
          rank: 0
          gender: 1
          look: 1
          lookVariant: 4
          missions: 0
          kills: 0
          armor: STR_ADVENTURER_OUTFIT_UC
          improvement: 0
          psiStrImprovement: 0
          type: STR_SOLDIER_S
          id: 65
          nationality: 0
          name: Soaring Herring
        hours: 22
      - soldier:
          currentStats:
            tu: 67
            stamina: 77
            strength: 39
            psiStrength: 52
            psiSkill: 0
            melee: 77
            health: 56
            bravery: 70
            reactions: 63
            firing: 59
            throwing: 46
          rank: 0
          gender: 0
          look: 1
          lookVariant: 3
          missions: 0
          kills: 0
          armor: STR_ADVENTURER_OUTFIT_UC
          improvement: 0
          psiStrImprovement: 0
          type: STR_SOLDIER_S
          id: 66
          name: Hell Arisu
          nationality: 0
          initialStats:
            psiSkill: 0
            melee: 77
            tu: 67
            stamina: 77
            health: 56
            bravery: 70
            reactions: 63
            firing: 59
            throwing: 46
            strength: 39
            psiStrength: 52
        hours: 22
      - hours: 22
        soldier:
          rank: 0
          gender: 1
          look: 1
          lookVariant: 12
          missions: 0
          initialStats:
            tu: 80
            stamina: 37
            health: 47
            bravery: 50
            psiSkill: 0
            melee: 73
            reactions: 59
            firing: 47
            throwing: 34
            strength: 49
            psiStrength: 46
          type: STR_SOLDIER_S
          id: 67
          nationality: 0
          name: Flailin Seagull
          currentStats:
            psiStrength: 46
            psiSkill: 0
            melee: 73
            tu: 80
            stamina: 37
            health: 47
            bravery: 50
            reactions: 59
            firing: 47
            throwing: 34
            strength: 49
          kills: 0
          armor: STR_ADVENTURER_OUTFIT_UC
          improvement: 0
          psiStrImprovement: 0
« Last Edit: July 25, 2016, 12:50:03 pm by Meridian »

Offline Dioxine

  • Moderator
  • Commander
  • ***
  • Posts: 5254
  • punk not dead
    • View Profile
    • Nocturnal Productions
Re: Bugs & Crash Reports
« Reply #723 on: July 25, 2016, 01:38:10 pm »
It does crash. No idea why. I see no answers in the Crash Log, magically killing the last enemy in the save doesn't help, and I remember no precedence to guide me to find the solution - hanging upon mission end is something new.  Never seen anything like this before, but it might be just that my build is different (Commendations). Well, that's precisely why Ironman is unadvised - it's still a beta, and unless someone manages to hunt the bug down, and probably even then, you're fukked :P
« Last Edit: July 25, 2016, 02:00:34 pm by Dioxine »

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 6824
  • OXCE developer
    • View Profile
    • My Wiki
Re: Bugs & Crash Reports
« Reply #724 on: July 25, 2016, 02:11:19 pm »
What?
I provided a full explanation with a fix one post above.

Or are you talking about something else?

Offline Dioxine

  • Moderator
  • Commander
  • ***
  • Posts: 5254
  • punk not dead
    • View Profile
    • Nocturnal Productions
Re: Bugs & Crash Reports
« Reply #725 on: July 25, 2016, 04:18:58 pm »
Whoops, your post wasn't displayed for some reason (I didn't refresh before answering). I made a fool of myself :)

Offline Surrealistik

  • Colonel
  • ****
  • Posts: 456
    • View Profile
Re: Bugs & Crash Reports
« Reply #726 on: July 25, 2016, 08:51:32 pm »
Your hangar got destroyed during the attack... and the game got into endless loop when trying to delete stuff related to it. It seems to be a bug in vanilla (https://github.com/SupSuper/OpenXcom/blob/master/src/Savegame/Base.cpp#L1603), so instead of fixing it myself, I will open a bug in the bug tracker (https://openxcom.org/bugs/openxcom/issues/1254).

It fails on deleting the craft in transfer (because there are other things in transfer -- 4 soldiers).
I have deleted lines 3446-3602 from your save, now it works, you can do the same... pasting the text to delete below, just in case.

This deletes "Retarded Bank", "Soaring Herring", "Hell Arisu" and "Failin Seagull" from existence... you may want to re-hire them ;)

Code: [Select]
    transfers:
      - hours: 22
        soldier:
          type: STR_SOLDIER_S
          id: 64
          nationality: 0
          name: Retarded Bank
          initialStats:
            tu: 69
            stamina: 44
            health: 51
            psiStrength: 49
            psiSkill: 0
            melee: 46
            bravery: 60
            reactions: 59
            firing: 53
            throwing: 40
            strength: 42
          currentStats:
            strength: 42
            psiStrength: 49
            psiSkill: 0
            melee: 46
            tu: 69
            stamina: 44
            health: 51
            bravery: 60
            reactions: 59
            firing: 53
            throwing: 40
          rank: 0
          gender: 1
          look: 0
          lookVariant: 14
          missions: 0
          kills: 0
          armor: STR_ADVENTURER_OUTFIT_UC
          improvement: 0
          psiStrImprovement: 0
      - soldier:
          currentStats:
            tu: 69
            stamina: 43
            health: 41
            bravery: 20
            reactions: 57
            firing: 56
            throwing: 35
            strength: 40
            psiStrength: 25
            psiSkill: 0
            melee: 87
          initialStats:
            psiSkill: 0
            melee: 87
            tu: 69
            stamina: 43
            health: 41
            bravery: 20
            reactions: 57
            firing: 56
            throwing: 35
            strength: 40
            psiStrength: 25
          rank: 0
          gender: 1
          look: 1
          lookVariant: 4
          missions: 0
          kills: 0
          armor: STR_ADVENTURER_OUTFIT_UC
          improvement: 0
          psiStrImprovement: 0
          type: STR_SOLDIER_S
          id: 65
          nationality: 0
          name: Soaring Herring
        hours: 22
      - soldier:
          currentStats:
            tu: 67
            stamina: 77
            strength: 39
            psiStrength: 52
            psiSkill: 0
            melee: 77
            health: 56
            bravery: 70
            reactions: 63
            firing: 59
            throwing: 46
          rank: 0
          gender: 0
          look: 1
          lookVariant: 3
          missions: 0
          kills: 0
          armor: STR_ADVENTURER_OUTFIT_UC
          improvement: 0
          psiStrImprovement: 0
          type: STR_SOLDIER_S
          id: 66
          name: Hell Arisu
          nationality: 0
          initialStats:
            psiSkill: 0
            melee: 77
            tu: 67
            stamina: 77
            health: 56
            bravery: 70
            reactions: 63
            firing: 59
            throwing: 46
            strength: 39
            psiStrength: 52
        hours: 22
      - hours: 22
        soldier:
          rank: 0
          gender: 1
          look: 1
          lookVariant: 12
          missions: 0
          initialStats:
            tu: 80
            stamina: 37
            health: 47
            bravery: 50
            psiSkill: 0
            melee: 73
            reactions: 59
            firing: 47
            throwing: 34
            strength: 49
            psiStrength: 46
          type: STR_SOLDIER_S
          id: 67
          nationality: 0
          name: Flailin Seagull
          currentStats:
            psiStrength: 46
            psiSkill: 0
            melee: 73
            tu: 80
            stamina: 37
            health: 47
            bravery: 50
            reactions: 59
            firing: 47
            throwing: 34
            strength: 49
          kills: 0
          armor: STR_ADVENTURER_OUTFIT_UC
          improvement: 0
          psiStrImprovement: 0

Wait, what do you mean it got 'destroyed'?

It was under construction; how would that even be possible? Does the landing craft randomly destroy facilities, including under construction facilities, when it attacks the base?

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 6824
  • OXCE developer
    • View Profile
    • My Wiki
Re: Bugs & Crash Reports
« Reply #727 on: July 25, 2016, 09:46:02 pm »
Wait, what do you mean it got 'destroyed'?

It was under construction; how would that even be possible? Does the landing craft randomly destroy facilities, including under construction facilities, when it attacks the base?

The facilities get destroyed by too much use of explosives during the mission... both by you and by the AI. Landing craft doesn't damage them at all.
I didn't know it applies to facilities being built too, but obviously it does.
Also, if any facilities get "disconnected" from the airlock because of other destroyed facilities, they are destroyed too.

Offline Surrealistik

  • Colonel
  • ****
  • Posts: 456
    • View Profile
Re: Bugs & Crash Reports
« Reply #728 on: July 25, 2016, 09:51:41 pm »
The facilities get destroyed by too much use of explosives during the mission... both by you and by the AI. Landing craft doesn't damage them at all.
I didn't know it applies to facilities being built too, but obviously it does.
Also, if any facilities get "disconnected" from the airlock because of other destroyed facilities, they are destroyed too.

So my two mininuke detonations in the workshops and large barracks randomly destroyed the under construction Hangar?

What? How does the game decide which facilities get destroyed? Is it luck of the draw?

That said, this is good to know.

Offline Starving Poet

  • Colonel
  • ****
  • Posts: 269
    • View Profile
Re: Bugs & Crash Reports
« Reply #729 on: July 25, 2016, 11:49:35 pm »
There are certain items in each facility that, when destroyed, count as facility destruction.   In the workshops, it's the tables.  I'm not sure what counts as destruction for the large hangars. 

Offline legionof1

  • Commander
  • *****
  • Posts: 1760
  • Bullets go that way. Money comes this way.
    • View Profile
Re: Bugs & Crash Reports
« Reply #730 on: July 26, 2016, 01:47:53 am »
In vanilla hangers where immune to destruction as well as the lift. Good to know they can go boom....I guess. Though what constitutes boom would be nice to know. I've thrown Chinese dragons into my hangers without issues several times.

Offline Surrealistik

  • Colonel
  • ****
  • Posts: 456
    • View Profile
Re: Bugs & Crash Reports
« Reply #731 on: July 26, 2016, 02:14:28 am »
There is no reason they should go 'boom' in this case though; the hangar wasn't even constructed or on the map, and it wasn't damaged by any explosions! Literally makes no sense at all. Total bug.

Offline Star_Treasure

  • Captain
  • ***
  • Posts: 96
    • View Profile
Re: Bugs & Crash Reports
« Reply #732 on: July 26, 2016, 02:23:32 am »
In vanilla hangers where immune to destruction as well as the lift. Good to know they can go boom....I guess. Though what constitutes boom would be nice to know. I've thrown Chinese dragons into my hangers without issues several times.

It might make sense to allow the planes inside the hangars to be destroyed rather than the hangar itself.

Also, instead of having facilities be destroyed because they were cut off from the rest of the base, how bout replacing destroyed facilities with "Rubble" which has to be cleared before repairs are made, but still counts as connecting.

Offline Surrealistik

  • Colonel
  • ****
  • Posts: 456
    • View Profile
Re: Bugs & Crash Reports
« Reply #733 on: July 26, 2016, 02:28:17 am »
Also, instead of having facilities be destroyed because they were cut off from the rest of the base, how bout replacing destroyed facilities with "Rubble" which has to be cleared before repairs are made, but still counts as connecting.

Yes please; either that or they get replaced with basic corridors.

Offline Surrealistik

  • Colonel
  • ****
  • Posts: 456
    • View Profile
Re: Bugs & Crash Reports
« Reply #734 on: July 26, 2016, 09:40:44 am »
Another base invasion related crash; this time a Breaker UFO aptly breaks my game as it boldly attempts to invade FAGULON PRIME itself against all better judgement.
« Last Edit: July 26, 2016, 10:23:04 am by Surrealistik »