Author Topic: Bugs & Crash Reports  (Read 669202 times)

Offline xaphias

  • Captain
  • ***
  • Posts: 57
    • View Profile
Re: Bugs & Crash Reports
« Reply #60 on: December 09, 2015, 09:37:55 pm »
it was 0.97, but 0.97A didn't help. it was upgraded save from 0.96 tho, but I followed all the instructions.
ok, so it might just be an incompatable savefile? since I read that all missions are like generated at start and saved in the savefile? something like that?

Offline Arthanor

  • Commander
  • *****
  • Posts: 2490
  • XCom Armoury Quartermaster
    • View Profile
Re: Bugs & Crash Reports
« Reply #61 on: December 09, 2015, 09:48:53 pm »
If you want to upgrade, you need to read the information in this topic. You can't just slap a new mod version on and load an old save.

In this case, upgrading from 0.96 to 0.97 required you to remove all government patrol missions from your save. You have two of them which are ongoing, and you have them listed in every other regions.

So you did not upgrade your save to be compatible with the new mod version, that's why the missions are causing a crash at the end of the month. Nothing wrong with the mod :P

To make your save compatible, you need to:
- remove both instances of "STR_MISSION_GOVT_PATROL" along with their parameters, in the "alienMissions" section
- remove the "STR_MISSION_GOVT_PATROL:" (followed by a number), in the possibleMissions section

Upgrading the mod while continuing a campaign requires some work (always outlined in the topic I linked above). Otherwise, it is much safer to stick to one version for one campaign.
« Last Edit: December 09, 2015, 09:50:52 pm by Arthanor »

Offline xaphias

  • Captain
  • ***
  • Posts: 57
    • View Profile
Re: Bugs & Crash Reports
« Reply #62 on: December 09, 2015, 10:16:39 pm »
ok thank you, I must have missed the govt patrol thing, removed now.

Offline Dioxine

  • Moderator
  • Commander
  • ***
  • Posts: 5254
  • punk not dead
    • View Profile
    • Nocturnal Productions
Re: Bugs & Crash Reports
« Reply #63 on: December 10, 2015, 02:18:37 am »
0.97 was a major upgrade, 0.97A doesn't have any save incompatibility with 0.97, and this is usually the norm.

Offline Imeryak

  • Sergeant
  • **
  • Posts: 36
    • View Profile
Re: Bugs & Crash Reports
« Reply #64 on: December 11, 2015, 06:22:50 pm »
Piratez 0.97A. Xeno Armor require STR_CHURCH_MEDIC, which is missing in factions ruleset.

Offline Dioxine

  • Moderator
  • Commander
  • ***
  • Posts: 5254
  • punk not dead
    • View Profile
    • Nocturnal Productions
Re: Bugs & Crash Reports
« Reply #65 on: December 11, 2015, 06:40:24 pm »
Should be replaced with STR_BEASTMASTER_TERRORIST

Offline Cristao

  • Colonel
  • ****
  • Posts: 370
    • View Profile
Re: Bugs & Crash Reports
« Reply #66 on: December 11, 2015, 06:44:41 pm »
I didnt find any reference to CHURCH_MEDIC in the rulesets! What ruleset did you find it in and line number (if you are using Notepad++)?

Offline Arthanor

  • Commander
  • *****
  • Posts: 2490
  • XCom Armoury Quartermaster
    • View Profile
Re: Bugs & Crash Reports
« Reply #67 on: December 11, 2015, 06:49:32 pm »
It's in Piratez.rul, lines 21537, for the armor pre-requisite. There is also a research project for the church medic, at line 23039, which I'm not sure what to do with, since there is already a research project for the beastmaster (so you don't really want to change the STR_CHURCH_MEDIC research project to a second STR_BEASTMASTER_TERRORIST project).

Offline Dioxine

  • Moderator
  • Commander
  • ***
  • Posts: 5254
  • punk not dead
    • View Profile
    • Nocturnal Productions
Re: Bugs & Crash Reports
« Reply #68 on: December 11, 2015, 06:53:33 pm »
I think the STR_CHURCH_MEDIC research project can be safely deleted. Or you can keep it to see if it doesn't pop up out of sudden somewhere (there's no language string to it, so easy to spot). Only add STR_MISSION_CONVERSION to the STR_BEASTMASTER_TERRORIST "getOneFree" list.

Offline Cristao

  • Colonel
  • ****
  • Posts: 370
    • View Profile
Re: Bugs & Crash Reports
« Reply #69 on: December 11, 2015, 09:06:58 pm »
I must have a different Piratez.rul

I find my first dependency on line 21610 in the Crystalisk armor and on line 23112, the research project. If I change needItem to false in the research code, would that be fine?

I think there is 73 lines of code missing from your .rul file, Arthanor (if it is 0.97A). I commented the dependency out using #.
« Last Edit: December 11, 2015, 09:15:40 pm by Cristao »

Offline Arthanor

  • Commander
  • *****
  • Posts: 2490
  • XCom Armoury Quartermaster
    • View Profile
Re: Bugs & Crash Reports
« Reply #70 on: December 11, 2015, 09:20:29 pm »
ah! Sorry, I haven't upgraded to 0.97A yet as I am in the middle of a battle (and it is better not to upgrade mid-battle).

I just downloaded 0.97A and I find the STR_CHURCH_MEDIC on the exact same line as before though.. so I don't know what's up with your version.

needItem is a rather different thing from dependencies, so I wouldn't try to fix things this way. Just make sure that the dependencies for STR_CRYSTALISK_ARMOR (whichever line that is for you) are:

      - STR_SKINNING
      - STR_CHRYSSALID_CORPSE
      - STR_CELATID_CORPSE
      - STR_CHRYSSALID
      - STR_CELATID
      - STR_BEASTMASTER_TERRORIST


then in the STR_BEASTMASTER_TERRORIST getOneFree list, add - STR_MISSION_CONVERSION

Offline Dioxine

  • Moderator
  • Commander
  • ***
  • Posts: 5254
  • punk not dead
    • View Profile
    • Nocturnal Productions
Re: Bugs & Crash Reports
« Reply #71 on: December 11, 2015, 11:00:21 pm »
There's no needItem in the STR_CRYSTALISK_ARMOR entry... ???

Offline DracoGriffin

  • Colonel
  • ****
  • Posts: 306
    • View Profile
    • Steam: DracoGriffin
Re: Bugs & Crash Reports
« Reply #72 on: December 11, 2015, 11:23:48 pm »
And this is why I prefer new campaigns over upgrading save games.

Offline Cristao

  • Colonel
  • ****
  • Posts: 370
    • View Profile
Re: Bugs & Crash Reports
« Reply #73 on: December 11, 2015, 11:26:07 pm »
There's no needItem in the STR_CRYSTALISK_ARMOR entry... ???
Apologies - dependency

Code: [Select]
  - name: STR_CRYSTALISK_ARMOR
    cost: 25
    points: 50
    dependencies:
      - STR_SKINNING
      - STR_CHRYSSALID_CORPSE
      - STR_CELATID_CORPSE
      - STR_CHRYSSALID
      - STR_CELATID
      - STR_CHURCH_MEDIC

Offline Arthanor

  • Commander
  • *****
  • Posts: 2490
  • XCom Armoury Quartermaster
    • View Profile
Re: Bugs & Crash Reports
« Reply #74 on: December 12, 2015, 02:19:06 am »
And this is why I prefer new campaigns over upgrading save games.

But sometimes upgrading solves bugs that you have in your current version! (as would be the case with upgrading to 0.97B or 0.98 which will presumably solve the STR_CHURCH_MEDIC issue discussed here).

@Cristao:
So.. replace STR_CHURCH_MEDIC with STR_BEASTMASTER_TERRORIST in the dependency you just showed. Nothing else really needs to be changed. Did that not work?