[OLD] Old OXCE discussion thread

[Yankes]

https://openxcom.org/forum/index.php/topic,4187.msg75725.html#msg75725

[Meridian]

https://openxcom.org/forum/index.php/topic,4187.msg75725.html#msg75725

It's something else, I get the crash too now with a better save, see attached.

[ohartenstein23]

Yeah, I've updated my previous post with some more information I was able to get from the crash.  The lighting engine is trying to place a source (it looks like it's a tile on fire) out of bounds.

[Yankes]

ok, I will look on this too.

[Yankes]

Yeah, I've updated my previous post with some more information I was able to get from the crash.  The lighting engine is trying to place a source (it looks like it's a tile on fire) out of bounds.

that was result of completely different bug elsewhere. `init` was call multiple times in `generateMap`. In normal OXC it cause memory leak, in my version it mangle tile data:
https://github.com/SupSuper/OpenXcom/blob/master/src/Savegame/SavedBattleGame.cpp#L510
https://github.com/Yankes/OpenXcom/blob/master/src/Savegame/SavedBattleGame.cpp#L483

There is commit for cherry-pick that fix it:
https://github.com/Yankes/OpenXcom/commit/01047ce61a0cba0ea70a517b093d17f9c7a5091b

[ohartenstein23]

Huh, that's a really strange bug for just moving that line down a few spots.  Thanks for looking into it!

[Yankes]

Huh, that's a really strange bug for just moving that line down a few spots.  Thanks for looking into it!

strange is why it surfaced now,  not year ago when I made switch from pointers to vector for tiles.

[Meridian]

So, is this wrong in vanilla too? (it does look wrong to me) We should probably report it if yes...

[Yankes]

So, is this wrong in vanilla too? (it does look wrong to me) We should probably report it if yes...

Yup, overall `if (!_nodes.empty())` condition is bit dodgy. It hard to say if `_mapDataSets.clear();` should be cleared or not in that case of `case MSC_RESIZE:` in "BattlescapeGenerator.cpp".

[TheSHEEEP]

I tried getting the current git version to run on Ubuntu 64bit. Compiled with CMake, and building & install went fine.
I copied the UFO files, but when I try to start, I get this in the log:

[18-12-2016_13-49-36]   [INFO]   Data folder is: /usr/local/sharehttps://openxcom/
[18-12-2016_13-49-36]   [INFO]   Data search is:
[18-12-2016_13-49-36]   [INFO]   - /home/thesheeep/.local/share/openxcom/
[18-12-2016_13-49-36]   [INFO]   - /usr/share/ubuntu/openxcom/
[18-12-2016_13-49-36]   [INFO]   - /usr/share/gnome/openxcom/
[18-12-2016_13-49-36]   [INFO]   - /usr/local/sharehttps://openxcom/
[18-12-2016_13-49-36]   [INFO]   - /usr/sharehttps://openxcom/
[18-12-2016_13-49-36]   [INFO]   - /var/lib/snapd/desktop/openxcom/
[18-12-2016_13-49-36]   [INFO]   - /usr/local/share/openxcom/
[18-12-2016_13-49-36]   [INFO]   - /usr/share/openxcom/
[18-12-2016_13-49-36]   [INFO]   - /usr/local/share/openxcomhttps://
[18-12-2016_13-49-36]   [INFO]   - ./
[18-12-2016_13-49-36]   [INFO]   User folder is: /home/thesheeep/.openxcom/
[18-12-2016_13-49-36]   [INFO]   Config folder is: /home/thesheeep/.config/openxcom/
[18-12-2016_13-49-36]   [INFO]   Options loaded successfully.
[18-12-2016_13-49-36]   [INFO]   SDL initialized successfully.
[18-12-2016_13-49-36]   [INFO]   SDL_mixer initialized successfully.
[18-12-2016_13-49-36]   [INFO]   requested file not found: openxcom.png
[18-12-2016_13-49-36]   [INFO]   Attempting to set display to 640x400x8...
[18-12-2016_13-49-36]   [INFO]   Display set to 640x400x8.
[18-12-2016_13-49-36]   [INFO]   Loading data...
[18-12-2016_13-49-36]   [INFO]   Scanning standard mods in '/usr/local/sharehttps://openxcom/standard'...
[18-12-2016_13-49-36]   [INFO]   Scanning user mods in '/home/thesheeep/.openxcom/mods'...
[18-12-2016_13-49-36]   [INFO]   no master already active; activating xcom1
[18-12-2016_13-49-36]   [INFO]   Mapping resource files...
[18-12-2016_13-49-36]   [INFO]   Resources files mapped successfully.
[18-12-2016_13-49-37]   [WARN]   disabling mod with invalid ruleset: xcom1
[18-12-2016_13-49-37]   [ERROR]   failed to load 'UFO: Enemy Unknown / X-Com: UFO Defense'; mod disabled for next startup
Sprite Set BIGOBS.PCK not found

Not exactly sure what to make of that.

[Yankes]

You probably copy UFO data to wrong place, check if you do it correctly (it should be placed in same place as in normal version of OXC)

[TheSHEEEP]

Well, it says:
Data folder is: /usr/local/sharehttps://openxcom/
and there is an UFO folder in that folder containing the game data.

It works perfectly fine with the normal nightly (Ubuntu package) like that - no worries, I removed that before building OXE.
I just wanted to get Piratez to work on my Ubuntu (there is no prebuilt download for OXE that I could find), but it seems that is out of the question for now.

[Meridian]

For PirateZ, you will need OXCE+ (OpenXcom Extended Plus), which is a fork of OXCE (OpenXcom Extended).

And there are pre-built executables (also for Linux) here: https://openxcom.org/forum/index.php/topic,4187.0.html
Or directly here: https://lxnt.wtf/oxem/

For current PirateZ version (0.99e2) you will need version 3.3, not 3.5.

[Yankes]

Well, it says:
Data folder is: /usr/local/sharehttps://openxcom/
and there is an UFO folder in that folder containing the game data.

It works perfectly fine with the normal nightly (Ubuntu package) like that - no worries, I removed that before building OXE.
I just wanted to get Piratez to work on my Ubuntu (there is no prebuilt download for OXE that I could find), but it seems that is out of the question for now.

how look nightly log? It should look exactly same and work sane but as we see is not. you compiled my OXCE yourself and nightly is downloaded?

and for Piratez as Meridian said it use this branch that is based on my. Biggest difference is lack of UI improvements from Meridian, another some new gameplay mechanics added but not yet ported to my brach (I plans get most of them to my branch at some point).

[TheSHEEEP]

For PirateZ, you will need OXCE+ (OpenXcom Extended Plus), which is a fork of OXCE (OpenXcom Extended).

Ah, no wonder I got confused about that.
Well, I'll have a shot at it then with the prebuilt ones.

Edit: Works!