Author Topic: [OLD] Old OXCE discussion thread  (Read 663111 times)

Offline Ethereal

  • Commander
  • *****
  • Posts: 619
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1575 on: August 31, 2018, 06:47:37 pm »
Biggest difference is that you can assign arbitrary value to healing time. If solder is robot, it will not need any time to heal.

Understood. Thank you very much. For my mod is extremely useful.

Offline ohartenstein23

  • Commander
  • *****
  • Posts: 1931
  • Flamethrowers fry cyberdisk circuits
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1576 on: August 31, 2018, 07:15:29 pm »
If solder is robot, it will not need any time to heal.

This is already available in OXCE+ as a tag on armor to determine whether or not a unit takes any wound time:
Code: [Select]
armors:
  - type: STR_ROBOT_ARMOR
    instantWoundRecovery: true

However, the script will be useful for reducing wound time on units used as HP tanks.

Offline Yankes

  • Moderator
  • Commander
  • ***
  • Posts: 3192
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1577 on: September 01, 2018, 12:39:52 am »
This is already available in OXCE+ as a tag on armor to determine whether or not a unit takes any wound time:
Code: [Select]
armors:
  - type: STR_ROBOT_ARMOR
    instantWoundRecovery: true

However, the script will be useful for reducing wound time on units used as HP tanks.
Exactly, scripts are for "custom" behaviors, like now wounds could count to recovery days or even heal up damage still counts.
You could make that for some armor only some type of damage do pernamet damage.

But this only "side effect" of changes I add, you can made that solder after each kill of some specific alien will grain 1 dmg bonus against same type in next battle.
Or after 10 missions it will take break for week (right now indistinguishable from "wounds" but in future I will add option to change this).

Offline LouisdeFuines

  • Commander
  • *****
  • Posts: 586
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1578 on: September 01, 2018, 09:50:13 am »
New version 4.0 us up:
I installed the latest OXCE+, but game keeps telling me, that it is version 3.10b. Have I done somethring wrong?

Offline The Reaver of Darkness

  • Commander
  • *****
  • Posts: 1510
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1579 on: September 01, 2018, 12:24:14 pm »
I installed the latest OXCE+, but game keeps telling me, that it is version 3.10b. Have I done somethring wrong?
Yankes released version 4.0 of OXCE. Meridian's OXCE+ is currently in version 3.10b.

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 8595
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1580 on: September 04, 2018, 12:39:33 pm »
CTD when moving items in the inventory (when opened from the craft equipment screen in the basescape).

Please hotfix.

Offline Yankes

  • Moderator
  • Commander
  • ***
  • Posts: 3192
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1581 on: September 04, 2018, 08:07:49 pm »
Any more bugs or things to change? Only this, did you find?

Offline Yankes

  • Moderator
  • Commander
  • ***
  • Posts: 3192
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1582 on: September 04, 2018, 11:13:20 pm »

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 8595
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1583 on: September 04, 2018, 11:55:37 pm »
Any more bugs or things to change? Only this, did you find?

I found a few small things, but I'm not finished merging yet, hopefully by the end of this week I can give more feedback.

Fixed version ready: https://github.com/Yankes/OpenXcom/commits/OpenXcomExtended

Thx.

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 8595
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1584 on: September 05, 2018, 05:58:06 pm »
So, I am more or less finished with merging.
So far, I didn't get any new crashes after clicking through the game for about 2-3 hours.

I found a few things:
1/ it's not possible to manufacture both craft and items in the same project anymore... but I checked a few mods and it is not used anymore as far as I can say... so OK for me

2/ there is an unused Base parameter here: https://github.com/Yankes/OpenXcom/blob/OpenXcomExtended/src/Savegame/Transfer.h#L67
(not sure if implementation is missing or parameter is not needed)

3/ there is probably a merge typo here?: https://github.com/Yankes/OpenXcom/blob/OpenXcomExtended/src/Geoscape/DogfightState.cpp#L1098
Vanilla has
Code: [Select]
newMission->start(newMission->getRules().getWave(0).spawnTimer); // fixed delay for first scout
OXCE has
Code: [Select]
newMission->start(mission->getRules().getWave(0).spawnTimer); // fixed delay for first scout
[/code]

4/ DEBUG mode in Ufopedia doesn't show all articles anymore
« Last Edit: September 05, 2018, 06:23:38 pm by Meridian »

Offline Yankes

  • Moderator
  • Commander
  • ***
  • Posts: 3192
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1585 on: September 05, 2018, 08:30:23 pm »
1/ I recall place in code that previously prevent adding items if it build craft. This mean if I'm right you could not use it correctly before.
This line: https://github.com/SupSuper/OpenXcom/blob/master/src/Savegame/Production.cpp#L133
2/ Right now not used, It will be used when I add hangars types (side effect of rebase that remove it from this release).
3/ Right, typo.
4/ I do not recall changing any thing that could affect this. This could be missmerge or change from nightly. I will look on this too.

Thanks for your findings :)
« Last Edit: September 06, 2018, 12:43:31 am by Yankes »

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 8595
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1586 on: September 06, 2018, 06:36:21 pm »
4/ I do not recall changing any thing that could affect this. This could be missmerge or change from nightly. I will look on this too.

Looks like a forgotten parameter after refactoring.
Here's a fix: https://github.com/MeridianOXC/OpenXcom/commit/e19f743eacff1871d5bd5dd02da0ae09d0699582

5/ And one more, "requiresBuy" in RuleItem didn't work at all, here's a fix: https://github.com/MeridianOXC/OpenXcom/commit/7a2543c1cd0caa5e84a5158973cef8f1f7922f34
« Last Edit: September 06, 2018, 07:16:41 pm by Meridian »

Offline Yankes

  • Moderator
  • Commander
  • ***
  • Posts: 3192
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1587 on: September 06, 2018, 07:46:59 pm »
Thanks for findings

Offline Moon_Dew

  • Sergeant
  • **
  • Posts: 43
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1588 on: September 07, 2018, 10:57:41 am »
Download it? (link to mediafire is in first post). This is replacement for recent nightly. If you have already installed new nighlty you can drop my exe in folder where nightly have its own exe.

...okay, I don't know why, but I can't wrap my head around this.  Again, how do I download Open XCom Extended?

Offline Meridian

  • Global Moderator
  • Commander
  • ***
  • Posts: 8595
    • View Profile
Re: [OXCE] OpenXcom Extended
« Reply #1589 on: September 07, 2018, 11:45:59 am »
...okay, I don't know why, but I can't wrap my head around this.  Again, how do I download Open XCom Extended?

If you want OXCE, download link is here: https://openxcom.org/forum/index.php/topic,2915.0.html

If you want OXCE+, download link is here: https://openxcom.org/forum/index.php/topic,5258.0.html