Author Topic: 1.0.518a651-dirty  (Read 1202 times)

Offline Cooper

  • Colonel
  • ****
  • Posts: 116
  • No line of fire
    • View Profile
1.0.518a651-dirty
« on: October 10, 2016, 07:30:12 pm »
Hello everyone!
After a few months break from openxcom Im finally back. However I ran on to this problem on my fresh installation. Does it mean something is wrong with the installation?

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 4867
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: 1.0.518a651-dirty
« Reply #1 on: October 10, 2016, 07:41:29 pm »
No, probably everything alright.

Just in case: where did you get your build from?

Offline Cooper

  • Colonel
  • ****
  • Posts: 116
  • No line of fire
    • View Profile
Re: 1.0.518a651-dirty
« Reply #2 on: October 10, 2016, 08:11:24 pm »
Alright :)
Its from https://openxcom.org/git-builds/ > Ubuntu   

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 4867
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: 1.0.518a651-dirty
« Reply #3 on: October 10, 2016, 08:15:18 pm »
Everything alright then.
It's not the newest version, but quite recent (10th June 2016).

Offline R1dO

  • Colonel
  • ****
  • Posts: 242
    • View Profile
Re: 1.0.518a651-dirty
« Reply #4 on: October 11, 2016, 01:43:11 am »
The dirty tag is there to remind people that the exe was build using source-code with alterations to tracked files based on the specific commit (518a651 in this case).
Alterations could mean anything ranging from a simple comma in a readme file to massive source code alterations.

Think of it as a warning message telling devs that it would be hard (if not impossible) to exactly recreate the exe when investigating strange behavior.

What is strange though is that this 'rogue' build ended up as an official git-build.

Offline SupSuper

  • Lazy Developer
  • Administrator
  • Commander
  • *****
  • Posts: 2108
    • View Profile
Re: 1.0.518a651-dirty
« Reply #5 on: October 16, 2016, 10:01:27 pm »
The dirty tag is there to remind people that the exe was build using source-code with alterations to tracked files based on the specific commit (518a651 in this case).
Alterations could mean anything ranging from a simple comma in a readme file to massive source code alterations.

Think of it as a warning message telling devs that it would be hard (if not impossible) to exactly recreate the exe when investigating strange behavior.

What is strange though is that this 'rogue' build ended up as an official git-build.
Any changes to build makefiles, which you might make in order to automatically build nightly packages, would count as "dirty" no?

Offline R1dO

  • Colonel
  • ****
  • Posts: 242
    • View Profile
Re: 1.0.518a651-dirty
« Reply #6 on: October 17, 2016, 01:51:56 am »
It would if those files are under git control.

For this specific case i suspect the following files cause the dirty tag:
Code: [Select]
install/debian/changelog
install/debian/control

The second one could have an easy fix (propagate the requirement to the master branch, although i would recommend a slight change in order to allow people with older yaml versions to run the nighlies as well)

The first one is more difficult since it will change on each build.

Offline knapsu

  • Sergeant
  • **
  • Posts: 19
    • View Profile
Re: 1.0.518a651-dirty
« Reply #7 on: February 27, 2017, 11:40:42 am »
Hey! Sorry for digging up such an old thread... The problem with version number is now fixed. I had a typo in my automated build scripts which resulted in OPENXCOM_VERSION_STRING always sticking with commit hash 518a651 despite sources being in more recent version. I've checked the latest builds and it is good now.