Author Topic: MAPVIEW upgrade  (Read 262694 times)

Offline kevL

  • Colonel
  • ****
  • Posts: 471
  • pitchforks and torches
    • View Profile
Re: MAPVIEW upgrade
« Reply #240 on: September 05, 2018, 08:16:53 pm »
new toolbar look

+ fixing holes, lots of holes glitches oversights etc

TopView and TopRouteView(Top) are playing nicer together ...

search feels pretty sturdy, next is out of bounds nodes getting RouteView and TopRouteView(Route) to play nicer together i guess.
« Last Edit: September 06, 2018, 06:49:34 am by kevL »

Offline kevL

  • Colonel
  • ****
  • Posts: 471
  • pitchforks and torches
    • View Profile
Re: MAPVIEW upgrade
« Reply #241 on: September 08, 2018, 09:13:54 pm »
preview
https://drive.google.com/file/d/1oz2aj1BnOvlsynPDWI2vtwY2MJ2eOpd9/view


edit: wow, glitches galore when a guy pokes his nose around for a bit,

guess I'll have to start versioning :\

ver 2.2 https://github.com/kevL/OpenXCOM.Tools/tree/master/Distribution

suggest: backup your current exe's and dll's since ver 2.2 has beta-like stuff in it. ( /settings folder has not changed )



I'll be fine eventually. -o-
http://files.libertyfund.org/pll/quotes/207.html
« Last Edit: September 10, 2018, 10:41:12 am by kevL »

Offline hellrazor

  • Commander
  • *****
  • Posts: 2011
  • Deep Ruleset Digger & Bughunter
    • View Profile
    • Github Account
Re: MAPVIEW upgrade
« Reply #242 on: September 22, 2018, 10:59:40 am »
Thanks for your effort so far. I am gonna try out your new version.

Even thou I am still missing some way to run this natively under Linux...

Fixing that paths are read the normal with "/" would help a lot...

EDIT: The configconverter seems to be working correctly. What also would be nice is if you would allow convert of Images.dat file, which handles custom MCD File entries.
« Last Edit: September 22, 2018, 11:07:50 am by hellrazor »

Offline Stoddard

  • Colonel
  • ****
  • Posts: 485
  • in a fey mood
    • View Profile
    • Linux builds & stuff
Re: MAPVIEW upgrade
« Reply #243 on: September 22, 2018, 04:56:55 pm »

Even thou I am still missing some way to run this natively under Linux...


It does run under wine, although quite slowly.

Instructions:

  • Add wine repository as per https://wiki.winehq.org/Ubuntu
  • install wine-stable: apt update ; apt install winehq-stable winetricks
  • initialize 32bit prefix: WINEARCH=win32 winecfg
  • Install dotnet35sp1: winetricks dotnet35sp1

re TFTD - it does spew some fishy warnings about route nodes being outside the map for some of them

Offline hellrazor

  • Commander
  • *****
  • Posts: 2011
  • Deep Ruleset Digger & Bughunter
    • View Profile
    • Github Account
Re: MAPVIEW upgrade
« Reply #244 on: September 22, 2018, 05:05:58 pm »
It does run under wine, although quite slowly.

Instructions:

  • Add wine repository as per https://wiki.winehq.org/Ubuntu
  • install wine-stable: apt update ; apt install winehq-stable winetricks
  • initialize 32bit prefix: WINEARCH=win32 winecfg
  • Install dotnet35sp1: winetricks dotnet35sp1

re TFTD - it does spew some fishy warnings about route nodes being outside the map for some of them

I know you can run it under wine, but that really is not performant in any way.

The main issue with running it under linux, ewith a mono compiled set is a Alpha transparency issue.
See here: https://openxcom.org/forum/index.php/topic,1321.msg46066.html#msg46066

Not a problem of MapView in itself thou.

Offline Stoddard

  • Colonel
  • ****
  • Posts: 485
  • in a fey mood
    • View Profile
    • Linux builds & stuff
Re: MAPVIEW upgrade
« Reply #245 on: September 22, 2018, 05:30:30 pm »
Well yes, it's unacceptably slow under wine.

Compiling with Mono fails -

Code: [Select]
CSC: error CS2001: Source file `XConsole.cs' could not be found



@kevL maybe you know what's this about?

EDIT: aha, it's XConsole.cs in .csproj, but xConsole.cs on disk.
« Last Edit: September 22, 2018, 05:34:02 pm by Stoddard »

Offline hellrazor

  • Commander
  • *****
  • Posts: 2011
  • Deep Ruleset Digger & Bughunter
    • View Profile
    • Github Account
Re: MAPVIEW upgrade
« Reply #246 on: September 22, 2018, 05:33:34 pm »
You know what would be really cool, if you could just import your OpenXcom TERRAIN definition via YAML into MapView.

Then just paths to MAP, RMP and MCD files would need addition, adjustment (for custom stuff).

Offline kevL

  • Colonel
  • ****
  • Posts: 471
  • pitchforks and torches
    • View Profile
Re: MAPVIEW upgrade
« Reply #247 on: September 22, 2018, 05:54:47 pm »
EDIT: aha, it's XConsole.cs in .csproj, but xConsole.cs on disk.

Ben was in mad genius mode when he originally coded Mapview ... (and MV is a work of genius) ... the "mad" part, however, means that the original code is a spaghetti monster.

i'll be frank : I spent over 1000 hr sorting things into something more maintainable. There's lots left to do, in that respect.

thanks for pointing that one out - I could see it being a problem especially under linux/Mac

But i don't have linux or Mac or TFTD. /shrug

You know what would be really cool, if you could just import your OpenXcom TERRAIN definition via YAML into MapView.

Then just paths to MAP, RMP and MCD files would need addition, adjustment (for custom stuff).

y, it would be ... unfortunately my headspace is elsewhere atm. It'd take me many many hours to get back in there and do it correctly ..,


Ps. both you guys strike me as experienced Xcomers, so just poke away at it if you want and i'll wait for something concrete (from my perspective) to pop up

pps. XConsole is a thing that's been disabled in Mv2. It's one of those things that I left the code in though (many other things were outright deleted) - it's basically a debugging tool, but if you're debugging you probably have an IDE so it's unnecessary.

ppps. I think i fixed it : https://github.com/kevL/OpenXCOM.Tools/tree/master/XCom
« Last Edit: September 22, 2018, 06:19:00 pm by kevL »

Offline Stoddard

  • Colonel
  • ****
  • Posts: 485
  • in a fey mood
    • View Profile
    • Linux builds & stuff
Re: MAPVIEW upgrade
« Reply #248 on: September 22, 2018, 06:19:54 pm »
I'll just document this here so that it isn't completely forgotten:

  • This xconsole thing is the only thing that fails the build under mono/linux. I just edited the .csproj to point to xConsole.cs
  • The second thing is cursor.pck not being found because of backslash - just change it to forward slash in XCom/SharedSpaceServices/SharedSpace.cs:17
  • the build also spews errors for not being able to copy exes somewhere, this can be safely ignored
  • the transparency bug is in Mono and is apparently being worked upon - see https://github.com/mono/mono/issues/8514 https://github.com/mono/libgdiplus/issues/491
« Last Edit: September 22, 2018, 06:26:33 pm by Stoddard »

Offline kevL

  • Colonel
  • ****
  • Posts: 471
  • pitchforks and torches
    • View Profile
Re: MAPVIEW upgrade
« Reply #249 on: September 22, 2018, 06:30:00 pm »
I'll just document this here so that it isn't completely forgotten:

  • This xconsole thing is the only thing that fails the build under mono/linux.
  • The second thing is cursor.pck not being found because of backslash - just change it to forward slash in XCom/SharedSpaceServices/SharedSpace.cs:17
  • the build also spews errors for not being able to copy exes somewhere, this can be safely ignored
  • the transparency bug is in Mono and is apparently being worked upon - see https://github.com/mono/mono/issues/8514

1. should be fixed in latest commit [but I changed the filename on disk instead of in the project file... to keep things consistent with the other XC*.* files]
2. not sure how that plays out on Win systems ... probly ok but investigation req'd
3. look at the post-build events for the MapView assembly; delete them. I'm simply copying the .exe's and .dll's to a working directory (release and debug builds - but am going to delete the debug post-build copying since I'm doing things differently here/now). Anyway, look through the build events, blablah
4. okay
« Last Edit: September 22, 2018, 06:33:21 pm by kevL »

Offline Stoddard

  • Colonel
  • ****
  • Posts: 485
  • in a fey mood
    • View Profile
    • Linux builds & stuff
Re: MAPVIEW upgrade
« Reply #250 on: September 22, 2018, 06:40:34 pm »
1. should be fixed in latest commit [but I changed the filename on disk instead of in the project file... to keep things consistent with the other XC*.* files]
Thank you.

Quote
2. not sure how that plays out on Win systems ... probly ok but investigation req'd
Should be ok, but I'm no windows person

Quote
3. look at the post-build events for the MapView assembly; delete them. I'm simply copying the .exe's and .dll's to a working directory (release and debug builds - but am going to delete the debug post-build copying since I'm doing things differently here/now). Anyway, look through the build events, blablah

Yeah, please remove that, it kinda messes up the future automated builds.



EDIT:

the build is here  https://lxnt.wtf/oxem/#/MapView
the patches applied:
https://github.com/StoddardOXC/OpenXCOM.Tools/commit/141ae7fff8f73e797c4da1565ba966eac107aff6
https://github.com/StoddardOXC/OpenXCOM.Tools/commit/287b9bbae6ab401ba416e31605c202efdb5f3725

now we only have to wait for the mono people to sort out the transparency, and MapView would finally be usable on linux.
« Last Edit: September 22, 2018, 07:16:43 pm by Stoddard »

Offline kevL

  • Colonel
  • ****
  • Posts: 471
  • pitchforks and torches
    • View Profile
Re: MAPVIEW upgrade
« Reply #251 on: September 22, 2018, 08:25:09 pm »

Offline Stoddard

  • Colonel
  • ****
  • Posts: 485
  • in a fey mood
    • View Profile
    • Linux builds & stuff

Offline kevL

  • Colonel
  • ****
  • Posts: 471
  • pitchforks and torches
    • View Profile
Re: MAPVIEW upgrade
« Reply #253 on: September 22, 2018, 09:28:22 pm »
sweet

just have to wait for the mono guys to get up to speed, looks like they're hot on the trail too



@Stoddard
beware : https://github.com/kevL/OpenXCOM.Tools/blob/master/MapView/Forms/MainWindow/XCMainWindow.cs#L1036

etc.
« Last Edit: September 23, 2018, 08:05:48 am by kevL »

Offline Stoddard

  • Colonel
  • ****
  • Posts: 485
  • in a fey mood
    • View Profile
    • Linux builds & stuff
Re: MAPVIEW upgrade
« Reply #254 on: September 23, 2018, 11:57:37 am »