[DONE][Suggestion] Craft weapon tooltip + M-click for ufopedia

[Extremator]

Hello!
I would like to ask questions and therefore suggest some small ideas for implementation (if possible).

1. I want to be able to specify my own text for weapons that do not have their own parameters related to displaying the amount of ammo (AMMO and MAX). Is it possible to implement?
P1.png , P2.png

2. Is it possible to make it so that the ammunition is displayed not in two different lines, but in one? For example: "AMMO>0/300"

3. Added the ability to DISABLE a certain weapon position, after which the * symbol is added to its name to indicate this effect. Is it possible to make it so that this is indicated by changing the COLOR of the name? (for example, to gray or red). I believe that the player's eye reacts faster and easier to color indication.

[Meridian]

1. and 2. are possible to implement
(that doesn't mean I will automatically do it; first I would have to see some interest from modders: https://openxcom.org/forum/index.php?topic=11631.0)

3. the only available text colors in basescape are: white, blue, gold, pink and purple
(in TFTD only 3 colors: white, blue, green)

[Extremator]

It probably doesn't matter which color you choose.
The important thing is that the color will change when switching!

I believe that if we simply give modders the ability to arbitrarily describe bonuses or qualities of modules installed in gun positions, they will definitely use them. 

[Meridian]

I believe that if we simply give modders the ability to arbitrarily describe bonuses or qualities of modules installed in gun positions, they will definitely use them. 

They describe them already in Ufopedia.
(where they also have a lot more available space than on this screen... you can barely put 6-7 words here)

[Extremator]

Yes, I understand that.

I would use the available space as a numerical clue, eg:

”ARMOR>{ALT}+10{ALT}"
or
"FUEL>{ALT}+50{ALT}"
or
"SPEED>{ALT}+300{ALT}"

At the moment, it is not possible to open information about a weapon from the pedia by middle-clicking on its name? Without re-selecting the currently installed weapon from the list.

[Meridian]

Done.

https://github.com/MeridianOXC/OpenXcom/commit/19626a07b03d3390587b23c19a8523d057f426ee
https://github.com/MeridianOXC/OpenXcom/commit/c97db5fc2eb1711adcbec4862dbbe2686c73896c

Sample ruleset:

Code: [Select]

craftWeapons:
  - type: STR_HULL_PLATING_UC
    tooltip: STR_HULL_PLATING_UC_TOOLTIP
  - type: STR_CRAFT_BATTERY_PACK_UC
    tooltip: STR_CRAFT_BATTERY_PACK_UC_TOOLTIP

Sample translation with placeholders:

Code: [Select]

en-US:
  STR_HULL_PLATING_UC_TOOLTIP: "HP>{ALT}+{4}{ALT}{NEWLINE}ARMOR>{ALT}+{5}{ALT}"
  STR_CRAFT_BATTERY_PACK_UC_TOOLTIP: "FUEL>{ALT}+{2}{ALT}{NEWLINE}SPEED>{ALT}{3}{ALT}"

Available placeholders:

Code: [Select]

weaponLine << (tr(w1->getRules()->getTooltip())
.arg(w1->getAmmo())                                    // {0}
.arg(w1->getRules()->getAmmoMax())                     // {1}
.arg(w1->getRules()->getBonusStats().fuelMax)          // {2}
.arg(w1->getRules()->getBonusStats().speedMax)         // {3}
.arg(w1->getRules()->getBonusStats().damageMax)        // {4}
.arg(w1->getRules()->getBonusStats().armor)            // {5}
.arg(w1->getRules()->getBonusStats().shieldCapacity)); // {6}


[Meridian]

At the moment, it is not possible to open information about a weapon from the pedia by middle-clicking on its name? Without re-selecting the currently installed weapon from the list.

Done.

https://github.com/MeridianOXC/OpenXcom/commit/124704c99cb9794d0b3cb910e606bd5042f3355c

M-click on the weapon icon.