Battlescape development

[NeFuRii]

Its some kind of a mask for the half tile.
If you would draw ufo floor and then the wall, you would see that floor outside the ship.
I think it should be: first draw the grass/dirt, then draw the wall, then draw the ufo floor but only on black part of the tile

[Daiky]

@NeFuRii, thanks for the response.
I kinda get it. But why did they not add the half floor directly to the diagonal wall object? Because I notice that the mask is added to the diagonal wall object. And if I have a look at all the UFO models, it is always the same floor that goes with the diagonal wall. And I don't immediatly see any depth sorting issues that could occur...

I think I would fix it by changing the sprites in memory after U_EXT02.PCK is loaded, adding the half floors to the sprites 5 6 and 7.

[NeFuRii]

It has to do with damages probably. For example if you shot the floor of that 'half tile' you need to change the tile for its damaged version.If this was one connected floor-wall tile you would need to make all possible combinations of damaged/undamaged floor and wall. Even worse, if you damage a floor on the higher level you would need to factor in combinations of not having any floor if it gets destroyed.

[Daiky]

speaking of damages... if you shoot the inside half of the tile it should replace it with the damaged version of that tile, if you shoot the outside half of the tile it should replace it with the damaged version of that one. The damaged version is held in the MCD data, However, the game can only hold 1 MCD index for a floor tile... how can it hold the MCD indexes of both "floors"?

[NeFuRii]

I'm not familiar with ufo's file types.  No idea how its stored.

[Daiky]

as promised a patch this week for milestone 5:
- functional: XCom Craft placement (done)
- functional: Ufo placement (done)
- functional: Battlescape starts when landing skyranger at a crash site (done)
- technical: Move MCD struct to TerrainObject class (somewhat done)
- technical: review variable names to see they all correspond the conventions (done, I hope)
 (conventions: a map origin is on the left side, X-axis runs to bottom right, Y-axis runs to upper right, Z-axis represents the layers, a distance on the X-axis is called width, a distance on the Y-axis is called length, a distance on the Z-axis is called height ) (done)
- technical: big code review so this patch can be integrated for the first time in the openxcom SVN repository (somewhat done)

there is still a little issue with diagonal ufo walls, the floor is not blitted correctly (it's not using the black mask, got to find out how to use masks with the SDL blit).

So, SupSuper, as for me this patch can go in SVN. I don't know what you think.
Anyway, I keep implementing battlescape stuff:
milestone 6:
- load waypoints/spawnpoints
- add units /soldiers

[bramcor]

Great job with the patch Daiky! It is great to have a use for that Skyranger

From what I can tell, your terrain detection is spot on. I tried out farm, forest, jungle, desert, mountains and polar. All of them corresponded to the correct globe surfaces.

Only thing that caught my eye was a few warnings during compilation. I pasted them here: https://pastebin.com/rNjy5jbK

[Daiky]

THE MISTERY OF THE DIAGONAL WALL / FLOOR TILE SOLVED
I opened up the good old map editor, and behold.... the floortile next to the diagonal wall tile has a small part attached which is a half floor tile.

The reason why it showed black is, that I was drawing all floor tiles first, and then the rest. Which is maybe not a good idea I see now.

[NeFuRii]

Interesting .
But how does it work? There are no such tiles in the U_EXT02.PCK, so it can't be a single tile. It still seems to be some kind of graphics manipulation on the fly done by the engine. Or is it stored in some other file? I haven't seen it anywhere.

[Daiky]

those special tiles are in U_BITS.PCK

[SupSuper]

Daiky has earned SVN access, so there's no more need for constantly creating/adding patches. Hopefully he won't go mad with power.

[Daiky]

If you just heard a loud bang, don't be afraid, it was just me committing the battlescape code into the openxcom repository

[SupSuper]

THE HORROR!

[liamdawe]

Can't wait to see the .2 release with all of this included

[Daiky]

I committed a cleanup, and renamed some of the classes, so they are clearer what they do.