[DONE][Suggestion] isUsed property for base facility

[Finnik]

Regardless of how the problem with facility uniqueness constraint can be solved (https://openxcom.org/forum/index.php/topic,8017.0.html), we in The X-Com Files need another property for our facilities.
See, we want straightway to upgrade one building (say, HQ, or Bio Lab) to its advanced version without permitting the player to be able to build any other copies of that building - in other words, the player should have either normal HQ, or advanced one at a time, without any other options. We also have more such buildings. Currently, if player desire, even with a uniqueness constraint, that I mentioned above, the player can build normal HQ, and then advanced next to it, thus, having both of them at a time.

To solve this problem I would like to suggest this small addition to the code. Proposed syntax:

Code: [Select]

  - type: STR_CYBER_HQ
    maxAllowedPerBase: 1
    isUpgrade: true #default false
    buildOverFacilities:
      - STR_HQ

Here is a solution I can imagine at the moment:

https://github.com/MeridianOXC/OpenXcom/compare/oxce-plus...FinnikXCF:virtualCraft

Additionally, I think, we can check onLoad if `isUpgrade: true` was set, but there are no `buildOverFacilities:` defined. If so, stop loading with error for modder:

Code: [Select]

[21-03-2020_19-25-52] [INFO] Loading rulesets...
[21-03-2020_19-25-58] [ERROR] Error processing 'STR_LARGE_RADAR_SYSTEM' in facilities: Facility has property isUpgrade set TRUE, but buildOverFacilities property was not defined!

I would really appreciate feedback and comments!

[Solarius Scorch]

Judging from the clip, this is exactly what I want in my life.

[Meridian]

what is so bad about being able to build upgraded facility straight away?

why force player to build one and then the other?

(assuming you already have the uniqueness mentioned in another thread)

Judging from the clip, this is exactly what I want in my life.

so after this you never need anything else?

[Finnik]

because without it, as I said, you can build upgrade building not on top of the upgradable, but on another tile. thus, I can build advanced HQ next to normal and have 2 at a same time at the same base. And this is what we want to prevent.
At the same time, if uniqueness constraint will not allow us to build an upgrade next to the original, I can't see how can we allow to make upgrades...

[Solarius Scorch]

[ninja'd by Finnik]

what is so bad about being able to build upgraded facility straight away?

why force player to build one and then the other?

(assuming you already have the uniqueness mentioned in another thread)

so after this you never need anything else?

You're right, preventing building the facility from scratch is not the main goal, more of a way to deal with logic problems.

THe point is that in XCF:
- you can have only one building of a certain type per base
- there are several stages of this building
- with clever planning, you can build several buildings of the same type (but exactly the same building) - this is the problem

Yes, I tried fixing it with existing options, but nothing worked well enough. This solution with upgrades simply cuts the problem away and would be very helpful. (Assuming I understand it correctly.)

[Meridian]

because without it, as I said, you can build upgrade building not on top of the upgradable, but on another tile. thus, I can build advanced HQ next to normal and have 2 at a same time at the same base. And this is what we want to prevent.

This is what the uniqueness feature is supposed to solve, no?
That you cannot build adv HQ next to normal HQ...

[Finnik]

yes, but then I still can build advanced one next to normal and still break things

[Yankes]

From my perspective both your threads are effective same functionality (I think we should merge them) and in reality work around of some limitations with BaseFuncitnality logic. As I mentioned in other there we should fix core of problem not work around it. Simply you can build building over one that forbid your building that you want to build.

[Meridian]

yes, but then I still can build advanced one next to normal and still break things

Code: [Select]

facilities:
  - type: STR_LARGE_RADAR_SYSTEM
    cantBeBuiltWith:
      - STR_SMALL_RADAR_SYSTEM
  - type: STR_SMALL_RADAR_SYSTEM
    cantBeBuiltWith:
      - STR_LARGE_RADAR_SYSTEM

if you do this, doesn't it mean you can only ever have one of the two?

[Finnik]

Of course no, it just prevents me from building the second building, no matter who comes first. For unique upgradable buildings, we need both, as far I can see.

[Meridian]

Of course no, it just prevents me from building the second building, no matter who comes first. For unique upgradable buildings, we need both, as far I can see.

I read the PR now, and I think I understand what you mean.

It's because the PR checks the condition when creating a list (i.e. earlier)... not when placing a facility (i.e. later).
That can be improved.

I'll talk to Yankes and we'll try to come up with proposal(s).

[Meridian]

I'll talk to Yankes and we'll try to come up with proposal(s).

See details here: https://openxcom.org/forum/index.php/topic,8017.msg127571.html#msg127571