Author Topic: [DONE] [Feedback] Hide items in the Purchase Screen  (Read 6367 times)

Offline jgatkinsn

  • Colonel
  • ****
  • Posts: 321
  • Squaddie cautiously peering through the breach
    • View Profile
[DONE] [Feedback] Hide items in the Purchase Screen
« on: March 23, 2018, 06:55:50 am »
Okay, I've finished implementing the ability to hide items in the purchase screen.  It's an option in the Advanced Mods list called "Hide Purchase Items".  As you hide items, an internal list (really a map) is managed that is saved and restored into the save game file.  It's backwards compatible with save game files that don't have the hidden purchase item list in it. 

Users just "right-click" on the item in the purchase screen to "hide" it, and if they want to "unhide" it, they can go the the "Hidden Items" category and right-click on the item again. 

And yes... if you select another category other than "Hidden items", the hidden item will not show up there even it it belongs in that category.

Here's a link of the hiding in action:



Everything is checked into my oxce3.5-plus-proto branch on GitHub if anyone wants to test it.

https://github.com/jgatkinsn/OpenXcom/tree/oxce3.5-plus-proto
'
Let me know if this can be improved.  Would this be better if it was called "Ignore Items" instead of Hidden?

Again, the premise behind this feature is to cut down on the clutter of all the items in the purchase screen you no longer care about because of obsolescence over the course of the game.  This is particularly helpful with the mods with tons of items like XcomFiles and FMP.
« Last Edit: July 17, 2018, 02:07:01 pm by Meridian »

Offline mumble

  • Colonel
  • ****
  • Posts: 338
    • View Profile
Re: Hide items in the Purchase Screen
« Reply #1 on: March 25, 2018, 06:09:35 am »
Really handy! hope this gets added into XCF, as the huge list of tons of guns after getting blackops gear is a hassle to get through.

I'd call them "obsolete" items personally, but thats just me. I think its fitting with the game, as obviously cannons are 100% obsolete once you get craft lasers for instance.

Any chance you could add this for selling, and crafting, just for completions sake?

Offline jgatkinsn

  • Colonel
  • ****
  • Posts: 321
  • Squaddie cautiously peering through the breach
    • View Profile
Re: Hide items in the Purchase Screen
« Reply #2 on: March 25, 2018, 07:38:07 am »
Any chance you could add this for selling, and crafting, just for completions sake?

My only concern about hiding it from the sell screen, is that you'll completely forget about the items and not realize why your inventory is overflowing from all the hidden/ignored items gathered from missions :)   However, I guess I could do it.  I was more concerned about purchasing, because I spend more time in that screen than I do the sell screen. I don't know if it's a OXCE+ addition, but in XcomFiles, I get sell screens after every mission debriefing so less need to hide items there and I usually want to sell most of those items after mission.

I really hadn't thought about the manufacturing screen, but I guess it easily be done there as well. 

Offline BlackStaff

  • Colonel
  • ****
  • Posts: 320
    • View Profile
Re: Hide items in the Purchase Screen
« Reply #3 on: March 25, 2018, 10:48:06 am »
Bravo and very interesting!
For the manufacturing screen it's interesting too!
But not for the Sales screen.
My two cents !  8)

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 7797
    • View Profile
Re: Hide items in the Purchase Screen
« Reply #4 on: March 25, 2018, 11:27:15 am »
Manufacturing has this feature already...

... how serious should I take feedback here, if features you're asking for as "must haves" are actually there for a long time and you ignore them? Or maybe you even didn't find them (which would be even worse)?

Offline BlackStaff

  • Colonel
  • ****
  • Posts: 320
    • View Profile
Re: Hide items in the Purchase Screen
« Reply #5 on: March 25, 2018, 11:51:32 am »
... how serious should I take feedback here, if features you're asking for as "must haves" are actually there for a long time and you ignore them? Or maybe you even didn't find them (which would be even worse)?
I prefer to consider that my ignorance of the English language does not make me believe that your remarks are at the limit of insult.
Just say it already exists.
Sorry to be ignorant.

This function would be interesting for the vehicle/vessel/aircraft loading screen.
But the right click is already used on this screen.
But the possibility of viewing only the objects already on board is already a very good thing.

Translated by https://www.deepl.com/translator
« Last Edit: March 25, 2018, 12:05:08 pm by BlackStaff »

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 7797
    • View Profile
Re: Hide items in the Purchase Screen
« Reply #6 on: March 25, 2018, 12:11:04 pm »
Not meant as an insult, just as frustrated/disappointed comment.

Offline BlackStaff

  • Colonel
  • ****
  • Posts: 320
    • View Profile
Re: Hide items in the Purchase Screen
« Reply #7 on: March 25, 2018, 03:12:20 pm »
Not meant as an insult, just as frustrated/disappointed comment.
I know that feeling!
I am moderator and modder on another site and for another game.
You have to breathe deeply and tell yourself that as modellers you don't have the same vision of things and therefore some things that seem simple to us are not for an end user.

Translated by https://www.deepl.com/translator

Offline jgatkinsn

  • Colonel
  • ****
  • Posts: 321
  • Squaddie cautiously peering through the breach
    • View Profile
Re: Hide items in the Purchase Screen
« Reply #8 on: March 25, 2018, 04:22:12 pm »
Sorry for your frustration, Meridian.  Personally, I ddn't know about the manufacturing feature, because I never needed it in my playthroughs.  The hidden items in the purchase screen became a problem after playing XComFiles with it's ever growing list of junk to buy, and the alien invasion hasn't even begun.  It gets annoying scrolling the screen when trying to assess my inventory to see where  I'm running low on items I need.  I could use the different categories, but even those lists are massive too!
« Last Edit: March 25, 2018, 04:27:55 pm by jgatkinsn »

Offline wolfreal

  • Colonel
  • ****
  • Posts: 294
    • View Profile
    • Email
Re: Hide items in the Purchase Screen
« Reply #9 on: March 25, 2018, 09:04:39 pm »
Meridian, if it makes you happy, I use actively the features of hidden/news/categories/search on the manufacture screen, and I love them  ;D

Offline jgatkinsn

  • Colonel
  • ****
  • Posts: 321
  • Squaddie cautiously peering through the breach
    • View Profile
Re: Hide items in the Purchase Screen
« Reply #10 on: March 25, 2018, 09:21:34 pm »
Of course, I just now realized, I'm going to need the manufacturing hide feature soon as my manufacturing capabilities ramp up in XcomFiles... there's a lot of stuff there too.

Offline ivandogovich

  • Commander
  • *****
  • Posts: 2381
  • X-Com Afficionado
    • View Profile
    • Ivan Dogovich Youtube
Re: Hide items in the Purchase Screen
« Reply #11 on: March 26, 2018, 03:22:45 am »
Sorry for the Side Track, but yes, I also hide manufacturing items all the time.  I would also love to see the ability to hide stuff in the purchase screen too.  I'm never gonna buy ammo for all the early game pistols, so why not hide it if I can, etc?

Offline blackwolf

  • Colonel
  • ****
  • Posts: 108
  • im back...i guess
    • View Profile
    • Email
Re: Hide items in the Purchase Screen
« Reply #12 on: March 29, 2018, 01:52:11 am »
i join with the feeling, i love the hiding features in the manufacture screen.
Actually they are so good it should be standard in every "item screen" , buying screen and also equipment screen inside the transport inventory list :D!
(for example im playing Xeno operations from XOps and i would like to "hide" special weapons from the time i advance in my codex or when im equipping my "elite squad"  ;D )

Offline jgatkinsn

  • Colonel
  • ****
  • Posts: 321
  • Squaddie cautiously peering through the breach
    • View Profile
Re: Hide items in the Purchase Screen
« Reply #13 on: March 29, 2018, 05:21:36 am »
I fixed a bug right clicking on the list arrows and added the ability to now hide craft as well.  Enjoy!  :)

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 7797
    • View Profile
Re: Hide items in the Purchase Screen
« Reply #14 on: May 08, 2018, 12:48:03 pm »
Merged.