Author Topic: Statistics soldiers  (Read 3836 times)

Offline ivandogovich

  • Commander
  • *****
  • Posts: 2403
  • X-Com Afficionado
    • View Profile
    • Ivan Dogovich Youtube
Re: Statistics soldiers
« Reply #30 on: June 30, 2018, 11:43:14 pm »
did you try excluding your openxcom directory from anti-virus scan-on-access?  I know that has caused poor performance for me.

Offline Stoddard

  • Colonel
  • ****
  • Posts: 457
  • in a fey mood
    • View Profile
    • Linux builds & stuff
Re: Statistics soldiers
« Reply #31 on: July 01, 2018, 12:10:18 am »
Tried both ."exe " - no differences in load speed were found. The speed is the same as the standard OXCE+ latest version.

CPU Intel Core E7500 so what will... I have on this CPU World of Tanks and a Perfect World - just fly like swallows. No brakes, no lags, no traffic lights. And for openxcom it may lack performance? Not believe!


Yeah, well, the CPU is almost identical to mine wrt OpenXcom. Something's killing I/O and it isn't OpenXcom code, because, well, there isn't anything in it that could.

A clue can be extracted from watching what's happening during a savegame load with something like process explorer

Like, what processes are eating the CPU during the load. I think even the stock task manager can do it, or at least show if CPU usage spikes, and that would be a useful data point, but I'm no windows expert.

I don't actually believe that even a batshit insane antivirus pile of crap can slow down reading a simple text file even if it's 5Mb. I can believe that an antivirus can slow down the startup, since that's when a ton of files get read/parsed. But not on  a savegame load, where it's just one file, whatever its size.

And since you say WoT behaves nice enough, then it's probably not a hardware problem.

Still, no ideas on what could be the problem in OXCE+ code. Please look into what's going on in the system when you're loading a save. You are literally the only set of eyes we have on the problem.

Offline Ethereal

  • Colonel
  • ****
  • Posts: 299
    • View Profile
Re: Statistics soldiers
« Reply #32 on: July 01, 2018, 12:37:40 am »
We do not do what is really needed. Statistics of soldiers need to put in order, so that detailed information about each destroyed unit is not kept for the entire game time. To simplify all of it. As in FALLOUT 2-so much of these units destroyed\stunned and how many destroyed\stunned with such a weapon, so many missions performed a certain type, so many times successfully applied panic\telepathic control. Why did need this hemorrhoids with " kill List-turn: - side: - body part: - id:" and other nonsense for each unit, which only clogs the save file with unnecessary information?! Explain to me why the game all this to remember every time you load the game not in combat? Why does the game remember everything that happened in 135 previous battles in every battle?

Can do a couple of tables with numbers, where successfully used weapons, together with the counter of the kills, summed up and displayed in this form in the diaries.

Roughly so:

Code: [Select]
        diary:
          killList:
            - STR_FLOATER_SOLDIER: 4
            - STR_GILLMAN_NAVIGATOR: 2
            - STR_SECTOID_COMMANDER: 1
          killWeapon:
            - STR_GRENADE: 3
            - STR_PROXIMITY_GRENADE: 1
            - STR_SHOTGUN: 3

This will reduce the save file by more than half.

Offline Stoddard

  • Colonel
  • ****
  • Posts: 457
  • in a fey mood
    • View Profile
    • Linux builds & stuff
Re: Statistics soldiers
« Reply #33 on: July 01, 2018, 12:42:14 am »
We do not do what is really needed.

I see, you somehow decided on what is needed. That is fine. Now please prove that the save game file size is the root cause of your problem. So far there is nothing that proves that.

EDIT: the file size might be something that triggers the problem on your side. But given that we can't reproduce it, the file size is certainly not the root cause.

« Last Edit: July 01, 2018, 12:47:52 am by Stoddard »

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 4909
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: Statistics soldiers
« Reply #34 on: July 01, 2018, 12:59:17 am »
Why are we even discussing this?

He said it runs faster on his PC already... problem solved. Or am I missing something?

Offline Ethereal

  • Colonel
  • ****
  • Posts: 299
    • View Profile
Re: Statistics soldiers
« Reply #35 on: July 01, 2018, 01:20:23 am »
Why are we even discussing this?

He said it runs faster on his PC already... problem solved. Or am I missing something?

Yes, right. But I'm concerned about the amount of unnecessary information in the save file. And, the rapid growth of the file size because of statistics.

Offline Stoddard

  • Colonel
  • ****
  • Posts: 457
  • in a fey mood
    • View Profile
    • Linux builds & stuff
Re: Statistics soldiers
« Reply #36 on: July 01, 2018, 02:02:03 am »
Yeah, whatever. If perfomance is acceptable now, we're done here.

If and when it becomes unacceptable, we'll deal with that.

Case closed.

EDIT: yeah, I forgot

 ... bangs the gavel.