Window popup animation

[luciderous]

Something has been bugging me for quite a long time recently and I really didn't get what was exactly the reason. Finally, I've found the culprit - it was the window popup animation lag. I've double-checked it with the original X-Com and it was totally missing there - the windows popped up instantly!
Looking deeper into "Window.cpp" I noticed, that such a behavior seems to have been intended, while it definitely should have not. Thus I decided to make a small hack-fix. Of course, it may render some other code in the same file unnecessary, but is to SupSuper to decide.

[michal]

IMHO you should post such patches in "contributions" forum.

[SupSuper]

Actually the window popup animation was present in the original X-Com. Every window that plays a sound when it pops up has this animation. The reason you see it "pop up instantly" in the original is because the animation is CPU-dependant, so on modern computers the animation will always play at full speed (much like stuff like the Geoscape and Battlescape scrolling are hyper-fast on modern computers). You will only see it on the DOS version running it on a properly slowed-down-emulator, or on the Windows version (example here) which was better calibrated (specially with UFO Extender), or even the PSX version.

If this is annoying to you though, I will look into adding an option in the future to disable it.

[Eeyoocah5Moh]

Image attached. Ufopaedia window popup both horizontally and vertically. Slow down game in dosbox and you will see it.

[Eeyoocah5Moh]

If this is annoying to you though, I will look into adding an option in the future to disable it.

Adding option for each thing is not good at all. Maybe just make the popup a little faster? Current speed is the same as Windows version? If not, then maybe just tweak it a little?

[SupSuper]

If this is annoying to you though, I will look into adding an option in the future to disable it.

Adding option for each thing is not good at all. Maybe just make the popup a little faster? Current speed is the same as Windows version? If not, then maybe just tweak it a little?

The current window popup takes around 0.13s, any faster and it'd be gone. I imagine it's faster than the Windows version, there's no real accurate way to find out so I just went with what feels right. Plus technically you don't need to wait for the popup because the controls pop up instantly (unlike in X-Com, because I'm lazy and sloppy sometimes ).

As for options, well as long as each thing is as simple as a line of code, I'm fine with that. Even if each thing is just a nag, I'm fine with that too. I won't take care of it post-haste, but I like to show I'm not ignoring it either. After all, that's kind of the point of this thing. That's why mods like UFO Extender are so popular, because they take care of all the options and nags that the fanbase has always wanted.

[luciderous]

Plus technically you don't need to wait for the popup because the controls pop up instantly (unlike in X-Com, because I'm lazy and sloppy sometimes ).

That's exactly what was nagging me!
I can perfectly live with the popup animation, but right now the text appears before the box does and it feels rather awkward. Perhaps syncing them will do the trick 

[SupSuper]

Curses, foiled again! Now it's no longer a single-line fix.

[pmprog]

Sure there is.

Code: [Select]

if( currentSize == destinationsize )
   AddControls()

 

[SupSuper]

Sure there is.

Code: [Select]

if( currentSize == destinationsize )
   AddControls()

 

Damn, if only programming was that easy, I could've been done months ago!

Code: [Select]

int main(int argc, const char* argv[])
{
Xcom();
}


[pmprog]

Joking aside, it is pretty much that easy.

What I would do is

• Add a new parameter to the Window constructor called PopupCallBack, which points to a void Callback(Window source) function
• In Window::popup(), if PopupCallBack was provided, call it
• Create a callback function in the screens that do popup windows, use the source variable to work out which popup is being displayed (or you could just pass different methods to the constructors), and add the necessary buttons

Edit: Would you like me to create a "demo" patch?

[SupSuper]

I appreciate the idea but it's been fixed for a while (well, since Tuesday anyways) if you missed it. I also found some other bugs that might've been nagging users worldwide in the process, so in the end it was win-win!

[pmprog]

Yip, I missed it, not done much programming outside of work lately 
I'll have to update my SVN and take a look