DogfightState development

[d2uriel]

Believe it or not, but I've been playing the original for the past few days just to have a saved game to work with ;-). I've made some progress with multi-interceptions but there's still some things to fix. As soon as it will be playable and bug free I'll send a PR.

[sklll]

Can't wait for minimization to be implemented 

I can play DOS version, to provide save with 5 aircrafts chasing an ufo (or maybe another situation). If this still can help - just let me know 

[d2uriel]

Okay. The beta version of multi-interceptions is implemented. I've sent a PR but it will be merged after release of v0.4.5. As soon as it is, please test this new feature. It's probably buggy because a lot of things had to be added/re-written/changed. I've done a couple of tests and it seems to work but you know how it goes. If you are really eager to test it now, you can pull the source from here and compile it yourself. I've merged the current build into mine so everything should be the same (except for dogfights of course).

Awaiting feedback.

[pmprog]

I've pulled your changes into my repo, will hopefully have a play with it tonight 

Edit: SupSuper - I sent you a PM - This now shows in my PR as well as d2uriel's. I'll try and fix it when I get home

[d2uriel]

One more thing that came into my mind a while ago which I always forget to ask.

In DogfightState class there's a lot of surfaces being instantiated with the new operator but they are not deleted within the destructor (only the timers are deleted there). Since I'm not really experienced with SDL - is this being taken care of by SDL itself or was it forgotten straight from the beginning and needs to be fixed?

[SupSuper]

One more thing that came into my mind a while ago which I always forget to ask.

In DogfightState class there's a lot of surfaces being instantiated with the new operator but they are not deleted within the destructor (only the timers are deleted there). Since I'm not really experienced with SDL - is this being taken care of by SDL itself or was it forgotten straight from the beginning and needs to be fixed?

Any surfaces that are rendered on-screen by the State (through the add() function) are automatically cleaned up by the base State destructor. The idea is that once you connect a Surface to a State, the State takes over so you don't have to worry about it (I'm hoping to expand this to timers and such too eventually). This is all part of the OpenXcom engine.

However if you crate any surfaces with new that are not added to the State (eg. temp surfaces), you'll have to clean those up yourself.

[d2uriel]

Alright, good to know that. I didn't really want to dig into the code too much cause this could as well be hidden somewhere in the SDL libs ;-). I really thought it's gonna be faster to ask this question. Hope you don't mind ;-).

[SupSuper]

Alright, good to know that. I didn't really want to dig into the code too much cause this could as well be hidden somewhere in the SDL libs ;-). I really thought it's gonna be faster to ask this question. Hope you don't mind ;-).

That's fine, I imagine OpenXcom engine is quite the mystery for most people and they just roll with. I might eventually give an overview of the inner engine functionality for the more curious programmers.

[pmprog]

Some notes:

• If you launch both interceptors at the same time, only one combat box pops up - but at the top, as if waiting to draw the other screen
• Minimising that box shows "1", but time does not resume (presuming because of the 2nd interception)
• Restoring window "1" and selecting "Disengage" shows the 2nd interceptor box
• Select the 1st interceptor, and set him to re-engage, once it gets back to the fight, time stops, but no interception windows show
• Restoring window "2" removes the box, but you see no interception windows at all
• • You can however, click the geoscape (time still not moving), and however, interceptors don't respond to "Return to base"
  
  Also
  
  • Select an interceptor to attack a UFO
  • Miminise, then restore the window and disengage
  • Set the interceptor to reengage and minimise
  • Craft is now showing as "2" despite being the only craft in combat
  
  

[d2uriel]

Umm, how are you able to launch two interceptors at the same time?

Also

• Select an interceptor to attack a UFO
• Miminise, then restore the window and disengage
• Set the interceptor to reengage and minimise
• Craft is now showing as "2" despite being the only craft in combat

Okay, that should be fixed now. Pushed to my repo.

[pmprog]

When I UFO appears, you click "Intercept" in geoscape, select the first interceptor, click on the UFO, then click Intercept again, pick the 2nd interceptor and click the same UFO

[d2uriel]

Right after targeting the UFO for the first interceptor, the Intercept window disappears. Umm... maybe my sources aren't that up to date at all. Lemme check that.

Edit: Well, it says my sources are already up to date when I'm trying to pull from SupSuper/OpenXcom... hmmmm....

Edit2: Till I figure out what's wrong... test it with sending interceptors within a short interval of time of each other ;-).

Edit3: I found a simple way of dealing with this issue. Committed and pushed to my repo.

Edit4: I read your post carefully again. You're not sending them at the exact same time. Unless you're that fast and the time is not able to advance between you targeting the UFO for the first interceptor and clicking Intercept again ;-).

Edit5: I closed my PR. Please comment within my repo only now.

[pmprog]

Still having problems, thought it'd be easier to record what I'm doing...

https://youtu.be/IRYHufVLsPE
https://youtu.be/asjyNwlzjcE

[d2uriel]

This is weird. Are you using the latest sources of mine? Does it happen every time you do it?

[pmprog]

I did a pull request about 10 minutes before that post, and yes. I take it that it doesn't happen to you then?