Need help compiling under Windows/VS2015

[snicmtl]

Nicely done Meridian!

I was working on this all night trying to wrap my head around it.

Got all the deps compiled but am/was hitting a wall with unresolved externals re: SDL

( ieError   LNK2001   unresolved external symbol _IID_IDirectDrawSurface3   OpenXcom   C:\dev\OpenXcom\src\SDL.lib(SDL_dx5yuv.obj)   1   
 )

I feel I'm so close, I'd love to complete the work without using the premade package.

Did you get anything similar?



PS: Love the cmake import in VS2017

Cheers,

snicmtl
Cheers,

[Meridian]

Did you get anything similar?

No, not really.
Actually, it all went extremely smooth for me... everything worked on the first try.

[snicmtl]

Thanks for the quick reply. It turns out it needed the DirectX libs/SDK.  Compiled great once that was intalled/pointed to .

Also, it now compiles without the YAML_DLL_CPP preprocessor directive that was needed with VS2015, though unsure if that is because I went ahead and compiled yaml itself, or just from the switch to VS2017.

Cheers!

[MadHaTr]

I am warming back up by attempting to compile oxc(https://github.com/SupSuper/OpenXcom) in VSC++ 2017, I received the error which seems most common for builds in 2015 having to do with non updated deps.  Which sent me on a side adventure to compile the deps myself. Starting which YAML, I seem to have made a mistake.

I clone the git(https://github.com/jbeder/yaml-cpp) (I'm pretty new to git) I run cmake for VSC++ 2017, get my SLN file and compile in VS, everything works great but I don't get the yaml files I am after. I also don't get and DLL's.  This is the only LIB file received. (libyaml-cppmd.lib) which was 1.7MB, way larger than what I see you guys using so I know it is not just renamed.

What am I doing wrong when it comes to the yaml dll and lib.

[Meridian]

What am I doing wrong when it comes to the yaml dll and lib.

Code: [Select]

mkdir sandbox
cd sandbox
git clone https://github.com/jbeder/yaml-cpp.git
cd yaml-cpp
mkdir build
cd build
cmake -G"Visual Studio 15" -DBUILD_SHARED_LIBS=TRUE -DCMAKE_DEBUG_POSTFIX="d" ..

... then open visual studio 2017 solution and build both debug and release.

[MadHaTr]

I'll give this a try, seems the only thing that is different is I was not selecting the shared option.

Edit: Correction I did have the shared option selected.  Though I used windows cmake and it had 2 other options selected as well, maybe one of them messed it up or this -DCMAKE_DEBUG_POSTFIX="d" option made the difference.  I don't know. Worked the same as last time though now I have the yaml dll.

Thanks.  I'll move on to compiling the other deps now.

Edit2: Wanted to go back and try again with the windows cmake, and no I did not have the shared libs selected... hence no dlls.

[Arbuckle]

I've downloaded the latest openxcom extended sources and tried to compile them with VS2017 + the 2017 precompiled dependencies that Meridian posted here and got these errors:

Code: [Select]

1>AIModule.obj : error LNK2001: unresolved external symbol "public: static class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > YAML::detail::node_data::empty_scalar" (?empty_scalar@node_data@detail@YAML@@2V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@A)
1>Map.obj : error LNK2001: unresolved external symbol "public: void __thiscall OpenXcom::ItemSprite::drawShadow(class OpenXcom::BattleItem *,int,int,bool)" (?drawShadow@ItemSprite@OpenXcom@@QAEXPAVBattleItem@2@HH_N@Z)
1>Map.obj : error LNK2001: unresolved external symbol "public: void __thiscall OpenXcom::ItemSprite::draw(class OpenXcom::BattleItem *,int,int,int,bool)" (?draw@ItemSprite@OpenXcom@@QAEXPAVBattleItem@2@HHH_N@Z)
1>Map.obj : error LNK2001: unresolved external symbol "public: __thiscall OpenXcom::ItemSprite::~ItemSprite(void)" (??1ItemSprite@OpenXcom@@QAE@XZ)
1>Map.obj : error LNK2001: unresolved external symbol "public: __thiscall OpenXcom::ItemSprite::ItemSprite(class OpenXcom::Surface *,class OpenXcom::Mod *,int)" (??0ItemSprite@OpenXcom@@QAE@PAVSurface@1@PAVMod@1@H@Z)
1>C:\Users\username\Desktop\New Folder\OpenXcom-OpenXcomExtended\src\..\bin\Win32\Release\OpenXcom.exe : fatal error LNK1120: 5 unresolved externals
So I guessed that there might be a problem with my precompiled YAML dll, so I compiled both the 0.51 and the newest commit and tried both.  And I got the same errors.

Any ideas?

[Meridian]

Which commit exactly did you check out from the repo?

Just to confirm you have the correct repo, correct branch and correct commit

[Arbuckle]

Well shit, I dowloaded both masters from OXCE and OXCE+ just to make sure I had the masters and now they both compiled without any problems. Seems I didn't have the correct repo/branch/commit, thanks.

[Meridian]

Well shit, I dowloaded both masters from OXCE and OXCE+ just to make sure I had the masters and now they both compiled without any problems. Seems I didn't have the correct repo/branch/commit, thanks.

But the master branch of OXCE+ is identical with vanilla OpenXcom.

If you want the real thing, you need the "oxce3.5-plus-proto" branch...

[davide]

Hi Meridian,  after some years I wish I compile openxcom again...

I downloaded VS2017 community edition,
I cloned your github repo
I downloaded your dist of deps
I recompile it with some trouble about deps include/lib folders

There is a post with a tutorial about prepare a development image ?

[Meridian]

There is no specific post with such details.
VS2017 is enough, you don't need any other tools.
After cloning my repo, don't forget to switch to branch "oxce3.5-plus-proto" (i.e. not master)
You need to extract the dependencies into root directory, see attached screenshot.
After that just open the solution in VS and click Compile.

[davide]

Thanks, now I compiled without error.

I have some trouble with GIT ...

I tried to merge into your repo an old experiment of redv :
https://openxcom.org/forum/index.php/topic,3513.msg42933.html#msg42933
the source code in conceptually clear:
https://github.com/SupSuper/OpenXcom/compare/master...redv:active_base_defense

... but today some file do not exist anymore ...or them were be renamed
Them are Ruleset/Ruleset.h,.cpp and Ruleset/RuleBaseFacility.h,.cpp

[Meridian]

You don't seriously expect anything made in 2015 to merge without issues, do you?

[davide]

of course you're right