Aliens throwing grenades for less TUs than humans?

[Hobbes]

Well in XCom you can carry up to about 7 weapons too, it's not Call of Duty either

"No, you don't need an additional shotgun to go with your 2 pistols, Assault Rifle, AutoCannon, Stun Rod and Uzi. Now board that Skyranger trooper!"

[BBHood217]

After suffering another instance of an alien moving and afterwards only having enough TUs to throw a grenade without priming it only for the grenade to explode anyway, I have to ask:

Is this fair?

[TaxxiDriver]

Very interesting. So it seems to be that the aliens SHOULD spend the corresponding time units for priming a grenade but it seems not, right? And also quite many players seem to have experienced this problem. I myself also sometimes felt there's something strange about the aliens' throwing a grenade for some reason, but since they don't throw grenades that much frequently, I think I have neglected it so far. It would be great if there's a technical explanation for this problem.

Or is it just my misunderstanding? Honestly, I don't know since I cannot remember exactly a single case when aliens had thrown a grenade and had yet enough time to do some other stuff: they usually just ran away IIRC. But also I doubt if it was just caused by mod conflictions...

[Warboy1982]

finally found it... it's subtle

https://github.com/SupSuper/OpenXcom/blob/master/src/Battlescape/AlienBAIState.cpp#L1791

[TaxxiDriver]

finally found it... it's subtle

https://github.com/SupSuper/OpenXcom/blob/master/src/Battlescape/AlienBAIState.cpp#L1791

So the problem is fixed now, right? Splendid!

[Warboy1982]

not yet, but soon.

[BBHood217]

Wait... this was a bug all along?

[yrizoud]

For the curious, in the linked function, we see the TU cost computed and checked, but it's never actually substracted from the unit's TU.

[Warboy1982]

not quite... it IS subtracted, that's handled elsewhere.

the problem is:

"if (tu <= _unit->getStats()->tu)"

looks correct at first glance, right?
but if i rename the function slightly:

"if (tu <= _unit->getBaseStats()->tu)"

then the problem is MUCH more apparent.

like i said... subtle.