Loading mod rulesets

[tyran_nick]

Was there any change how mods are loaded over the last few nightly builds?
I add them as usually in options.cfg under rulesets, but they no longer load in game. In fact, when I exit openxcom any mod rulesets that I had added are removed from the list in options.cfg. 

Tried all builds with the new version of yaml and have the same problem.

[xracer]

I blame SupSuper

but last i heard everything is the same, maybe YAML 5 is causing more problems and if they are being removed after you exit wow... maybe the game doesn't like your mods .

[SupSuper]

I did tell people on the frontpage to keep an eye out for issues from the YAML upgrade.

I've reproduced the problem and am investigating.

[Kikupj]

I'm having a similar issue by the way.The config removes any mod rul entires.

[SupSuper]

Should be fixed now, let me know if you experience any other problems.

[tyran_nick]

Great! Now they load and stay in options.cfg, but it seems that the extra strings are not read correctly for all the rulesets (potentially more staff). The last mod ruleset in options.cfg seems to load fine, but all previous ones do not, at least for the "extra strings" bit in the ruleset.

wsmithjr has done a bit of investigation in the comments at the main openxcom page.
Thanks for looking into this!

[SupSuper]

It should be fixed in the next Git build. Every loaded ruleset would "reset" the existing extra strings, which is why only the last ruleset remained intact.

[tyran_nick]

Thanks for looking into this. Tried it and now works fine.

I stumbled across another issue, but I am not sure if it is related. I am building a mod that adds countries and cities to geoscape. It used to work, but now I am getting the following when openxcom loads:
yaml-ccp error: at line 0, column 0: bad conversion

The script is very simplistic. I can post it if it helps, but used to work beforehand.
It just has the categories: "countries:", "regions:", "extraStrings:" and the details to add a country and a city. The very first line in the script is "countries:"

[SupSuper]

Please post the script and I'll have a look. Yaml-cpp always says the error is in "line 0, column 0", much to my annoyance.

[tyran_nick]

Here's the script:

Code: [Select]

countries:
  - type: STR_GREECE
    fundingBase: 160
    fundingCap: 10000
    labelLon: 21
    labelLat: -40
    areas:
      - [18.5, 29.5, -42, -34]
regions:
  - type: STR_EUROPE
    cities:
      - name: Athens
        lon: 24.05
        lat: -38
extraStrings:
  - type: English
    strings:
      STR_GREECE: GREECE
  - type: EnglishUk
    strings:
      STR_GREECE: GREECE
P.S. The locations/coordinates in the script are not final, so keep that in mind if anyone wants to use this!

[SupSuper]

Should be fixed in the next Git build.

[tyran_nick]

Works fine! Also I like the inventory screen in equip craft. Great job!
Now, using one of my saves I get the following message when I start an ufo crash mission: "vector:_M_range_check". It never enters battlescape.
Does this make any sense? Not sure if this is related to the ruleset problem.

I have attached the savegame here. If you just let it continue for a couple of game minutes there is an interception to take place between an avenger and a battleship, which reproduces the issue when I try to start the battle.

[SupSuper]

Thanks, it was another bug with multiple rulesets, should be fixed in the next build.

Keep up the good work, as I'm sure there's a lot of possible bugs from the yaml-cpp upgrade that are only gonna get uncovered with some thorough testing.