Minimum Reaction Accuracy setting

[Meridian]

...stumbled upon this code while doing some UFO Extender accuracy stuff, I believe it needs some more love:

Minimum Reaction Accuracy setting
An option to set a minimum accuracy where reaction fire is used. This is to prevent short-range weapons from firing at long distances, at 0% chance to hit.
This wasn't necessary in vanilla, but with vision range 40 and weapons like the Sawed-Off...

...

Actually I thought of making it an option, not a ruleset variable... But it's already something too, as people may make minimods which only affect the reaction.

Keep in mind that minReactionAccuracy affects the AI as well.

...

1/ split the setting for Xcom, Aliens and Civs
2/ make Xcom a user setting, keep Aliens/Civs a mod setting (but move under `constants:`)
3/ decouple from UFO Extender accuracy
4/ anything else?

[jnarical]

Glad it's not me who will implement this feature... it was in my to-do list for RA for a loong time))
For RA this is especially important, cause covers in addition to Extender accuracy drop-offs make units waste their TUs and ammo.

[Solarius Scorch]

1/ split the setting for Xcom, Aliens and Civs
2/ make Xcom a user setting, keep Aliens/Civs a mod setting (but move under `constants:`)

Yes, this is a sound idea.

3/ decouple from UFO Extender accuracy

Not sure what exactly this means, but... all right?

4/ anything else?

Nothing from my side. I'm happy with the feature as is, and the proposed changes sound good.

[Meridian]

Glad it's not me who will implement this feature... it was in my to-do list for RA for a loong time))
For RA this is especially important, cause covers in addition to Extender accuracy drop-offs make units waste their TUs and ammo.

Not sure what you mean, the feature is already implemented since the year 2016.
(I am just thinking of some improvements.)

[jnarical]

Not sure what you mean, the feature is already implemented since the year 2016.
(I am just thinking of some improvements.)

I’ve never seen it in action.