[DONE][Suggestion] Remember "show only eligible" status

[Aldorn]

Let me share a suggestion...

In my mod, I use soldiers transformations as a way to train soldiers And I would like be able to filter on wealthy soldiers that are not currently onboard.

I wonder if it could be considered as useful by some others here?


In case it would be feasible, considered as useful and an interesting topic from an implementation point of view: from what I know, at least in standard behavior, this is not possible to load soldiers in craft if they are wounded (or dead!).

Currently, we can filter on:
- All soldiers
- Wealthy soldiers
- Wounded soldiers
- Dead soldiers

With the new filter option, this could mean to split the wealthy soldiers in 2 categories "onboard and not onboard"
Example:
- All soldiers
- Wealthy onboard soldiers
- Wealthy not onboard soldiers
- Wounded soldiers
- Dead soldiers

Eventually, another idea could be to add an option button "Show not onboard" just next to the first option button "Show only eligible", with the same behaviour: if activated, then filter current selection on soldiers who are not onboard

[Meridian]

Sorry, but I do not accept suggestions from private mods, see: https://openxcom.org/forum/index.php?topic=11631.0

[Aldorn]

Ok, no problem, I was not aware about those rules, I fully understand and accept the decision 

Let me just ask another question, potentially about QoL: "show only eligible" activation is lost as soon as we leave the form, would it make sense to consider this as an option that can be saved (saved when activated and when deactivated)?

[Meridian]

Currently, we can filter on:
- All soldiers
- Wealthy soldiers
- Wounded soldiers
- Dead soldiers

With the new filter option, this could mean to split the wealthy soldiers in 2 categories "onboard and not onboard"
Example:
- All soldiers
- Wealthy onboard soldiers
- Wealthy not onboard soldiers
- Wounded soldiers
- Dead soldiers

This filter is filtering the transformation projects (i.e. items in the table), not soldiers themselves.

Transformation projects don't have any attribute "onboard" or "offboard"...

For better clarification, currently, we can filter on:
- Transformation projects allowing any soldiers, i.e. no filter
- Transformation projects allowing healthy soldiers, i.e. `allowsLiveSoldiers: true`
- Transformation projects allowing wounded soldiers, i.e. `allowsWoundedSoldiers: true`
- Transformation projects allowing dead soldiers, i.e. `allowsDeadSoldiers: true`

[Aldorn]

Thank you for explanation

[Meridian]

Let me just ask another question, potentially about QoL: "show only eligible" activation is lost as soon as we leave the form, would it make sense to consider this as an option that can be saved (saved when activated and when deactivated)?

Done: https://github.com/MeridianOXC/OpenXcom/commit/7f27133ead47b888ae1508bbf9cb768a4c6b425f

(saved in options.cfg)

[Aldorn]

Nice, I installed V8.2 and it works like a charm

Let me experience it in the next days !