[FIXED] Prepriming exploit

[Dioxine]

Not sure if it's OXC or OXCE bug, but prepriming allows you to prime or unprime grenades with     costPrime/costUnprime:       time: 0 (which normally makes it impossible to prime or unprime grenades). It also allows to sidestep other ways of making a grenade impossible to prime or unprime, like fuseType: -3.

[Meridian]

ok, I will check

[Meridian]

a/ prepriming doesn't cost any TU, so cost is not checked there... but I can add such a check if desired

b/ however I was not able to preprime a grenade with `fuseType: -3`... how did you do that?
there is an explicit check for that: https://github.com/MeridianOXC/OpenXcom/blob/oxce-plus/src/Battlescape/Inventory.cpp#L1119


and the most important question, what is the point of a "not primeable" grenade?
I don't think any dev has considered such a combination, so there's probably more issues around with such grenades that would need to be double-checked too...

[psavola]

This may be somewhat related.

In XCF I came upon an issue when the mod author had meant flares to be primeable and unprimeable (ie. you cannot unprime a flare that you have already primed). Yet in battle equipping screen with prepriming enabled you could unprime flares (causing default message to be printed) even though you could not do so in battlescape. I don't think anyone considered this a major issue, and a text message was customized.

It's just worth noting that if the mod thinks unprime costs are always enforced, there may be surprises with prepriming which is kinda special case because the battle has not started yet and various restrictions and costs don't apply (for a good reason).

[Yankes]

Before start of battle you should be able to reset grenades to default state after prime as we are not in battle yet.
As I understand Dioxine want some items that can't be even primed in pre-battle state (quest items?).

Current behavior still can have uses (like consumable items that can buff user when equipped) but Dio case is too reasonable.
Now question what version should be default for `0` as we could break mods that wanted opposite.

[Meridian]

Not sure if it's OXC or OXCE bug, but prepriming allows you to prime or unprime grenades with     costPrime/costUnprime:       time: 0 (which normally makes it impossible to prime or unprime grenades).

Implemented:
https://github.com/MeridianOXC/OpenXcom/commit/c721b58520b323424e71ed900249533017ac134c
https://github.com/MeridianOXC/OpenXcom/commit/d17a6910ab1377274f3944322bde8b97dc231064

It also allows to sidestep other ways of making a grenade impossible to prime or unprime, like fuseType: -3.

Cannot reproduce -> cannot fix.