[DONE][Suggestion] "Force spawn" option

[Delian]

As documented, the current difficulty option difficultyDemigod has two functions:
- Always spawn maximum amount of enemies set in the deployment for the current difficulty
- Force spawn enemies even if there's not enough spawn nodes

This is not configurable enough for modders (e.g. Dioxine only wanted the force-spawning feature, but not the always-maximum-enemies feature). Therefore, I suggest adding two new options, which together work the same as difficultyDemigod:
- difficultyDemigodMaxEnemies
- difficultyDemigodForceSpawn

[hth]

How about to remove this incorrect and confusing term entirely, leaving only these two options instead?

[Yankes]

No, because it will break all mods that use it.

[Delian]

I'm also against removing it. As I wrote, I suggest adding new options while keeping the old one, to keep backwards compatibility. But the new options have priority over the old one, so if both new options are set, then the old one has no effect.

[Meridian]

"Max enemies" is already moddable, I don't feel the need to add an option for something that can already be done.

"Force spawn" can be added.

Effects will be cumulative (i.e. new option will not have priority over the old one). Modder to decide, which one he wants to use.

[Meridian]

Implemented: https://github.com/MeridianOXC/OpenXcom/commit/c221adec6f96a457c26e0b7c3440b7a707dd20d8

Sample ruleset:

Code: [Select]

constants:
  extendedForceSpawn: true  # default false


[robin]

In OXCE difficulty.rul, constants are preceded by "- ".
So perhaps it should be

Code: [Select]

constants:
  - extendedForceSpawn: true  # default false?

[Meridian]

Both are supported.

Mine is newer, yours is older (deprecated, but still working).

[Dioxine]

Thank you for this.