[Bug] totalReactionFire logic

[Dorten]

Right now it counts "kills earned by the soldier that occured on the hostile turn, where the weapon was not a grenade or a proximity grenade."

The problem is: when a unit bleeds (or burns) to death, game attributes it's killing to "the one who hit it last", and as bleeding/burning of enemy units happens on enemy turn, ALL enemies that bled out count towards totalReactionFire (except those wounded by grenade or a proximity grenade).

Noticed this when my AI units in Minigun tanks started getting Overwatcher commandment in XCF.

Easy (while not very elegant) fix would be storing wether the shot was reaction at the same place where "the one who hit it last" info is remembered.

[Meridian]

Easy (while not very elegant) fix would be storing wether the shot was reaction at the same place where "the one who hit it last" info is remembered.

(Just FYI) I'm not thrilled by the idea of storing even more data, it's too much today already.

On the other hand, I don't see any other solution (other than leave it as known bug).

[Dorten]

I'm not thrilled by the idea of storing even more data

That's understandable

[Delian]

I'd like to point out that it's not actually kills, but knockouts. You can knock out an enemy on the enemy's turn and get awarded a reaction fire "kill". Then this enemy bleeds out and you get awarded another kill.

So, I think it would be better if the bleeding out enemies simply don't award a reaction fire kills. Either the kill was a direct result of reaction fire, or it wasn't.

[Yankes]

I agree with Delian, only direct hits probably should count to reactions

[Dioxine]

I think this commendation is hard enough to exploit and easy enough to balance even as it is now (except for double kills Delian mentioned, and since reactions should be also awarded for non-lethal, I second that only the person who neutralized the enemy should gain it, either by killing or knocking out).

Speaking of KO's, there is commendation logic that offers much bigger exploits: STATUS_UNCONSCIOUS 'kill' is awarded to all player units that participated, even if the enemy is KO'd multiple times per mission or even per turn (IMO should only go to the first time in battle). Of course few have the required level of self-loathing presented by some players from Russian comunity, creating stun-revive-stun trains...