[DONE][Suggestion] max stats for soldier transformation

[Nord]

To the point: add "requiredMaxStats"
similar to "requiredMinStats".
Please, if not too complicate.
Thanks.

[Meridian]

what's the use case?

[Nord]

Transformations for weak enough soldiers, of course. In my case - body enchancement for soldiers with low psi capability.

[psavola]

What would be the logical reason why high psi capability soldiers should not be able to get this enhancement? At least usually high PSI is "something extra", not something that blocks or prevents other progress or makes you weaker?

Of course I can imagine scenarios how this could maybe make sense in other settings. For example, consider a "rookie bootcamp" transformation/training, which could only be applied to relatively fresh recruits, and which would essentially just provide a boost to some stats. Then it would make sense that the veterans would not want to go there and would maybe not even be admitted in such a training. Not sure how interesting something like this would be for modders though, and there could be problems how you define the various limit(s).

[HinterDemGlas]

What would be the logical reason why high psi capability soldiers should not be able to get this enhancement? At least usually high PSI is "something extra", not something that blocks or prevents other progress or makes you weaker?

There is plenty of precedent in sci fi settings with magic brain powers for Psi-immune characters, often coupled with an inability to use Psi. It might be very fitting for certain mods to model that as a transformation for soldiers with exactly 0 PST or something like that. Just something that came to mind when I read the question.

[Meridian]

Transformations for weak enough soldiers, of course. In my case - body enchancement for soldiers with low psi capability.

ok todolisted

[Solarius Scorch]

That would be useful - nowadays it's a common problem that veteran soldiers still have access to transformations meant for beginners, which clutters the list. Not a big deal, since you can always add +1 something to make the transformation not completely useless, but it's not ideal.

[Meridian]

Added `requiredMaxStats` and `includeBonusesForMaxStats`.

Example:

Code: [Select]

soldierTransformation:
  - name: STR_PROJECT_NAME
    includeBonusesForMaxStats: true # default false
    requiredMaxStats:               # default all 9999
      bravery: 30
    flatOverallStatChange:
      firing: 99
    allowedSoldierTypes:
      - STR_SOLDIER
    allowsLiveSoldiers: true
    forbiddenPreviousTransformations:
      - STR_PROJECT_NAME


[Nord]

Thanks.

[Solarius Scorch]

Much appreciated.