aliens

Author Topic: [ABANDONED] List dots are colored  (Read 1516 times)

Offline Alpha Centauri Bear

  • Colonel
  • ****
  • Posts: 466
    • View Profile
[ABANDONED] List dots are colored
« on: December 12, 2023, 10:25:28 pm »
When list is filled with dots between words and right column is right aligned, it looks two colorish which is kind of distracting, I say.
For this kind of case when right aligned numbers are displayed there, it would be probably nicer looking if the number cell itself is not filled with dots.
« Last Edit: December 12, 2023, 10:27:07 pm by Alpha Centauri Bear »

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 9091
    • View Profile
Re: List dots are colored
« Reply #1 on: December 12, 2023, 11:33:30 pm »
Sounds good to me, feel free to make a PR.

Offline Alpha Centauri Bear

  • Colonel
  • ****
  • Posts: 466
    • View Profile
Re: List dots are colored
« Reply #2 on: December 12, 2023, 11:44:06 pm »
No permission to push feature branch. Please grant.

username: tnevolin

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 9091
    • View Profile
Re: List dots are colored
« Reply #3 on: December 12, 2023, 11:45:08 pm »
No permission to push feature branch. Please grant.

Everybody can make a PR.
It literally cannot be forbidden.

Offline Alpha Centauri Bear

  • Colonel
  • ****
  • Posts: 466
    • View Profile
Re: List dots are colored
« Reply #4 on: December 12, 2023, 11:48:47 pm »
You are right this can be done by forking and then creating cross repository PR.
I was just hoping forking can be avoided for such simple change. I am going to delete my fork after that anyway even if created.

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 9091
    • View Profile
Re: List dots are colored
« Reply #5 on: December 13, 2023, 12:03:32 am »
Also, where did you even find a right-aligned, dotted, double-colored column in OpenXcom?
I just looked and I can't see any.

If that's just in your fork, then there's no point putting it into OXC/E, since it won't be used anyway.

Offline Alpha Centauri Bear

  • Colonel
  • ****
  • Posts: 466
    • View Profile
Re: List dots are colored
« Reply #6 on: December 13, 2023, 12:05:19 am »
It's up to you. I have already applied it in my fork. Let me know if you need it.

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 9091
    • View Profile
Re: List dots are colored
« Reply #7 on: December 13, 2023, 12:13:47 am »
It's up to you. I have already applied it in my fork. Let me know if you need it.

Well, I don't need it if there is no GUI using it.