[FIXED] Game Allows To Launch Craft Without Pilots

[Dioxine]

If you choose to do aerial transfer, you don't need to have required pilots in craft. This should never be allowed, as it leads to all sorts of secondary bugs (eg. teleporting pilots to craft in-flight if you change the transfer order to patrol when ship is airborne).

[Meridian]

I'm lost.

What exactly should I do to see this happen?

How do you get a craft airborne without pilots? And how do you change their transfer order to patrol order?

[psavola]

I can reproduce the issue as follows in 7.9.18. Remove all crew from a craft. Click 'I' on the globe. Select the craft, then another base (within the dual fuel range) as the destination. Select transfer. Voila - the craft starts flying without a pilot. (And after that, you can also reroute the the craft.)

[Meridian]

Thanks.

Yes, I will take care of this case.

[Meridian]

Were you able to replicate teleporting soldiers? I still can't replicate that.

[psavola]

Were you able to replicate teleporting soldiers? I still can't replicate that.

I only tried the flying empty craft. I now tried, but could not get a pilot to appear on the craft after changing it to patrol (but there weren't all that many details in the post as to how to do it anyway). Maybe Dioxine will provide more information. And/or the issue becomes moot if the craft pilots > 0 is checked before fly-transfer.

[zRrr]

Were you able to replicate teleporting soldiers? I still can't replicate that.

Start aerial transfer from Base A to Base B, with no pilots. While craft moves, retarget it anywhere (waypoint, crash site, etc). Game will complain about lack of pilots, and will offer to add some. If player accepts, game will open craft window and let player add soldiers and gear from Base B. Craft then can be ordered to transfer back to Base A for super fast items and troops transfer.

[Meridian]

Thanks, I see now, the soldiers from the second base.

Both issues fixed here: https://github.com/MeridianOXC/OpenXcom/commit/033f67713c1122c728902a37b258ffb4c2da7a4a