[FIXED] Vanilla civllians spawning, why? [OXC]

[robin]

Vanilla civilians are spawning but they should not.

Could it be because there aren't enough civilian spawn points on the map, so to fill the "16" quota it spawns regular civilians?

terrains:
  - &WAREFACTORY_SMALL
    name: WAREFACTORY_SMALL
    civilianTypes:
      - STR_CIV_SCIENTIST_M
      - STR_CIV_SCIENTIST_F
    mapDataSets: *mapDataSetsWarehouse
    [...]
  - name: WAREFACTORY_LARGE
    refNode: *WAREFACTORY_SMALL
    script: WAREFACTORY_LARGE
       
alienDeployments:
  - &STR_DROP_MISSION_LARGE
    type: STR_DROP_MISSION_LARGE
    [...]
    civilians: 16
    [...]
  - type: STR_DROP_MISSION_LARGE_INDUSTRIAL
    refNode: *STR_DROP_MISSION_LARGE
    terrains:
      - WAREHOUSE_LARGE
      - WAREFACTORY_LARGE
      - WAREMTL_LARGE

[Meridian]

Probably a bug/sideeffect of using refNode.

I'll check.

[robin]

Thanks
I noticed that in language strings, terrains have "MAP_" added to them, so "WAREFACTORY_SMALL" --> "MAP_WAREFACTORY_SMALL".
Maybe this screws the refNode?
Just a wild guess, I don't know it works.

[Meridian]

I noticed that in language strings, terrains have "MAP_" added to them, so "WAREFACTORY_SMALL" --> "MAP_WAREFACTORY_SMALL".
Maybe this screws the refNode?

No, it's something else, related to source code, hard to explain.

[Meridian]

Found the issue.
It's not even related to refNode, just a quirk in loading civilianTypes.

Reported to OXC devs.

[robin]

Thank you a lot.

[Meridian]

Fixed in OXCE 7.8.11

https://github.com/MeridianOXC/OpenXcom/commit/f296c2d18c8465d72fd7cad912e2d1749acffaa6