[DONE] Check for invalid LoftIDs

[efrenespartano]

Howdy!

I'm asking here because my mod uses OXCE, so I think it would be the right place.

One of my players is experiencing a vector::_M_range_check issue on the latest UNEXCOM update. Link here to the GitHub repo. The crash happens on the Alien turn. Attaching screenshots as support. As soon as the Sectoid looks in the direction of the player's craft, it has clear view of all the units. And it crashes. I made tests by removing several xcom units from the LOS of the Sectoid and the CTD was prevented.

I suppose the game cannot handle the alien unit having more than ten targets at the same time in this particular case? I made changes on the map routes and on the armor of the Sectoid to see if that solves the issue, but I cannot find a way to solve it. I suspect maybe one tile on the IDT_RED_FARM may be the reason of the CTD, but haven't found anything so far.

Made tests with OXCE v7.5.3 and v7.4.4, the issue was recurrent on both.

Any help is appreciated! 

[Meridian]

terrain IDT_BARN_RED_2
tile at position [35,18,0]
part 3 (i.e. object on the tile)
loftemps array = {6, 6, 6, 130, 130, 130, 130, 130, 6, 6, 6, 130}

value 130 is invalid... UFO has only 112 loftemps (from 0 to 111)

[efrenespartano]

terrain IDT_BARN_RED_2
tile at position [35,18,0]
part 3 (i.e. object on the tile)
loftemps array = {6, 6, 6, 130, 130, 130, 130, 130, 6, 6, 6, 130}

value 130 is invalid... UFO has only 112 loftemps (from 0 to 111)

Thanks a lot for your help, Meridian! I didn't noticed the thing until you pointed out it. 

[Meridian]

I have automated this check in a test on the OXCE test screen (ctrl+T), see attached screenshot.

Log file output looks like this (here an example from X-Chronicles):

Code: [Select]

[06-01-2025_19-56-12] [ERROR] Error in terrain: URBAN_ROADS dataset: URBAN_ROADS2 object 62 has LoftID: 118. MAX_LOFT_ID = 111. Found using OXCE test cases.
[06-01-2025_19-56-12] [ERROR] Error in terrain: URBAN_ROADS dataset: URBAN_ROADS2 object 63 has LoftID: 121. MAX_LOFT_ID = 111. Found using OXCE test cases.
[06-01-2025_19-56-19] [INFO] ----------
[06-01-2025_19-56-19] [INFO] SUMMARY
[06-01-2025_19-56-19] [INFO] ----------
[06-01-2025_19-56-19] [INFO] URBAN_ROADS2: 62, 63