OpenXcom Forum

OpenXcom Forks => OpenXcom Extended (OXCE) => OXCE Suggestions DONE => Topic started by: Tamren on November 08, 2024, 11:32:39 am

Title: [DONE][Suggestion] "Equipped" filter in the Purchase UI
Post by: Tamren on November 08, 2024, 11:32:39 am
This suggestion is to add a new sort category called "Equipped" to the buy menu accessible from the base purchasing screen. "Equipped" means any item currently loaded onto a dropship or any other craft, this sort option is already tracked for individual craft, so you would only need to add together all of the "equipped" sorts from every craft in service to determine what is currently being used.

The use case is very common, as a player I often need to (re)purchase equipment multiple times a month, especially consumables such as grenades, medical supplies and ammunition. This would give me a way to quickly shorten the list of purchasable equipment to only those items which I am already using.
Title: Re: [QoL] "Equipped" sort option for the HQ buy menu
Post by: Yankes on November 08, 2024, 11:55:15 am
But this have one "hole", if you use 10 items and spend 9 it will work fine, but if you spend all then this logic fails as it will be not "used" anymore.
Title: Re: [QoL] "Equipped" sort option for the HQ buy menu
Post by: Meridian on November 08, 2024, 11:59:58 am
But this have one "hole", if you use 10 items and spend 9 it will work fine, but if you spend all then this logic fails as it will be not "used" anymore.

True, but in this case, you will always get also a "Not enough equipment to re-equip craft" message (and have the option to order more stuff directly from there).

And you'll anyway need to manually add/increase the equipment on the craft afterwards, so manual effort is unavoidable.
Title: Re: [QoL] "Equipped" sort option for the HQ buy menu
Post by: Tamren on November 08, 2024, 12:14:58 pm
True, but in this case, you will always get also a "Not enough equipment to re-equip craft" message (and have the option to order more stuff directly from there).

And you'll anyway need to manually add/increase the equipment on the craft afterwards, so manual effort is unavoidable.

Yeah exactly, this idea is the missing "second half" to the current feature. Instead of warning you if you run out of something after the fact which requires you to order more of that thing and then manually (re)load it onto the dropship when it arrives. This makes it easier to preemptively order more of things you expend on a regular basis to stop that from happening in the first place.
Title: Re: [QoL] "Equipped" sort option for the HQ buy menu
Post by: GumChewer on November 16, 2024, 06:37:55 pm
+1 for such a feature. Thanks.

What about another category for items equipped by any soldier?
I do not need it. But maybe it is relevant for mods with a lot of base defenses and thus a lot of soldiers not assigned to crafts?
Title: Re: [DONE][Suggestion] "Equipped" filter in the Purchase UI
Post by: Meridian on January 12, 2025, 03:07:58 pm
Done.

https://github.com/MeridianOXC/OpenXcom/commit/cbeace4a0cb9aa036f26f7258c42e107b7ccb1f1
Title: Re: [DONE][Suggestion] "Equipped" filter in the Purchase UI
Post by: psavola on January 16, 2025, 08:18:29 pm
This causes a regression (I suppose you could see this as one): after the completion of a mission, if you run out of some item, and you hit "purchase" to replenish your stock on craft in the screen "Not enough equipment to fully re-equip squad", the purchase screen by default goes to "Equipped", not "Missing" as before. In this context, "Missing" would be much more preferable.
Title: Re: [DONE][Suggestion] "Equipped" filter in the Purchase UI
Post by: Meridian on January 16, 2025, 09:05:05 pm
Thanks.
Will be fixed.
Title: Re: [DONE][Suggestion] "Equipped" filter in the Purchase UI
Post by: Meridian on January 18, 2025, 11:14:16 am
Fixed: https://github.com/MeridianOXC/OpenXcom/commit/addddd096799061d40e86f676fb27c2fe3170cf2