OpenXcom Forum

OpenXcom Forks => OXCE Suggestions NEW => OpenXcom Extended (OXCE) => OXCE Suggestions Abandoned => Topic started by: Alpha Centauri Bear on December 12, 2023, 10:25:28 pm

Title: [ABANDONED] List dots are colored
Post by: Alpha Centauri Bear on December 12, 2023, 10:25:28 pm
When list is filled with dots between words and right column is right aligned, it looks two colorish which is kind of distracting, I say.
For this kind of case when right aligned numbers are displayed there, it would be probably nicer looking if the number cell itself is not filled with dots.
Title: Re: List dots are colored
Post by: Meridian on December 12, 2023, 11:33:30 pm
Sounds good to me, feel free to make a PR.
Title: Re: List dots are colored
Post by: Alpha Centauri Bear on December 12, 2023, 11:44:06 pm
No permission to push feature branch. Please grant.

username: tnevolin
Title: Re: List dots are colored
Post by: Meridian on December 12, 2023, 11:45:08 pm
Quote from: Alpha Centauri Bear on December 12, 2023, 11:44:06 pm
No permission to push feature branch. Please grant.

Everybody can make a PR.
It literally cannot be forbidden.
Title: Re: List dots are colored
Post by: Alpha Centauri Bear on December 12, 2023, 11:48:47 pm
You are right this can be done by forking and then creating cross repository PR.
I was just hoping forking can be avoided for such simple change. I am going to delete my fork after that anyway even if created.
Title: Re: List dots are colored
Post by: Meridian on December 13, 2023, 12:03:32 am
Also, where did you even find a right-aligned, dotted, double-colored column in OpenXcom?
I just looked and I can't see any.

If that's just in your fork, then there's no point putting it into OXC/E, since it won't be used anyway.
Title: Re: List dots are colored
Post by: Alpha Centauri Bear on December 13, 2023, 12:05:19 am
It's up to you. I have already applied it in my fork. Let me know if you need it.
Title: Re: List dots are colored
Post by: Meridian on December 13, 2023, 12:13:47 am
Quote from: Alpha Centauri Bear on December 13, 2023, 12:05:19 am
It's up to you. I have already applied it in my fork. Let me know if you need it.

Well, I don't need it if there is no GUI using it.