OpenXcom Forum

Contributions => Programming => Topic started by: 7Saturn on February 17, 2015, 11:38:03 pm

Title: Holey supply ship
Post by: 7Saturn on February 17, 2015, 11:38:03 pm
I noticed, that the supply ship seems to have a hole, regarding fire and los for aliens within. When you place a tank near a supply ship, like in the screenshot the one on the right hand side, the aliens in level 2 above it shoot at it, from within the ufo. They seem to be able to see it, and most certainly, shoot at it. Anyone else noticed that?
Title: Re: Holey supply ship
Post by: Warboy1982 on February 18, 2015, 02:43:47 am
it's a known issue that is fixed with the data patch here: https://openxcom.org/downloads-extras/
Title: Re: Holey supply ship
Post by: 7Saturn on February 18, 2015, 08:56:43 am
Thanks for the quick response. I'll try that one.
Title: Re: Holey supply ship
Post by: kikimoristan on February 18, 2015, 11:24:14 am
What WARBOY said. If you wish to know more or perhaps exploit these bugs see here https://www.ufopaedia.org/index.php?title=LOFTEMPS.DAT#Blatant_LOFTemps_Bugs
Title: Re: Holey supply ship
Post by: 7Saturn on February 19, 2015, 11:51:56 pm
Well, after applying the above patch, there doesn't seem to be any change. When placing a tank at the exact same point as in the screenshot, it's being fired upon, anyways. If I remember it correctly, this map-bug never occurred, when playing the windows-version of original xcom. At least not in that way, that the aliens were able to fire out of the ufo. But the bug could be used to enter the ufo with a soldier. Are you sure, the mentioned patch fixes these issues?
Title: Re: Holey supply ship
Post by: kikimoristan on February 20, 2015, 02:21:47 am
get MCD Edit and map editor..take a look at that map find the tile..take a look in MCD Edit find  the tile and look at lofts see if it matches it probably doesn't . might be a new bug nobody noticed before.

Title: Re: Holey supply ship
Post by: kikimoristan on February 20, 2015, 02:23:55 am
xcom team went pretty far to make surer line of sight is realistic. a lot of care went into designing every tile. but sometimes they missed a few and so you get holes in the walls and other strange bugs. things the ufo developers overlooked
Title: Re: Holey supply ship
Post by: volutar on February 20, 2015, 05:16:10 am
IDK if this universal patch stitched this hole, but obviously OXC lacks of binary patch capability, not to depend from third-party "asset fixers". MCDPatch is definately not enough.

7Saturn, please, don't make these large screenshots, they look really bad in the forum.
Title: Re: Holey supply ship
Post by: ivandogovich on February 20, 2015, 05:40:58 am
Hmmm... two other holes... that I've noticed.. 

The Lightning has the southwest wall as a secret door.  ie. Units can exit the craft there.  - known bug?  I'd guess so.

I think there is a hole in the second floor of the battleship within two tiles of the SW doors of the elevator shaft.  I've had units shot in the head and grenaded from this "murder hole."

Cheers, Ivan :D
Title: Re: Holey supply ship
Post by: volutar on February 20, 2015, 06:00:48 am
could you provide a picture taken with f10 /f11?
Title: Re: Holey supply ship
Post by: ivandogovich on February 20, 2015, 06:34:05 am
https://youtu.be/h7Gq6J4yAcc?t=22m34s  Troops exiting the lightning..

I've attached an image where it feels like the battleship murder hole might be.

Title: Re: Holey supply ship
Post by: volutar on February 20, 2015, 06:41:49 am
are you sure its nightly version and not obsolete 1.0? with all modern rulesets including mcdpatches?
Title: Re: Holey supply ship
Post by: ivandogovich on February 20, 2015, 08:01:53 am
 ;D  nope.  mine is definitely the obsolete 1.0 version. 

Sounds like all these would have been fixed then. Perfect. ;)
Title: Re: Holey supply ship
Post by: Arthanor on February 20, 2015, 08:21:35 am
The lightning does indeed get patched, I remember having this issue and it disappearing when I upgraded.

I can't tell about battleships. They have a habit of disappearing right after they swarm my bases with aliens so I haven't boarded many. :/
Title: Re: Holey supply ship
Post by: 7Saturn on February 20, 2015, 09:15:20 am
are you sure its nightly version and not obsolete 1.0? with all modern rulesets including mcdpatches?
Probably not, as I use the version from Ubuntu repositories. OK, I believe, I need an install-guide. Use this version, these patches, and you have a fixed map... :-\
Title: Re: Holey supply ship
Post by: volutar on February 20, 2015, 09:42:16 am
Well, I don't remember if I use the patched data (since I hate to use third parties) but surely at this issue is vanilla (from the shots I made).
Title: Re: Holey supply ship
Post by: kikimoristan on February 20, 2015, 01:34:18 pm
i had a look myself and volutar nailed it. The hole is missing ground so they can shoot down at you but is not obvious because adjacent wall tiles also have some ground as part of their sprites but the  lof is a wall type so engine sees a hole there. so it appears like you have ground and wall but in fact is just a wall with a hole underneath . simply add the matching ground in mapview.
Title: Re: Holey supply ship
Post by: 7Saturn on February 20, 2015, 01:38:46 pm
If there are already people who fix(ed) this, please upload it. (Yeah, I'm simply to lazy to work myself into those details and fix it myself at my side.  ;D)
Title: Re: Holey supply ship
Post by: kikimoristan on February 20, 2015, 03:22:48 pm
If there are already people who fix(ed) this, please upload it. (Yeah, I'm simply to lazy to work myself into those details and fix it myself at my side.  ;D)


it takes like 2 seconds  put it in your maps overwrite the other one is gonna patch the hole in the ground. there may be other bugs
Title: Re: Holey supply ship
Post by: kikimoristan on February 20, 2015, 03:26:37 pm
also the lightning is a famous bug long time patched its lof is wrong.  but if you are using vanilla maps/terrain then is still gonna be there. honestly  is good in a way as lighting sucks anyway at least is more tactical to deploy 3 people at once.
Title: Re: Holey supply ship
Post by: 7Saturn on February 20, 2015, 04:23:56 pm
it takes like 2 seconds  put it in your maps overwrite the other one is gonna patch the hole in the ground. there may be other bugs
That's pretty much what I did with the hole Update-Pack. ;) I assume, this file (I just tested it) is the same, as in the updatepack? As I said, that alone doesn't do the trick with the version from Ubuntu repositories. Now the question for me is, if it is necessary to download the source and compile a nightly, to benefit from it, or not.
Title: Re: Holey supply ship
Post by: kikimoristan on February 20, 2015, 04:44:48 pm
you'e probably not doing it right if nothing ever changes. i added the terrain you may need to restart that mission possibly load/save is fixed terrain from before.  next time you see the ship may be patched.
Title: Re: Holey supply ship
Post by: 7Saturn on February 20, 2015, 05:01:02 pm
you'e probably not doing it right if nothing ever changes.
You may be right, however...
you may need to restart that mission
I did all tests with a restartet openxcom, starting a »New Battle« instead of loading any saved game. So that can't be the problem. The new files supposedly were loaded and used, as there are any other.
next time you see the ship may be patched.
Simply: No. It's not. But as I said, I'm using 1.0, current version from the Ubuntu repositories. If a newer version is necessary, then that's where the problem lies.
Title: Re: Holey supply ship
Post by: kikimoristan on February 20, 2015, 05:09:08 pm
just tested it now is fixed on my side. as i said before you probably are doing something weird. put the file in MAPS and replace the old one. I have a feeling you might have installed the patch wrong :)  Maybe you have 2 sets of data. Maybe  you do need  nightly :)
Title: Re: Holey supply ship
Post by: Arthanor on February 20, 2015, 05:12:16 pm
Both 1.0 and the nightly should just use whichever file it is that you provide them. I don't believe the engine needs to be upgraded to be patched but the upgraded game from the nightly might well already have the patch, or not, since it too will read whichever map you provide it.

Regardless, it is a good thing to upgrade from 1.0 to the nightly. As volutar said, it is a bit old now..
(If you need help, feel free to send me a pm, I also run on Ubuntu and I have notes on how I install nightlies)
Title: Re: Holey supply ship
Post by: 7Saturn on February 20, 2015, 07:45:16 pm
as i said before you probably are doing something weird.
I'm just wondering, what...
put the file in MAPS and replace the old one.
That much I already figured out. ;)
I have a feeling you might have installed the patch wrong :) Maybe you have 2 sets of data.
There's exactly one file »UFO_170.MAP« on my harddisk, so it must be the one, the game is using. And thats exactly the one from the patch, I put there.
Maybe  you do need  nightly :)
I think, I'll better try that.
(If you need help, feel free to send me a pm, I also run on Ubuntu and I have notes on how I install nightlies)
I'll see, if I need your support.  :)
Title: Re: Holey supply ship
Post by: 7Saturn on March 06, 2015, 11:50:26 pm
So, it seems to work, with the nightly, anyway. But I was having quite a hassle, getting the nightly to run. Which makes me wonder, if it would be useful, to publish them on repositories 'n stuff... Using the same data-folder as the normal installed version seems to be causing some serious problems.
Title: Re: Holey supply ship
Post by: 7Saturn on May 08, 2015, 05:46:56 pm
And now it seems not to, any more. Nightly from this morning, compiled under Ubuntu 14.04 x64, using the very same vanilla + patch files, as before. Maybe something went wrong, while changing the directory-layout for ufo-files?
Title: Re: Holey supply ship
Post by: 7Saturn on May 10, 2015, 11:27:37 am
Anybody having this problem again, as well? Or is it just me? New nightly, new copy of the vanilla files, newly copied patch-files, and the supply ship is »leaking plasma« again on the front left corner.
Title: Re: Holey supply ship
Post by: moriarty on May 10, 2015, 11:39:44 am
Yep, same here.
Title: Re: Holey supply ship
Post by: hellrazor on May 19, 2015, 12:47:17 pm
Well i have fixed the Supply Ship Map by adding the missing groundtile in mapview.
I also checked how the other diagonal walls groundtiles were built, and there is a set of groundtiles which probably need to overlap to make sure nothing can shoot true.

Maybe you try the UFO_170.MAP attached here and tell me if the Plasma leaking still occurs?

Just make a backup of your original file and overwrite it.
Title: Re: Holey supply ship
Post by: 7Saturn on May 19, 2015, 09:15:16 pm
Doesn't seem to do the trick on this end. I attached the savedgame, showing the problem rather clearly. Only end the turn and you will see. I tested it with the latest nightly, downloaded just 10 minutes ago.
Title: Re: Holey supply ship
Post by: hellrazor on May 20, 2015, 03:23:25 am
Create a new Battle, do not load a savegame which was made with the unpatched map.

Because the mapdate stored in the savegame file for battle terains also includes which tiles are placed were.

You can check out the attached save were you can see the patched map working.
Title: Re: Holey supply ship
Post by: 7Saturn on May 20, 2015, 07:54:58 am
Oh, didn't know that. But now that you mention it: Sure, if you damage a map-item, it has to be stored somewhere, so it's logical. =) I'll try it by starting a new Battle.
Title: Re: Holey supply ship
Post by: 7Saturn on May 20, 2015, 06:20:05 pm
OK, after carefully testing it in debugmode, I believe, the problem has been solved by you. =) Thanks for the work. I'll add it to my patch-files. Just one additional question on that topic: Do you think, these files will be usefull for ufo2000-maps as well? (Maybe Hobbes can shed some light on that, too...). It relies on vanilla-files, as well. But I don't know, if these bugfixes on the maps may be benefitial to it, as well.
Title: Re: Holey supply ship
Post by: hellrazor on May 21, 2015, 11:54:46 am
OK, after carefully testing it in debugmode, I believe, the problem has been solved by you. =) Thanks for the work. I'll add it to my patch-files. Just one additional question on that topic: Do you think, these files will be usefull for ufo2000-maps as well? (Maybe Hobbes can shed some light on that, too...). It relies on vanilla-files, as well. But I don't know, if these bugfixes on the maps may be benefitial to it, as well.

Everyone with MapView can solve this Problem.
But it is still inclining to me that this bug is not fixed in the universal data patch. At least not in the Version i have been using maybe there is a new one which already has this fixed, i don't know.
Title: Re: Holey supply ship
Post by: Tarvis on June 01, 2015, 05:37:28 pm
It is fixed in the universal patch. 7saturn just didn't get the updated map because he loaded a savegame.
Title: Re: Holey supply ship
Post by: 7Saturn on June 01, 2015, 05:58:41 pm
It's not completely wrong but not completely right, either. There was a problem, at first, which vanished, after patching my files. Then it reappeared which had nothing to do with saved game. Only that second fixing, that didn't help at first, because of loading a saved game. Anyways, it's working again, and I'm happy. =)
Title: Re: Holey supply ship
Post by: Tarvis on June 01, 2015, 06:07:26 pm
Well, I don't know what to tell you. hellrazor's modified map file is identical to the one in the universal patch.
Title: Re: Holey supply ship
Post by: hellrazor on June 01, 2015, 06:13:22 pm
Well, I don't know what to tell you. hellrazor's modified map file is identical to the one in the universal patch.

Good to know that this is taken care of in the universqal data patch i wasn't aware of it.