Author Topic: Cannot install TFTD Rework mod  (Read 1021 times)

Offline Alpha Centauri Bear

  • Captain
  • ***
  • Posts: 73
    • View Profile
    • Email
Cannot install TFTD Rework mod
« on: October 14, 2020, 06:04:51 am »
Hello everyone.
Not sure it is right place to ask mod installation question but maybe someone knows the answer.

I have downloaded nightly about a month ago and have installed few mods already. They all work fine.
Then I have downloaded latest TFTD Rework mod, unpacked it and copied into mod directory. It failed with error. See the mod tread link and error below. Anyone is able to help? Thank you.

https://openxcom.org/forum/index.php/topic,4265.0.html

Code: [Select]
[13-10-2020_22-54-11] [INFO] Active mods:
[13-10-2020_22-54-11] [INFO] - xcom2 v1.0
[13-10-2020_22-54-11] [INFO] - Aliens_Pick_Up_Weapons_TFTD v1.0
[13-10-2020_22-54-11] [INFO] - StrategyCore_Swap_Small_USOs_TFTD v1.0
[13-10-2020_22-54-11] [INFO] - UFOextender_Psionic_Line_Of_Fire_TFTD v1.0
[13-10-2020_22-54-11] [INFO] - XcomUtil_Improved_Gauss v1.0
[13-10-2020_22-54-11] [INFO] - XcomUtil_Pistol_Auto_Shot_TFTD v1.0
[13-10-2020_22-54-11] [INFO] - XcomUtil_Starting_Defensive_Base_TFTD v1.0
[13-10-2020_22-54-11] [INFO] - XcomUtil_Statstrings v1.0
[13-10-2020_22-54-11] [INFO] - Skyhawk-TFTD-FixGaussCoelecanth v1.01
[13-10-2020_22-54-11] [INFO] - skyhawk-tftd-fixmagnav v1.0
[13-10-2020_22-54-11] [INFO] - TFTD Rework v1.3bb v1.3bb
[13-10-2020_22-54-11] [INFO] Loading rulesets...
[13-10-2020_22-54-11] [WARN] disabling mod with invalid ruleset: TFTD Rework v1.3bb
[13-10-2020_22-54-11] [ERROR] failed to load 'TFTD Rework'; mod disabled
this mod name is already used

Offline Alpha Centauri Bear

  • Captain
  • ***
  • Posts: 73
    • View Profile
    • Email
Re: Cannot install TFTD Rework mod
« Reply #1 on: October 14, 2020, 06:39:57 am »
Found the offender. Apparently current openxcom build complains about negative values in parameters like this one.
Code: [Select]
  - type: PLASMICIDE_WEAPON
    bigSprite: -3

Why did it work before? Engine changed to more strict rules? I guess, negatives were used to disable (?) certain sprite or something. How should they be disabled properly?

Offline Alpha Centauri Bear

  • Captain
  • ***
  • Posts: 73
    • View Profile
    • Email
Re: Cannot install TFTD Rework mod
« Reply #2 on: October 14, 2020, 07:50:35 am »
Found another problem: add-on subfolder in the mod. Apparently, new engine doesn't like it either. I should take them out and use as a separate mods.
Engine designers, what is the proper way to add add-ons?

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 7379
    • View Profile
Re: Cannot install TFTD Rework mod
« Reply #3 on: October 14, 2020, 09:27:06 am »
Found the offender. Apparently current openxcom build complains about negative values in parameters like this one.

Why did it work before? Engine changed to more strict rules? I guess, negatives were used to disable (?) certain sprite or something. How should they be disabled properly?

It was changed, because it was necessary for some other features.

Description how to fix it is here: https://www.ufopaedia.org/index.php/Ruleset_Reference_Nightly_(OpenXcom)#Negative_indices_and_cross-referencing_other_mods

Found another problem: add-on subfolder in the mod. Apparently, new engine doesn't like it either. I should take them out and use as a separate mods.
Engine designers, what is the proper way to add add-ons?

Add-on subfolders were never supported.
Each mod should be in its separate directory.

Offline Alpha Centauri Bear

  • Captain
  • ***
  • Posts: 73
    • View Profile
    • Email
Re: Cannot install TFTD Rework mod
« Reply #4 on: October 14, 2020, 02:49:28 pm »
Awesome, Meridian. Thank you for guidance!