aliens

Author Topic: [Answered] Script help needed.  (Read 4935 times)

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 8595
    • View Profile
Re: Script help needed.
« Reply #15 on: March 02, 2020, 08:48:30 pm »
Aha! Yes, the environmental effect does not pass the weapon to the hitUnit method call.

That would be a question for Meridian. I stumbled upon the same issue some days ago, not sure what the reasons are.

The scripts didn't even exist when enviro effects were implemented.

And when I was (periodically) merging OXCE into what was back then OXCE+, I probably didn't notice any changes necessary.

It's most likely simply just a missing feature... we have dozens of those... I'm pretty sure your soldier skills PR is not compatible with at least a dozen of other concepts... it's the same :)

So, no chances?

Someone just has to do it.
And test it.

Offline Yankes

  • Commander
  • *****
  • Posts: 3192
    • View Profile
Re: Script help needed.
« Reply #16 on: March 03, 2020, 12:51:03 am »
Another thing is this item exists or its only type of it used as damage source?

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 8595
    • View Profile
Re: Script help needed.
« Reply #17 on: March 03, 2020, 01:01:10 am »
Another thing is this item exists or its only type of it used as damage source?

It doesn't exist as a BattleItem.
Only the type used.

https://github.com/MeridianOXC/OpenXcom/blob/oxce-plus/src/Battlescape/NextTurnState.cpp#L308

Offline memmaker

  • Captain
  • ***
  • Posts: 95
    • View Profile
Re: Script help needed.
« Reply #18 on: March 03, 2020, 01:26:57 pm »
No, offense intended. Didn't even think it was an oversight. Like you said, the feature itself was completed and passing the battleitem down the line was just not needed. I might put that on my backlog and have a look at it, if I find the time.