Author Topic: Graphs screen hotkeys  (Read 5824 times)

Offline Hitnrun

  • Squaddie
  • *
  • Posts: 5
    • View Profile
Graphs screen hotkeys
« on: February 15, 2018, 02:14:13 pm »
Hello,

I always got tired of clicking all buttons on the Graphs screen to see which region/country have more alien activity, so I created 2 hotkeys on this screen:

F1: enable all that have activity >= 1
F2: enable all that have activity >= 7

As it is my first PR, see if this is acceptable.
https://github.com/SupSuper/OpenXcom/pull/1173

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 8974
    • View Profile
Re: Graphs screen hotkeys
« Reply #1 on: February 15, 2018, 02:24:11 pm »
why 7?

Offline Hitnrun

  • Squaddie
  • *
  • Posts: 5
    • View Profile
Re: Graphs screen hotkeys
« Reply #2 on: February 15, 2018, 05:47:08 pm »
why 7?

It was the value I observed that was small enough for less important areas, by playing some games.
It was really some small amount of trial and error.

Offline Hitnrun

  • Squaddie
  • *
  • Posts: 5
    • View Profile
Re: Graphs screen hotkeys
« Reply #3 on: February 16, 2018, 02:09:36 pm »
I did a larger play yesterday, and really 7 is a too loose value, dodn't really work out later.

Does someone have any suggestion on this? Show the top 3, or some calculation I can make with the values?

I think I used the graphs screen much more using these hotkeys, clicking one by one was always a chore.

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 8974
    • View Profile
Re: Graphs screen hotkeys
« Reply #4 on: February 16, 2018, 02:27:43 pm »
I chose a different approach.

I have always all countries/regions turned on... the ones where nothing happens are just a flat line anyway, so they don't bother me.
However when there is high activity (let's say 1000+ points) somewhere and only low activity (between 10 and 100) on other places, the default scaling doesn't work well, i.e. you can't see much in the low activity places.

Therefore I have implemented zoom in/zoom out functionality for the graphs so that I can zoom in on the lower activity if needed.
Default hotkeys (only available in OXCE+) for zoom in/out are Numpad +/- (can be configured)

PS: I have also added right-click to turn on/off all buttons
« Last Edit: February 16, 2018, 02:31:01 pm by Meridian »

Offline 7Saturn

  • Colonel
  • ****
  • Posts: 457
    • View Profile
Re: Graphs screen hotkeys
« Reply #5 on: February 16, 2018, 02:32:14 pm »
I believe there's another well solution for this: logarithmic scaling. This show's high values very well, while not hiding the low values at the same time. It'd be sufficient to be able to switch between linear and logarithmic scaling.

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 8974
    • View Profile
Re: Graphs screen hotkeys
« Reply #6 on: February 16, 2018, 02:39:34 pm »
Yeah, that's also a nice idea.

Another idea I had was automatic notification system when a higher activity is detected somewhere... so that you don't have to check the charts like an idiot every 5 minutes (I hope nobody is doing that Kappa). But somehow I was too lazy to do it and it ended somewhere on the bottom of my todo list in the meantime...

You know what? I'm gonna do it now... :)
« Last Edit: February 16, 2018, 02:42:16 pm by Meridian »

Offline Hitnrun

  • Squaddie
  • *
  • Posts: 5
    • View Profile
Re: Graphs screen hotkeys
« Reply #7 on: February 16, 2018, 03:28:37 pm »
Since I was a kid I always hated to keep clicking these buttons all the time on this game!

I made a change now to filter based on a percentage of the total, instead of a fixed value, seems to be better.
Also added F3 to clear all buttons.

I have to try your OXCE+ version also.