aliens

Author Topic: Cannot load battlescape saves  (Read 2516 times)

Offline BBHood217

  • Commander
  • *****
  • Posts: 540
    • View Profile
    • Email
Cannot load battlescape saves
« on: December 26, 2016, 02:56:41 am »
Ever since the latest nightly (2016-12-24), I've been unable to load any battlescape saves; it always crashes with a segmentation error whenever I try.  This happens both with mods (all I run is Area 51, though) and without mods.

Offline Hobbes

  • Commander
  • *****
  • Posts: 2101
  • Infiltration subroutine in progress
    • View Profile
Re: Cannot load battlescape saves
« Reply #1 on: December 26, 2016, 07:49:25 pm »
Just checked and this issue happens even without any mods enabled, as I got the same error when tryin to load a save.

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • *****
  • Posts: 10464
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
    • Email
Re: Cannot load battlescape saves
« Reply #2 on: December 26, 2016, 09:00:25 pm »
Maybe it's an anti-save-scumming feature? :D

Offline hellrazor

  • Commander
  • *****
  • Posts: 1987
  • Deep Ruleset Digger & Bughunter
    • View Profile
    • Github Account
Re: Cannot load battlescape saves
« Reply #3 on: December 26, 2016, 09:02:05 pm »
Line 508 and 509 in SaveBattleGame have the wrong scope.
They should be handled in the above "if", like in the old version.
This leads to the fact that the YAML node pointer is empty.
The pointer should only be emptied if there no mapsize bigger 0, indicating a battlescape save.

If this is right i do not know but _nodes.clear(), was before only called in the if statement.
Same goes for _mapDataSets.clear();

Edit: the forloop one line 504 also has wrong scope, being outside the above if.
« Last Edit: December 26, 2016, 09:27:33 pm by hellrazor »

Offline Hobbes

  • Commander
  • *****
  • Posts: 2101
  • Infiltration subroutine in progress
    • View Profile
Re: Cannot load battlescape saves
« Reply #4 on: December 26, 2016, 09:29:59 pm »
Maybe it's an anti-save-scumming feature? :D

Why stop there?

*Bluescreen*

"You have savescummed for the last time. Formatting C:\ has just begun. Have a nice day"

Offline SIMON

  • Commander
  • *****
  • Posts: 645
    • View Profile
    • Email
Re: Cannot load battlescape saves
« Reply #5 on: December 26, 2016, 10:08:57 pm »
I'm getting the same thing as well-see attached.

Offline SupSuper

  • Lazy Developer
  • Administrator
  • Commander
  • *****
  • Posts: 2165
    • View Profile
    • Email
Re: Cannot load battlescape saves
« Reply #6 on: December 27, 2016, 01:41:48 am »
Consider it a Christmas gift. ;)
Anyways it's fixed now, next time use the bug tracker so I actually get notified.