Cannot load battlescape saves

[BBHood217]

Ever since the latest nightly (2016-12-24), I've been unable to load any battlescape saves; it always crashes with a segmentation error whenever I try.  This happens both with mods (all I run is Area 51, though) and without mods.

[Hobbes]

Just checked and this issue happens even without any mods enabled, as I got the same error when tryin to load a save.

[Solarius Scorch]

Maybe it's an anti-save-scumming feature?

[hellrazor]

Line 508 and 509 in SaveBattleGame have the wrong scope.
They should be handled in the above "if", like in the old version.
This leads to the fact that the YAML node pointer is empty.
The pointer should only be emptied if there no mapsize bigger 0, indicating a battlescape save.

If this is right i do not know but _nodes.clear(), was before only called in the if statement.
Same goes for _mapDataSets.clear();

Edit: the forloop one line 504 also has wrong scope, being outside the above if.

[Hobbes]

Maybe it's an anti-save-scumming feature?

Why stop there?

*Bluescreen*

"You have savescummed for the last time. Formatting C:\ has just begun. Have a nice day"

[SIMON BAILIE]

I'm getting the same thing as well-see attached.

[SupSuper]

Consider it a Christmas gift.
Anyways it's fixed now, next time use the bug tracker so I actually get notified.