Author Topic: [SOLDIERS] Celebrate Diversity: more nationalities and names  (Read 6674 times)

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 4416
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #15 on: May 21, 2017, 10:26:14 am »
I've noticed soldier with swedish flag and spanish names or japanese flags and italian names.
Somewhere the ruleset is off by 1, I've looked at it but was unable to find any error.

Not a big problem, since I can change the flag by clicking on it.

Works fine for me, you must have another mod which adds more nationalities and messes up the order.

The only issue I see is wrong transparency on the belgian flag.

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • *****
  • Posts: 7979
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #16 on: May 21, 2017, 12:25:36 pm »
Thanks for reporting, I uploaded a fixed version.

EDIT: Now the fixed version is also updated in the first post.
« Last Edit: May 21, 2017, 06:40:09 pm by Solarius Scorch »

Offline FastForward

  • Squaddie
  • *
  • Posts: 20
    • View Profile
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #17 on: May 21, 2017, 09:34:26 pm »
Well, no.
Deleted Celebrate diversity 1.1 and replaced with 1.1b
Disabled all the mods, clean vanilla game: OXC Extended 3.7a+
Start new game and hiring people.

I still get some nationalities off by 1
But it's random, sometime I get Italian names with Italian flag, sometime I get Italian names with Japanese flag
The problem seem to be in the code, not in the mod.

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 4416
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #18 on: May 21, 2017, 09:35:42 pm »
Can you upload the save?

Offline FastForward

  • Squaddie
  • *
  • Posts: 20
    • View Profile
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #19 on: May 21, 2017, 09:54:54 pm »
OK, I started a new game, in the 8 initial soldiers I got Ivan Diaz, Swedish flag and Spanish name
I checked, no Ivan and no Diaz in swedish.nam

edit: hired other 22 soldiers and some other odd nationalities appeared
« Last Edit: May 21, 2017, 10:06:04 pm by FastForward »

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 4416
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #20 on: May 21, 2017, 10:22:04 pm »
What is the primary language of your operating system (Windows)?
And also regional settings if they are different.

Also, I am attaching a modified version of the mod 1.1c... can you please try that? On a new game... better or even worse?
« Last Edit: May 21, 2017, 10:27:03 pm by Meridian »

Offline FastForward

  • Squaddie
  • *
  • Posts: 20
    • View Profile
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #21 on: May 21, 2017, 11:03:19 pm »
Good, celebrate diversity 1.1c seem to work fine  ;D
I just tried 10 new games, 30 soldiers each, I have not spotted anything wrong in the nationalities.
Whatever you have modified in the ruleset, seem to have resolved the problem.

As for my system, it's a bit of a mess. The PC has spanish keyboard layout (purchased in Argentina), Windows is installed in English-US language and many programs are in Italian.
If this was the problem, I'm sorry for the waste of time I've caused to you.  :-[

Edit: now I see what have you done.
You prefixed each soldier name file with a number to be sure they are in the correct order.
Very strange, the are listed in the correct order in my explorer window.
It has to do with some internal windows libraries about alphabetical order.
Again sorry for the waste, you sure have better things to do.
Thank you Meridian.
« Last Edit: May 21, 2017, 11:35:16 pm by FastForward »

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 4416
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #22 on: May 21, 2017, 11:19:08 pm »
Well, it doesn't work for me... I got many soldiers without flags.

But I am attaching version 1.2 which should really work for all.

There were 2 problems:

1. sorting problem ... name files are read alphabetically, however that means different things in different languages (for example English "ch" comes after "c", but in Slovak "ch" comes after "h")

I solved this by adding numeric prefix to *.nam files

2. same directory problem ... the mods should NOT use the same directory for soldier names as vanilla, otherwise both will be used and the "delete" command will not have any effect... it will delete but then both file sets will be re-read again

I solved this by renaming the "SoldierNames" directory in the mod to "CelebrateDiversity" and amending ruleset accordingly
« Last Edit: May 21, 2017, 11:20:54 pm by Meridian »

Offline FastForward

  • Squaddie
  • *
  • Posts: 20
    • View Profile
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #23 on: May 22, 2017, 12:13:06 am »
I just tried v1.2
10 new game / 300 soldiers
It work flawlessly for what I can tell, no discrepancies found

Again, thank you Meridian.

Offline The_Atomik_Punk!

  • Squaddie
  • *
  • Posts: 24
  • Nobody rules these streets at night but me!!!
    • View Profile
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #24 on: June 06, 2017, 11:23:56 pm »
I really like the aim of this mod; it'll really help create an atmosphere of a global resistance to the alien menace.

Related to that, evidently from the screenshot listing the nationalities, there appear to be no Arab nations, which is a big omission. Syria, Jordan, and Egypt in particular, would be sensible inclusions for military soldiers involved in the X-Com project.

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • *****
  • Posts: 7979
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #25 on: June 06, 2017, 11:44:43 pm »
True, there are no Arab nation at the moment, despite Turkey, Israel and Iran being in the mod.

What can I say? I'll do it when I get there! ;)

Online Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 4416
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #26 on: June 07, 2017, 12:10:45 am »
The listing is incomplete, starts at 6.
Arabic.nam is definitely in there, even in vanilla I think.

It has Egyptian flag assigned.

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • *****
  • Posts: 7979
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #27 on: June 07, 2017, 12:13:44 am »
The listing is incomplete, starts at 6.
Arabic.nam is definitely in there, even in vanilla I think.

It has Egyptian flag assigned.

Yeah... I mean to fix it at some point.
(Good enough for vanilla doesn't make it good enough.)

Offline Dwarmin

  • Squaddie
  • *
  • Posts: 46
  • Smoke grenades saved the Earth
    • View Profile
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #28 on: November 08, 2017, 01:01:49 am »
Edit: Hmm, I downloaded xcom files and it seems to work now  ::)
« Last Edit: November 08, 2017, 01:46:03 am by Dwarmin »

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • *****
  • Posts: 7979
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: [SOLDIERS] Celebrate Diversity: more nationalities and names
« Reply #29 on: November 08, 2017, 08:58:41 am »
Edit: Hmm, I downloaded xcom files and it seems to work now  ::)

X-Com Files has this built in.