Sell / Sack menu

[StarkMad]

Or make them similar to time buttons on geoscape - they have clicked state.

Good idea. I'll look at how it is done in the geoscape and update the sell menu.

[StarkMad]

Here is the second version. I used the same approach for the buttons as the clock buttons in geoscape so as to make the sell/sack menu more consistent with the other UIs. I also added the 'Space Used' but it is a static value. It shows you the amount of storage space in use at the moment you entered the sell/sack menu. The patch file is now generated by git per the projects coding standards.

[moriarty]

looking good

perhaps replace 41:50 by 41/50 ?

oh, btw, will this work for over-filled storage? you know, like when a skyranger returns a lot of stuff to an already full base and the storage would be 62/50 ?

[Daiky]

the 41:50 notation is probably done because it's consistent with the base information screen

[moriarty]

oops again, right. well, I would like x/y better, but in this case I'd like to withdraw my suggestion in order to stay consistent

[michal]

So now we're waiting for SupSuper (or Daiky?) to merge it

[StarkMad]

the 41:50 notation is probably done because it's consistent with the base information screen

Yes, and because it was just a copy paste from BaseInfoState.

Here is an updated version that has the space used by each type of item. The last requested feature maybe a tough one. I'll have to think about how to do the

   'Space Used >   41 (+7) : 50'

[StarkMad]

This one should show you the overall change to space used. You need v0.2 + v0.3 + v0.4 since I'm not familiar enough with GIT to make it combine all the patches together.

[michal]

Good work

Here's another idea. All this texts have blue color. I wonder that maybe it would be worth to try to use different colors? For example for : "Value of sales", "Funds", "Space used". Also maybe different colors for value and space column?

I'm not sure if it's possible now in OpenXcom engine (pallete limitations?). But maybe that way, OpenXcom gui could be made more interesting than original one

What do you guys think? One color to rule them all, or couple of colors?

[Volutar]

Totally agreed. Having whole windows elements in one color is a bad idea. Like we have monochrome displays.

1. Ammo and item colors should differ (there are already examples).
2. Table heading should have more neutral color.
... Textual content have to be colored anyways, and not only for this window! Probably columns better to be having different colors,
N. Quantity/Sall/Sack columns as other numeric fields should get right alignment, and "^v" buttons visually have to be between them (for the moment they are closer to left column)

[moriarty]

N. Quantity/Sall/Sack columns as other numeric fields should get right alignment, and "^v" buttons visually have to be between them (for the moment they are closer to left column)

agreed. considering that "^" and "v" change the number to be sold (which is in the right column), they should be closer to that one. right now it might be confusing.

about adding colors: yes, this might make some things a bit more clear. but please don't turn it into angry fruit salad, the almost-monochrome interface does fit the militaristic setting of the game.


EDIT: is this still a mod, or will it find its way into the main branch? even before V1.0? just asking...

[Daiky]

So now we're waiting for SupSuper (or Daiky?) to merge it

I'll leave it to SupSuper

[pmprog]

Yes, and because it was just a copy paste from BaseInfoState.

Looks good, but could we do something about making capitalisation consistant though? And maybe add the > arrow after space in the top section to be consistant with funds?

 Cheers

[StarkMad]

I found a way to squash all of my commits into one so that I can have one patch to rule them all  . Changes in this version include:

 - Changed capitalization on 'Items' and 'Quantity' column headers to make it more consistent.
 - Moved Up/Down arrows a little to the right.
 - Made the text lists a different color so that the menu wasn't monochromatic.

[Amunak]

I found a way to squash all of my commits into one so that I can have one patch to rule them all  . Changes in this version include:

 - Changed capitalization on 'Items' and 'Quantity' column headers to make it more consistent.
 - Moved Up/Down arrows a little to the right.
 - Made the text lists a different color so that the menu wasn't monochromatic.

Nice patch, but I don't really like the green color. Is it really necessary to make it non-monochromatic? This definetly doesn't fit the game style.