[Documentation] Mixing and Matching Terrain with MapScripts!

[ohartenstein23]

Yes, I plan on having default handling that would make it ignore the terrain: definition for normal maps or bad definitions.

Did the log print a message like "Map generator encountered an error: invalid terrain for adding block from alternate terrain." for the crash?  I put in that error when the command is given the name of a terrain that doesn't exist, or doesn't load a terrain... I think I'll have it load the normal terrain when none is defined.

Edit:  How did you use the command?  Would you mind posting the ruleset you used to try it?

More edit:  For moving the alternate terrain handling into addBlock/fillArea, I would have the code check if there's a valid definition of "terrain:" in the command, and load the map from that if there is.  If there is no definition, or you put "terrain: default" in the ruleset, it pulls the map blocks from the same terrain as the rest of the map.

[Yankes]

Yes, I plan on having default handling that would make it ignore the terrain: definition for normal maps or bad definitions.

Did the log print a message like "Map generator encountered an error: invalid terrain for adding block from alternate terrain." for the crash?  I put in that error when the command is given the name of a terrain that doesn't exist, or doesn't load a terrain... I think I'll have it load the normal terrain when none is defined.

Edit:  How did you use the command?  Would you mind posting the ruleset you used to try it?

More edit:  For moving the alternate terrain handling into addBlock/fillArea, I would have the code check if there's a valid definition of "terrain:" in the command, and load the map from that if there is.  If there is no definition, or you put "terrain: default" in the ruleset, it pulls the map blocks from the same terrain as the rest of the map.

Other way around, I not ask you to handle default values or invalid data but to define new rulesets in way that OXC will still run. Of corse it not possible to always do this, but at least most typical cases should work.

Exception that stop loading of ruleses is "crash" because you can run game after that.

In case of your `addBlock`. If you add new property inside command then OXC will ignore if it have unique name. Consider something like that:

Code: [Select]

mapScripts:
  - type: CULTA
    commands:
      - #normal commands
    commandsTerrain:
      FOREST:
        - #commands for forest tileset
      DESERT:
        - #commands for desert tileset
When OXC loads this it will ignore `commandsTerrain` and use rest as if it was normal map script.

[ohartenstein23]

I'm not sure exactly what you mean.  Do you mean writing the rulesets such that loading a script with the new features into an older version just ignores the new stuff?  My idea is this:

Code: [Select]

mapScripts:
  - type: CULTA
    commands:
    - type: addBlock # this one is loaded normally
    - type: addBlock
      terrain: FOREST # adds a block from FOREST terrain when loaded by OXCE, otherwise it is ignored by OXC


[Yankes]

Yes, this is goal. Your example follow this too but there is danger that in this one command is big dependency between `terrain` and rest of values in it.
I do not do lot of stuff in map script to say how serve it will be, maybe small glitches or game simply refuse to load? I would like to avoid latter.

[ohartenstein23]

Without the terrain: in my (hypothetical) version of addBlock, it will simply load a map block from the regular terrain.  The addBlock command also isn't critical if it fails to place a map block, it simply moves to the next command in the list.  It won't cause a crash on map generation if terrain: is lacking, if that's what you're getting at.  It also shouldn't cause a glitched-out map, unless the ruleset for the extended version of the script you're writing heavily relies on the new commands, in which case it shouldn't be run in OXC in the first place.

[Yankes]

It also shouldn't cause a glitched-out map, unless the ruleset for the extended version of the script you're writing heavily relies on the new commands, in which case it shouldn't be run in OXC in the first place.

Some thing like thins is acceptable, as you can't make omelettes without breaking some eggs

I think you could recreate your commit as you probably change how it work.

[ohartenstein23]

I've reworked the map script commands to now include terrain: as an option for addBlock, addLine, addCraft, addUFO, and fillArea, rather than having separate commands.  See my first post for a link to the new windows executable and a link to my GitHub branch for this edit.

[Yankes]

I've reworked the map script commands to now include terrain: as an option for addBlock, addLine, addCraft, addUFO, and fillArea, rather than having separate commands.  See my first post for a link to the new windows executable and a link to my GitHub branch for this edit.

I find some merge bug in your last commit:
https://github.com/ohartenstein23/OpenXcom/commit/02143e9983e3803726ba761b5f584da4339f3235#diff-8817a4e728e82fd5808cc76936f5488eR3372
this probably should not be included in there.

[ohartenstein23]

Oh, yeah.  I took that out of my working version to prevent merge bugs, but then I did a rebase and forgot that was part of the commit. I'll fix it in a bit.

[Yankes]

https://github.com/ohartenstein23/OpenXcom/commit/02143e9983e3803726ba761b5f584da4339f3235#diff-7ad296375f2bbbfa7c2e5aa1bb532474L2034
this break probably should be still there.

[ps]
and what bug that previous line cause?

[ohartenstein23]

Oh, I didn't realize I deleted that break, I'll be adding it back in.  Thanks for checking it over!

The previous line doesn't cause a bug, I just changed to my local variable terrain which is what allows for the alternate terrain loading, it's equal to _terrain if you don't define an alternate in the ruleset.

Edit: Okay, fixed, amended to the commit, and pushed to GitHub: https://github.com/ohartenstein23/OpenXcom/commit/429382220bae8cab466ee5c1f9b62a9d996f5324

[Yankes]

Oh, I didn't realize I deleted that break, I'll be adding it back in.  Thanks for checking it over!

The previous line doesn't cause a bug, I just changed to my local variable terrain which is what allows for the alternate terrain loading, it's equal to _terrain if you don't define an alternate in the ruleset.

I maybe state is incorrectly, I was referring to `!unit->isOut() &&` in my question.

[ohartenstein23]

Oh sorry, that bug.  That was the 2x2 unit death bug that you fixed a few days back.

[davide]

+100

Your efforts could revive and enhance the openxcom modding scene breaking the MCD limits

Thank you very much

[ohartenstein23]

This code has now been included in both Yankes' OXCE and Meridian's OXCE+! Thanks guys!