Author Topic: Bugs, crashes, typos & bad taste  (Read 1098910 times)

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 8616
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #690 on: September 07, 2017, 06:04:56 pm »
As far as I can say, this was caused by some uninitialized/unreset variables across multiple turns in leeroy jenkins AI.

I've fixed that AI earlier and with the fixed version I can't reproduce this error anymore... so I recommend upgrading OXCE+ to newest version to avoid this bug.
I'm not absolutely 100% certain... but good enough to put this issue on ice.

Offline Kammerer

  • Colonel
  • ****
  • Posts: 141
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #691 on: September 16, 2017, 11:23:41 pm »
A new list of typos and bugs:

STR_BREAKDOWN_STR_INCINERATOR_CLIP - missing string.

The lists of cities in FMP and XCF slightly differ - in FMP there's New Orleans. Looks like it was added after the work on XCF had begun. Maybe this city should be added to XCF too.

Typos:

Quote
alien agression on the U.S. soil

Quote
fact on an asissination mission,

Quote
but is prone to mulfunction

Quote
Adding such standarized information

Quote
hopefully to the plece these

Quote
who may have already infiltrated the bulding

Quote
may have already infiltrated the bulding!

Quote
radio/casette player

Quote
A terryfying alien monster

Quote
or anything about the infrustructure

Quote
The core of Syndicate acivity relies

Quote
alien knowledge and techology at any cost

Quote
to create artifical proteins

Quote
excercise some sort of mental

Quote
capture the locals and imterrogate them

Quote
damaged our ventillation system

Quote
Right around the time of the Kiryu Kai termination
- Kiryu Kai is usually written with a hyphen

Quote
towards his collegues
- Oxford Dictionary states that it's an obsolete form. Maybe it should be replaced by "colleagues"

Quote
via the internet to radio
- the Internet should be written with the capital I

Quote
Some percieve this as proof

Quote
that government 'leaks' are disingenous

Quote
by an exteraterrestrial intelligence

Quote
ou can only take Consealable items

Quote
I sugggest we extract as much

Quote
giving it enourmous vitality

Quote
leading to better metabolical efficiency
- metabolic?

Quote
9 mm is a very reliable and acccurate weapon

Quote
position in a network of his breathren

Quote
It slightly inreases energy regeneration.

Quote
with other artefacts of alien technology

Quote
STR_AMESTERDAM: "Amesterdam"

Quote
STR_CHEYLABINSK: "Cheylabinsk"
- should be Chelyabinsk :).

Quote
STR_LILONGUE: "Lilongue"
- should be Lilongwe.

Quote
STR_BENGUI: "Bengui"
- should be Bangui.

Quote
STR_MOMBASSA: "Mombassa"
- should be Mombasa.

Quote
STR_DUSHAMBE: "Dushambe"
- should be Dushanbe.

Quote
Their masters exercise a limiteed degree

Quote
for its size, elerium core
- should be written with the capital E

Quote
The miniaturized elerium core
- the same as above

Quote
at piercing kevlar vests
- should be written with the capital K (Kevlar is a trademark)
       
Quote
Durathread is similar to kevlar
- the same as above

Quote
make it unsuitable for longe-range


And one more thing. Since coup de grâce is already written with a diacritic character, maybe they should be used where necessary? Just in case, here's a list of the strings that require diacritics:

Quote
work hard to maintain our raison d'etre
- raison d'être

Quote
STR_ASUNCION: "Asuncion"
- Asunción

Quote
STR_SAOPAULO: "Sao Paulo"
- São Paulo
« Last Edit: September 16, 2017, 11:32:07 pm by Kammerer »

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • ***
  • Posts: 11452
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: Bugs, crashes, typos & bad taste
« Reply #692 on: September 17, 2017, 01:23:26 am »
Thanks for all the details. I have fixed them all, except for kevlar - since I'm not referring to the company but to the product. It's like using a walkman and wearing adidas shoes, regardless of their manufacturer.

I agree adding diacritics is a good thing. I've already started.

Aaaaaaaand here's an update. Some texts are still missing, but at least you'll have something to work with.

Offline Kammerer

  • Colonel
  • ****
  • Posts: 141
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #693 on: September 17, 2017, 11:23:03 pm »
Some more typos (for v. 0.7.0):

Quote
allows us to order such equimpent from their factories
     
Quote
is directly related to the otherwordly
     
Quote
likely requires enviromental protection
     
Quote
distrubuted around the globe by UFOs
     
Quote
A terryfying alien monster is attacking this peaceful village
     
Quote
We should capture the locals and imterrogate them
     
Quote
that lead to places beyong Earth
     
Quote
She studied biochemistry in Zurich
     
Quote
Commmander! We have successfully implanted
     
Quote
we can expect extreme resisitance
     
Quote
Agricutural Flamer Acquisition
     
Quote
Agricutural Flamer
     
Quote
Or at least that's what it appears to be: that the world is full of its brethren


Since the mention about the Brainer was removed, it became unclear whose brethren was mentioned in the article.

STR_PETROPAVLOVSK: "Petropavlovsk" - there's a city in Kazakhstan and in Russia. But the Russian one is called Petropavlovsk-Kamchatsky: https://en.wikipedia.org/wiki/Petropavlovsk-Kamchatsky. Unfortunately, this name is too long, and I don't know if anything can be done in that case.

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • ***
  • Posts: 11452
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: Bugs, crashes, typos & bad taste
« Reply #694 on: September 18, 2017, 01:15:24 am »
Some more typos (for v. 0.7.0):

Wow! Thanks!                                                             

Since the mention about the Brainer was removed, it became unclear whose brethren was mentioned in the article.

I have just shortened it:

Quote
STR_HYBRID_NETWORK_UFOPEDIA: "It appears that our planet is not only infested with cults, but also infiltrated by agents bioengineered by aliens themselves, disguised as normal people and preparing the planet for some sort of... harvest? Well I can't say exactly how much truth there is in these tall tales, but we still have documents that contain information on this 'Hybrid Network' and I will track them down personally. I wonder how many types of Hybrids are out there and what they look like..."

STR_PETROPAVLOVSK: "Petropavlovsk" - there's a city in Kazakhstan and in Russia. But the Russian one is called Petropavlovsk-Kamchatsky: https://en.wikipedia.org/wiki/Petropavlovsk-Kamchatsky. Unfortunately, this name is too long, and I don't know if anything can be done in that case.

Well, if you have a better idea, please let me know.

Offline Kammerer

  • Colonel
  • ****
  • Posts: 141
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #695 on: September 18, 2017, 05:46:02 pm »
Well, if you have a better idea, please let me know.

Petropavl.-Kamchatsky fits well and is alright as an abbreviation :).

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • ***
  • Posts: 11452
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: Bugs, crashes, typos & bad taste
« Reply #696 on: September 18, 2017, 08:36:52 pm »
Petropavl.-Kamchatsky fits well and is alright as an abbreviation :).

Fair enough. :)

And another update... Sorry if it's too often, please work on it whenever it suits you.

Offline Kammerer

  • Colonel
  • ****
  • Posts: 141
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #697 on: September 18, 2017, 10:48:47 pm »
No problem :). I'm already working on it.

A couple more bugs:

STR_BIOLOGICAL_WARFARE_PREQ - missing string

Quote
for a long time after the revolution

Here the word Revolution should be written with the capital letter.

Typos:

Quote
on any biological matterials of interest

Quote
takes it down with powerful electrical discharches
« Last Edit: September 20, 2017, 09:57:16 pm by Kammerer »

Offline tkzv

  • Commander
  • *****
  • Posts: 583
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #698 on: September 20, 2017, 11:16:03 pm »
Some fences in the farm terrain are passable. Agents cross the fence as if it isn't there.
Update: looks like the UL-DR fence on the cabbage patch is passable, but all others work correctly.


An unrelated question: the standard "Gun Melee" mod doesn't work with X-Com Files. Is it deliberate or not?
« Last Edit: September 20, 2017, 11:23:23 pm by tkzv »

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • ***
  • Posts: 11452
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: Bugs, crashes, typos & bad taste
« Reply #699 on: September 21, 2017, 02:34:53 pm »
Hmm, I fixed this fence, but may have missed another instance. I will check.

As for the gun melee, I don't know how it works... I suspect it relies on exact definitions of every weapon, which means it will only works with vanilla weapons.

Offline tkzv

  • Commander
  • *****
  • Posts: 583
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #700 on: September 21, 2017, 06:13:20 pm »
As for the gun melee, I don't know how it works... I suspect it relies on exact definitions of every weapon, which means it will only works with vanilla weapons.
It goes like this:

items:
  - type: STR_PISTOL
    meleePower: 20
    tuMelee: 15
    accuracyMelee: 100
  - type: STR_RIFLE
    meleePower: 50
    tuMelee: 40
    accuracyMelee: 100


Yes, "meleePower", "tuMelee" and "accuracyMelee" for every weapon.

If I make a similar file for your mod, will you accept it?

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • ***
  • Posts: 11452
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: Bugs, crashes, typos & bad taste
« Reply #701 on: September 21, 2017, 07:04:56 pm »
If I make a similar file for your mod, will you accept it?

If you mean "incorporate it into XCF", then probably not, as it's quite balance changing and I'm not sure it wouldn't turn out silly in the end.

But if you want to make a separate mod, then you have not only my permission, but also blessing! :)

Offline tkzv

  • Commander
  • *****
  • Posts: 583
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #702 on: September 23, 2017, 03:10:12 am »
If you mean "incorporate it into XCF", then probably not, as it's quite balance changing and I'm not sure it wouldn't turn out silly in the end.

But if you want to make a separate mod, then you have not only my permission, but also blessing! :)
https://openxcom.org/forum/index.php/topic,5719.0.html

I made a Perl script that creates a melee mod for any other mod. The mod for XCF is attached.

For some reason the damage is lethal rather than stunning.

Offline tkzv

  • Commander
  • *****
  • Posts: 583
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #703 on: September 23, 2017, 09:03:13 pm »
I think there's an error in items_XCOMFILES.rul. The entry STR_ALIEN_LASER_CANNON_CLIP does not have STR_CLIPS in "categories".

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • ***
  • Posts: 11452
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: Bugs, crashes, typos & bad taste
« Reply #704 on: September 23, 2017, 09:42:35 pm »
I think there's an error in items_XCOMFILES.rul. The entry STR_ALIEN_LASER_CANNON_CLIP does not have STR_CLIPS in "categories".

Thanks, good catch.