Author Topic: Bugs, crashes, typos & bad taste  (Read 1071569 times)

Offline Stoddard

  • Colonel
  • ****
  • Posts: 485
  • in a fey mood
    • View Profile
    • Linux builds & stuff
Re: Bugs, crashes, typos & bad taste
« Reply #555 on: July 10, 2017, 01:57:27 am »
I fixed the builds download site being inaccessible, sorry for that.

As for the yaml bug, my builds shouldn't have it, yaml-cpp version used is 0.5.3.

tzkv, it seems like you had problems with some other build, and have no problems with lxnt.wtf build, is that correct?
What was that some other build?

Offline tkzv

  • Commander
  • *****
  • Posts: 583
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #556 on: July 10, 2017, 02:55:27 pm »
tzkv, it seems like you had problems with some other build, and have no problems with lxnt.wtf build, is that correct?
What was that some other build?
I compiled OXCE+ on my system (Gentoo Linux AMD64). Just ./configure then make or cmake then make. Electric clubs did not work (no "Hit" in the list of actions), but I did not look for the reason, because I found the binaries.

And this "no problems" is relative :) I keep getting segfaults from explosions and something else when enemies panic, but other people can't reproduce them. Also lxnt.wtf build keeps creating savefiles with unquoted NULL.


Unrelated crash: an agent with 12 TU, a Desert Eagle and a flashlight tries to shoot a passing enemy with a flashlight. (Workaround: spent all TUs or drop the flashlight.) It stopped reproducing when the enemy suddenly changed his route.
« Last Edit: July 10, 2017, 02:58:26 pm by tkzv »

Offline Stoddard

  • Colonel
  • ****
  • Posts: 485
  • in a fey mood
    • View Profile
    • Linux builds & stuff
Re: Bugs, crashes, typos & bad taste
« Reply #557 on: July 10, 2017, 07:46:48 pm »
I compiled OXCE+ on my system (Gentoo Linux AMD64). Just ./configure then make or cmake then make. Electric clubs did not work (no "Hit" in the list of actions), but I did not look for the reason, because I found the binaries.

I see. Though that should've worked no worse than lxnt.wtf builds if you have a recent-ish yaml-cpp on your system.

And this "no problems" is relative :) I keep getting segfaults from explosions and something else when enemies panic, but other people can't reproduce them.

Some logs/backtraces can help. Here's a not stripped build: Extended+-3.8b-7369651-2017-07-06-jessie-x86_64-debug.7z

Also lxnt.wtf build keeps creating savefiles with unquoted NULL.

This is most strange. Which build (git commit) do you use?



Offline tkzv

  • Commander
  • *****
  • Posts: 583
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #558 on: July 10, 2017, 09:38:52 pm »
I see. Though that should've worked no worse than lxnt.wtf builds if you have a recent-ish yaml-cpp on your system.
dev-cpp/yaml-cpp-0.5.3, configured with default options plus -DBUILD_SHARED_LIBS=ON . The bug with unquoted NULL should be fixed, unless your binaries are statically linked, right?

Some logs/backtraces can help. Here's a not stripped build: Extended+-3.8b-7369651-2017-07-06-jessie-x86_64-debug.7z
Thanks. I'll try it.

Update: where does it write the extra log? The ~/.local/share/openxcom/openxcom.log is no bigger than usual. Or do I need to use some command line key or set an environment parameter?

This is most strange. Which build (git commit) do you use?
Latest at that point. 84b16420bc3583613cb14c521ff334870de213c0
« Last Edit: July 10, 2017, 09:44:02 pm by tkzv »

Offline Stoddard

  • Colonel
  • ****
  • Posts: 485
  • in a fey mood
    • View Profile
    • Linux builds & stuff
Re: Bugs, crashes, typos & bad taste
« Reply #559 on: July 11, 2017, 12:53:11 am »
dev-cpp/yaml-cpp-0.5.3, configured with default options plus -DBUILD_SHARED_LIBS=ON . The bug with unquoted NULL should be fixed, unless your binaries are statically linked, right?

My builds are statically linked with 0.5.3 exactly to avoid the yaml-cpp version mess. I can't understand how this ancient bug suddenly cropped up. As you also have 0.5.3, your self-built builds should have worked modulo yaml-unrelated bugs.

Update: where does it write the extra log? The ~/.local/share/openxcom/openxcom.log is no bigger than usual. Or do I need to use some command line key or set an environment parameter?

It doesn't write any extra log. The backtrace should be in the log, or you can just run it under gdb.

The log can also end up in the "user" directory, alongside the openxcom.cfg or the  savefiles directories.
It's faster to do a find / -name openxcom.log -ls than to try and understand the path handling rat's nest.
F.ex. I still can't fathom why it sometimes uses config from .local while writing the rest under the user directory alongside the executable.

Latest at that point. 84b16420bc3583613cb14c521ff334870de213c0

Hm. That's quite old. Ah, I see, you use Extended, not ExtendedPlus.
The not-stripped version for that is here: 3.8a-84b1642-2017-06-12-jessie-x86_64-debug.7z

Still, 0.5.3 was used for the lxnt.wtf builds from the start.

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 8596
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #560 on: July 11, 2017, 12:58:20 pm »
I've encountered another problem. When something explodes, the game may crash with a message: To reproduce:
Load the attached "tank explodes.sav" — agent "Darya Orlova" is active, 1 enemy is visible — the tank.
Shoot the tank with a shotgun. — 1 hit is usually enough, when the flame mostly disappears, the game crashes.

No crash when I destroy the tank with a grenade launcher. Somehow, grenade explosions don't cause problems.

This crash is the same as this one: https://openxcom.org/forum/index.php/topic,2915.msg85023.html#msg85023

Is already fixed and will be available in the next version.

Offline tkzv

  • Commander
  • *****
  • Posts: 583
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #561 on: July 12, 2017, 10:13:30 pm »
Exception in the Black Moon mission. Load the attached "Black moon-1.sav" and press "End turn".
The message is: "Unsupported action (val: 12) for item STR_WERECAT_MIND_CONTROL_WEAPON"

Offline Solarius Scorch

  • Global Moderator
  • Commander
  • ***
  • Posts: 11408
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: Bugs, crashes, typos & bad taste
« Reply #562 on: July 12, 2017, 10:22:35 pm »
Exception in the Black Moon mission. Load the attached "Black moon-1.sav" and press "End turn".
The message is: "Unsupported action (val: 12) for item STR_WERECAT_MIND_CONTROL_WEAPON"

Try the new version from today, perhaps it's fixed.

Offline tkzv

  • Commander
  • *****
  • Posts: 583
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #563 on: July 12, 2017, 10:47:46 pm »
Thanks. But no, this one wasn't fixed.

Unrelated bug: no name for hybrid convoy mission, it just displays as STR_SMALL_GROUND_CONVOY_HYBRID

I had a similar problem for something with Deep Ones, but forgot to write it down.
« Last Edit: July 12, 2017, 10:54:41 pm by tkzv »

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 8596
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #564 on: July 12, 2017, 11:03:48 pm »
Thanks. But no, this one wasn't fixed.

Yes, it was fixed.

In version 2017-07-11, I get a crash, in version 2017-07-12 I don''t get the crash anymore.

And the message you're getting was completely removed:
https://github.com/MeridianOXC/OpenXcom/commit/4e687b62c41da642f9b927f4b3458deda5663127#diff-1cf37bc8ed3c3c099a1adaa6c70f0d0bL572

so looks like you don't have the latest version.

Offline tkzv

  • Commander
  • *****
  • Posts: 583
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #565 on: July 13, 2017, 04:11:10 am »
Yes, it was fixed.

In version 2017-07-11, I get a crash, in version 2017-07-12 I don''t get the crash anymore.

And the message you're getting was completely removed:
https://github.com/MeridianOXC/OpenXcom/commit/4e687b62c41da642f9b927f4b3458deda5663127#diff-1cf37bc8ed3c3c099a1adaa6c70f0d0bL572

so looks like you don't have the latest version.

I did not compile from git, I just took the new binary: https://lxnt.wtf/oxem/builds//ExtendedPlus/Extended+-3.8c-3de52f1-2017-07-11-xenial-x86_64-debug.7z The date inside is 2017-07-10.

What am I doing wrong? The files I compile behave like vanilla version — a lot of things are missing, like "Hit" command for melee weapons or night vision.

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 8596
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #566 on: July 13, 2017, 09:44:16 am »
What am I doing wrong? The files I compile behave like vanilla version — a lot of things are missing, like "Hit" command for melee weapons or night vision.

Which branch do you compile?
Because master branch is vanilla... you need "oxce3.5-plus-proto"

Offline tkzv

  • Commander
  • *****
  • Posts: 583
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #567 on: July 15, 2017, 01:36:25 pm »
Which branch do you compile?
Because master branch is vanilla... you need "oxce3.5-plus-proto"
Thanks!

To answer my question: I was working with git the way I work with SVN :)

Offline Kammerer

  • Colonel
  • ****
  • Posts: 141
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #568 on: July 15, 2017, 02:52:13 pm »
Some more bugs found in the new version.

Quote
a larg swarm seeking shelter

Missing strings:
STR_TERROR_2_MISSION
STR_TERROR_2_MISSION_SECTOID
STR_TERROR_2_MISSION_MUTON
MALE_CIVILIAN (I have already reported this string but it seemed to me this problem has been fixed, and now it's back).

The article about the Cruiser UFO doesn't show up in the UFOpedia.

The Chryssalid weapons overlap its body. See the screenshot.

Offline mumble

  • Colonel
  • ****
  • Posts: 338
    • View Profile
Re: Bugs, crashes, typos & bad taste
« Reply #569 on: July 16, 2017, 12:04:25 am »
It seems the standard shotgun is objectively better than the blackops shotgun, for some reason

Celatoid, and chysalid have their bio / autopsy info jumbled (list order : chrisalid, celatoid, chrisalid autopsy, celatoid autopsy)