[CODE SUBMISSION] Grenade chaining

[Tesseract]

Hi folks,
discovering OXC recently, I'm having a blast playing skirmishes all day long! So I wanted to thank our fine coding crew and mod developers for outstanding job plus special cheers to Meridian and Ivan Dogovich for their entertaining LPs. 

Anyway, to the point. I was unhappy with the way how explosions destroy things around, in particular situations where Mr. Chrysalid rushes my early tech squad and I can't throw at him more than one grenade in one turn. I know there are solutions - use instant gredanes or the TFTD way, making them undestroyable - but both have drawbacks and TFTD way needs mod tweaking.
My proposed way to deal with this is having primed explosives explode in situations where they would vanish otherwise. As the source is well structured, I took a crack at coding it myself. As far as I can tell, it seems to work fine, but I'd still recommend review from someone more familiar with the source (main change is about 4 lines of code long, new related advanced option added). In particular, position of explosion currently doesn't use any offsets, I'm not sure if at least proxy grenades shouldn't explode little higher.

Hope you guys find it useful, I'm off to create some large scale proxy + heavy explosive minefield.
PS. sorry if placed in wrong subforum!

[Yankes]

In my extended version all grenades explode at "once". That mean one explosion can't stop another one form same turn.
Overall that type of changes should go to mod forum. Because it change how basic game work.

[Solarius Scorch]

Oh noez! It's X-Com: Apocalypse all over again! D:

[Meridian]

...plus special cheers to Meridian and Ivan Dogovich for their entertaining LPs. 

Yaaay, we're famous! ;-)
But only until Friday... when we become infamous... #ThreeDaysLeft

[Tesseract]

I hadn't checked Extended until now, fine solution there. Yet still, my hunger for remote proxy detonation and chained explosions consistent with Elerium sources blowing up wouldn't be satisfied by that.

Also apologies again, not only I misplaced this thread but only now I spotted the "How to contribute code" thread!  I guess I was too enthusiastic, but I posted diffs, so it's hopefully not a big deal.

Hmm, but if Yankes is right and this change should be considered mod - not a tweak like instant grenades - I'm worried if WarBoy/SupSuper will be interested in this regardless if it's good or not.
Yankes, would you consider adding it to Extended if that would be the case? I can still see some uses for this.

[Solarius Scorch]

For now I've requested this thread to be moved to the appropriate subforum, so it'll be moved if necessary.

BTW Meridian, sorry but why exactly are you going to be infamous...?

[Meridian]

BTW Meridian, sorry but why exactly are you going to be infamous...?

Just teasing you
Friday's episode will be... unlike others.

[Yankes]

I hadn't checked Extended until now, fine solution there. Yet still, my hunger for remote proxy detonation and chained explosions consistent with Elerium sources blowing up wouldn't be satisfied by that.

Also apologies again, not only I misplaced this thread but only now I spotted the "How to contribute code" thread!  I guess I was too enthusiastic, but I posted diffs, so it's hopefully not a big deal.

Hmm, but if Yankes is right and this change should be considered mod - not a tweak like instant grenades - I'm worried if WarBoy/SupSuper will be interested in this regardless if it's good or not.
Yankes, would you consider adding it to Extended if that would be the case? I can still see some uses for this.

After looking at your diffs I see you did it in proper way (as toggled option), this will increase chance of accepting it by WarBoy/SupSuper.

As for my version. In current state I will not accept it, but as overall idea I could be added. Primary thing that need be change is remove global option and give it per item basic e.g. RuleItem class will have new field that will control this behavior. This should work for any item not only grenades (ammo should explode too).

And for proper way of contribution to source we use https://github.com/SupSuper/OpenXcom/pulls

[Bloax]

Just teasing you
Friday's episode will be... unlike others.

Even worse than a super secret mission Meridian™ cliffhanger?

[Solarius Scorch]

As for my version. In current state I will not accept it, but as overall idea I could be added. Primary thing that need be change is remove global option and give it per item basic e.g. RuleItem class will have new field that will control this behavior. This should work for any item not only grenades (ammo should explode too).

But that'd require adding yet another line to the item, namely power. How powerfully does a rifle clip explode? Or a medikit (because someone crazy enough will want exploding medikits)?

[Meridian]

Even worse than a super secret mission Meridian™ cliffhanger?

My mouth is shut. I haven't said anything; I was not here. You can torture me all you want, I won't reveal XCOM classified information.

Lol, so many references ;-) I'm laughing at my own jokes... that's not healthy... I'll stop now. Post or cancel? <clicks on Post> Dang it... now everyone knows I'm slowly going crazy.

Edit: sorry Tesseract for this terrible thread jack... this was my last post, I promise 

[Yankes]

But that'd require adding yet another line to the item, namely power. How powerfully does a rifle clip explode? Or a medikit (because someone crazy enough will want exploding medikits)?

After looking on code I see only one simple way of adding this. One field with true/false and work only with explosive weapons/items. This mean It could work for medikit (because it don't use power/radius) but not for laser rifles (because "explosion" will be laser hit at ground).

[Solarius Scorch]

After looking on code I see only one simple way of adding this. One field with true/false and work only with explosive weapons/items. This mean It could work for medikit (because it don't use power/radius) but not for laser rifles (because "explosion" will be laser hit at ground).

I don't understand; how much damage would a Medikit do? It doesn't have any damage values.

[Yankes]

Item definition have. Its not used but game still have it. Every item in game is exactly same, only battle type change what is used.
When you add "power" to medikit it will be loaded from ruleset but will not be used. When I would add new behavior I can exploit it by treating medikit item as grenade when I try explode it. This is very similar to how corpse explosion work. You add to corpse item power and radius. After that in correct circumstances you can create explosion after unit die.

[Dioxine]

On that note - would you consider enabling Ammo use for all items in Extended? The primary objective would be perishable medikits, which make much more sense than eternal ones. For the Medkits, I'm seeing as every use (stim, heal, painkiller) would reduce ammo by 1. For psi-type items, every usage. Naturally ammo clips should be an option too.