aliens

Author Topic: Maintenance order change  (Read 1829 times)

Offline bslaveboy

  • Sergeant
  • **
  • Posts: 12
    • View Profile
Maintenance order change
« on: November 07, 2014, 04:02:41 pm »
Hi All

Arthanor asked me to take a look at changing the maintenance order to Refuel -> Rearm -> Repair so that those who select the ability to launch craft immediately don't have to wait for them to be fully repaired before scrambling them.

This is my attempt at accomplishing that. I have set it so that the default order is used (Repair, Rearm, Refuel) unless you select the launch immediately option, in which case Arthanor's suggested order is used.

Currently, this branch includes my maintenance time listed in the intercept window as some of the code I've used to get this done is common and I haven't separated or cleaned it up yet (or even tested it).

I'm not sure when I'm going to get a chance to work more on this so I figured I'd throw it out there for others to try.

Comments suggestions etc all welcome.

I created a branch called change_maintenance_order  here:
https://github.com/bslaveboy/OpenXcom.git

bslaveboy

Offline Arthanor

  • Commander
  • *****
  • Posts: 2490
  • XCom Armoury Quartermaster
    • View Profile
Re: Maintenance order change
« Reply #1 on: November 07, 2014, 06:14:14 pm »
Woot! :D Now I have to compile OpenXCom again :'(

I hope your work makes it in the master branch!

Offline davide

  • Commander
  • *****
  • Posts: 548
    • View Profile
Re: Maintenance order change
« Reply #2 on: November 08, 2014, 09:50:59 am »
I think that it will have more possibility to be accept
if this behaviour will be loaded by ruleset

Default have to be the vanilla order, by ruleset it could be resort

Offline TaxxiDriver

  • Colonel
  • ****
  • Posts: 100
    • View Profile
Re: Maintenance order change
« Reply #3 on: November 08, 2014, 01:32:39 pm »
I'm really looking forward this change to be ultimately become a part of the official build soon. I'm already being sic'n tired of alternating the Geoscape and the base. I just have to say you've done a wonderful job, really  8)

Default have to be the vanilla order, by ruleset it could be resort

If it is not difficult, I also think it is a good option. I mean, at first I thought first refuelling was a cool idea, then I imagined what the engineers would say about that:



Commander: Damn, refuel the craft first! Don't you see those ******* UFOs out there?

Engineers: Sir, the craft has been severly damaged. We really canno...

Commander: Holy Crab!!! We anyway have avalanches so they are just cookies floating in the sky! Shut up and prepare the next flight within an hour.

Engineers: But what if the craft malfunctions...

Commander: GOD DAMN no craft ever malfunctions in XCOM! If I see that craft still having a makeup next hour, then your head won't look pretty, GOT THAT?



O' well, anyway my point was that it would be great (if possible) if the order can be rearranged by using simple rulesets since players can have different point of views. I personally think just splitting the mod into two parts so that one can independently choose the order and the immediate launch option is just enough  :)