Research developement

[gchevallereau]

Hi,

Over the last weeks, I have tried to implement research in OpenXcom. It's now working and I would welcome feedback on it.

What's need to be done:
* Documentation(especially the Dependency/unlock parts).
* Minor bug : If no project can be listed when Clicking on New project, you will be back the base view.
* UI bug : Colours are wrong in the Project Setting State(and sometimes in the End Research State).
* Research cost : According to https://www.ufopaedia.org/index.php?title=Research_Technical_Details, Research cost have +-50% cost modifier. It should be to easy to add it.


I have also added a CMake build to OpenXcom. I have checked that it work on Linux and Windows(MinGW build). It should also work for Visual Studio.

You can get the code from my personal git repo here: https://gchevallereau.net/cgit/cgit.cgi/OpenXcom
Code is in the research_cmake branch. The cmake branch hold the CMake build system port.

[michal]

Wow

[SupSuper]

Wow

Seconded.

I'll be sure to have a look and give you some feedback after 0.3 is out. If you're looking to get it integrated into the main OpenXcom codebase, my only suggestion right now is to check the guidelines and make sure it meshes in well with the rest of the code.

[panther]

That's great! 
I did look a bit at the code, but couldn't find out how you manage to finish a research.
However, you can link this event to unlock certain articles in Ufopedia, by calling
Ufopaedia::releaseArticle(Game *game, std::string &article_id);

Or, to open the corresponding article state: Ufopaedia::open(...);
See Ufopaedia.h for details.

[gchevallereau]

Hi,

my only suggestion right now is to check the guidelines and make sure it meshes in well with the rest of the code

I have tried to follow the coding rules, but maybe I have missed something. I will check that. By the way, maybe it would be helpfull to have something like https://astyle.sourceforge.net/astyle.html to check this ?

I did look a bit at the code, but couldn't find out how you manage to finish a research.

It's in the GeoscapeState::time1Day function (https://gchevallereau.net/cgit/cgit.cgi/OpenXcom/tree/src/Geoscape/GeoscapeState.cpp?h=research_cmake#n751).

Or, to open the corresponding article state: Ufopaedia::open(...);

Already done : https://gchevallereau.net/cgit/cgit.cgi/OpenXcom/tree/src/Geoscape/EndResearchState.cpp?h=research_cmake#n84. But the openArticle is not yet implemented. By the way, I think that the std::string & should be a const one.

However, you can link this event to unlock certain articles in Ufopedia, by calling
Ufopaedia::releaseArticle(Game *game, std::string &article_id);

I will add this.

[michal]

So gchevallereau, now you will implement manufacture and geoscape for 0.4 will be almost ready?

[gchevallereau]

now you will implement manufacture

Well I was thinking to it. But it would be better to wait for feedback on the research as manufacture will depend on it.

[gchevallereau]

Hi,

A little update on the research branch. Here is the current status:
* Documentation(especially the Dependency/unlock parts). I have added doxygen documentation to most class. Not sure if it's enough
* Minor bug : If no project can be listed when Clicking on New project, you will be back the base view. FIXED
* UI bug : Colours are wrong in the Project Setting State(and sometimes in the End Research State).  Partially fixed. Colors are much more better now. But there still some little problems(assigned scientist, used space lab, available sicentist in the ResearchProjectState still have the wrong colors).
* Research cost : According to https://www.ufopaedia.org/index.php?title=Research_Technical_Details, Research cost have +-50% cost modifier. It should be to easy to add it. DONE

*

However, you can link this event to unlock certain articles in Ufopedia, by calling
Ufopaedia::releaseArticle(Game *game, std::string &article_id);

DONE

I reviewed most of the modification and try to make sure that it follow coding rules.

[Daiky]

Your code looks great. I noticed you use relative coordinates to position your UI and various variables for the numbers, instead of absolute coordinates and hardcoded numbers, that's good

[michal]

Your code looks great. I noticed you use relative coordinates to position your UI and various variables for the numbers, instead of absolute coordinates and hardcoded numbers, that's good

Let me guess - you're thinking about higher resolutions?

[Daiky]

Let me guess - you're thinking about higher resolutions?

You probably don't want to know what I'm thinking

[Daiky]

btw gchevallereau, will you be introducing to us eventually?
Also we don't know what your plans are, and you don't know what our plans are.  It's a bit an awkward situation to be honest. I'm already starting to get scared you will take away the fun parts of battlescape core development too :p

[gchevallereau]

btw gchevallereau, will you be introducing to us eventually?

Well, I'm french 30 years developer. I have discovered openxcom only 2 month ago. As I'm at the moment looking for a job, I have some time to spent on code.

Also we don't know what your plans are, and you don't know what our plans are.

You mean that the roadmap is not accurate ?
More seriously, I'm just looking at the research/manufacture code at the moment. Nothing more.

I'm already starting to get scared you will take away the fun parts of battlescape core development too :p

Don't worry  I promise I won't touch it.

[michal]

Since you're from europe too, maybe you could enter our irc channel ( details are here https://openxcom.org/forum/index.php?topic=63.0 ) ? SupSuper and Daiky are usually at evenings.

[SupSuper]

Also we don't know what your plans are, and you don't know what our plans are.

You mean that the roadmap is not accurate ?
More seriously, I'm just looking at the research/manufacture code at the moment. Nothing more.

Well we can have things planned out in our heads before they're coded. I feel like I've been demoted. j/k

Anyways I tried to clone your Git repository to have a better look at your code but I get this error:

"Cloning into D:\SupFiles\Visual Studio Projects\OpenXcom\research...
gchevallereau.net[0: 88.169.205.14]: errno=No error
fatal: unable to connect a socket (No error)"

Any ideas?