Author Topic: Showing Soldier stat increases after mission [patch - updated 08-12-2015]  (Read 11033 times)

Offline Roujin

  • Sergeant
  • **
  • Posts: 11
    • View Profile
This is my first post here, so hello everyone. :)
I'm a long time fan of the xcom series and have also been involved with some other open source projects like OpenTTD and CorsixTH (thanks for the plug in your recent news post ;)).

First off congratulations on your 1.0 release.
When I got the news of this, I just had to try it out, and ended up sinking a week into the game straight up. So addicting :D
At some point in the game I started being more interested in detail mechanics like how my soldiers gain stats. So I looked that up on the wiki and then thought that it would be nice to have a statistic at the end of a mission that shows which soldier(s) earned how many stat points.

So I figured I could just implement it myself, and contribute it, if you find it a good thing to add.

I added an additional button "STATS" to the debriefing screen, you can use that to toggle between the usual scores and a list of all soldiers that have earned stats, with exactly how many they earned per stat.
Since it is a bit problematic to fit all that data on the screen, I could not use the usual stat names "HEALTH", "STRENGTH" etc., but had to introduce abbreviations HP, STR, etc.
To help clarify what each of these means I made them display a tooltip with the full name if you hover over them.


Find attached a screenshot and the patch.

(edit Dec 08, 2015: rebased to current master)

« Last Edit: December 08, 2015, 05:06:22 pm by Roujin »

Online Solarius Scorch

  • Global Moderator
  • Commander
  • *****
  • Posts: 8842
  • WE MUST DISSENT
    • View Profile
    • Nocturmal Productions modding studio website
Re: Showing Soldier stat increases after mission
« Reply #1 on: June 28, 2014, 02:33:08 am »
It's a very nice idea. It works a bit similar in Xenonauts, and why not here?

Offline Aldorn

  • Commander
  • *****
  • Posts: 762
    • View Profile
Re: Showing Soldier stat increases after mission
« Reply #2 on: June 28, 2014, 05:53:05 am »
This would be a useful contribution  :)

What about the possibility to mod the stats improvement ? Could you have a look at it just to have an idea if it would be a lot of work ?

By "modding stats improvement", I mean be able to set the thresholds and resulting values
00-04 XP => +1 Stat
04-12 XP => +2 Stat
12-20 XP => +3 Stat
...
« Last Edit: June 28, 2014, 05:59:54 am by Aldorn »

Offline Roujin

  • Sergeant
  • **
  • Posts: 11
    • View Profile
Re: Showing Soldier stat increases after mission
« Reply #3 on: June 28, 2014, 02:49:21 pm »
Well, I did see the part of the code where the stat gains are calculated. To change that in code would be easy.
You are referring to linking this with the rulesets though, right? Being able to set some thresholds in a ruleset, that are then used in the stat gain calculation.
I don't have any idea about how these rulesets work yet, so I cannot estimate how easy or hard this is to do. ;)


Offline Aldorn

  • Commander
  • *****
  • Posts: 762
    • View Profile
Re: Showing Soldier stat increases after mission
« Reply #4 on: June 28, 2014, 02:53:50 pm »
Well, I did see the part of the code where the stat gains are calculated. To change that in code would be easy.
Good news

You are referring to linking this with the rulesets though, right? Being able to set some thresholds in a ruleset, that are then used in the stat gain calculation.
Right ! In fact to be able to slow progression / make advancement more rare and precious...

I don't have any idea about how these rulesets work yet, so I cannot estimate how easy or hard this is to do. ;)
I just wanted to have an idea, thanks mate

Offline Roujin

  • Sergeant
  • **
  • Posts: 11
    • View Profile
Re: Showing Soldier stat increases after mission
« Reply #5 on: June 28, 2014, 05:00:31 pm »
I have now investigated that topic for a bit and I would say that it would not be very difficult, code-wise (also the part about exposing it to the ruleset).

The more challenging feat would be coming up with a set of values to be set in the ruleset that can
a) match exactly the original / current calculation of stat gains.
and
b) give modders all the freedom they need wrt. changing the behavior.

I have come up with something there, but I will open a new topic for that, since it does not really belong into this one. ;)
edit: here is the thread: https://openxcom.org/forum/index.php?topic=2474.0
« Last Edit: June 28, 2014, 05:39:43 pm by Roujin »

Offline arrakis69ct

  • Colonel
  • ****
  • Posts: 246
    • View Profile
Re: Showing Soldier stat increases after mission [patch inside]
« Reply #6 on: July 09, 2014, 02:39:54 pm »
How i install this???

Offline Roujin

  • Sergeant
  • **
  • Posts: 11
    • View Profile
Re: Showing Soldier stat increases after mission [patch - updated 08-12-2015]
« Reply #7 on: December 08, 2015, 05:23:52 pm »
Long time no see :)

I noticed the news post about "Soldier Diaries" being adopted into master a few days ago, and figured I would rebase my patch here to current master and see if there is any interest in it.
Unfortunately because I'm a git noob I didn't manage to preserve the patch queue and have only a single patch now. (updated in first post)

Here's a new screenshot from a TFTD game :)

Offline Meridian

  • Global Moderator
  • Commander
  • *****
  • Posts: 5477
  • Aaand we're back!
    • View Profile
    • My Wiki
Re: Showing Soldier stat increases after mission [patch - updated 08-12-2015]
« Reply #8 on: December 08, 2015, 05:29:09 pm »
+10

This would be really cool to have... now I have to painfully look it up, or even use spreadsheets to track.

Offline Arthanor

  • Commander
  • *****
  • Posts: 2560
  • XCom Armoury Quartermaster
    • View Profile
Re: Showing Soldier stat increases after mission [patch - updated 08-12-2015]
« Reply #9 on: December 08, 2015, 06:16:52 pm »
Cool stuff! Hopefully it is easy to apply to OXCE as well, then I can track which gals are slacking! ;)

niculinux

  • Guest
Re: Showing Soldier stat increases after mission [patch - updated 08-12-2015]
« Reply #10 on: December 08, 2015, 09:12:07 pm »
Cool stuff! Hopefully it is easy to apply to OXCE as well, then I can track which gals are slacking! ;)

Agree! ::)

Offline Shoes

  • Commander
  • *****
  • Posts: 503
    • View Profile
Re: Showing Soldier stat increases after mission [patch - updated 08-12-2015]
« Reply #11 on: December 08, 2015, 09:52:57 pm »
Long time no see :)

I noticed the news post about "Soldier Diaries" being adopted into master a few days ago, and figured I would rebase my patch here to current master and see if there is any interest in it.
Unfortunately because I'm a git noob I didn't manage to preserve the patch queue and have only a single patch now. (updated in first post)

Here's a new screenshot from a TFTD game :)

Are you familiar with git? You should put your changes up there so that others can use it.

Offline kkmic

  • Commander
  • *****
  • Posts: 587
  • Undefined
    • View Profile
Re: Showing Soldier stat increases after mission [patch - updated 08-12-2015]
« Reply #12 on: December 09, 2015, 11:54:22 am »
Why not simply show only the improved stats?

Something like

Code: [Select]
Ctibor Cernic 2TU 4STA 4HP
Exekiel Eke 1TU 5STA 1HP 3ACC 

I agree that the table format you use lets you quickly see which soldiers improved in one particular field, but it's taking too much screenspace. Can you at least dump the dots?

Offline hellrazor

  • Commander
  • *****
  • Posts: 2199
  • Deep Ruleset Digger & Bughunter
    • View Profile
    • Github Account
Re: Showing Soldier stat increases after mission [patch - updated 08-12-2015]
« Reply #13 on: December 09, 2015, 12:37:01 pm »
Totally +100!

We already have Soldier Diaries in so why not also put Infoscreens into the Soldier Diaries, to see Statincreases for the Soldier in the Mission that occured.
And maybe a overview for Missions, to see this infofield, not only after battle but also in the diary screen.

Offline Roujin

  • Sergeant
  • **
  • Posts: 11
    • View Profile
Re: Showing Soldier stat increases after mission [patch - updated 08-12-2015]
« Reply #14 on: December 10, 2015, 02:11:39 am »
Are you familiar with git? You should put your changes up there so that others can use it.
You mean GitHub? No, haven't used it yet.
Obviously I used git (TortoiseGit to be specific) to clone the code base and make the patch.

Others can already use it though, if they want - just have to download and apply the the patch, right? :)

Why not simply show only the improved stats?
[...]

Hmm, showing only the improved stats is an idea I didn't think about.
I guess it would look a bit unorganized though.
Also a lot of repetition of the stat names (TU, STA, ...) and if one soldier gains stats in all or most categories, it definitely won't fit in the line.

[...]
Can you at least dump the dots?

I had tried several combinations before I decided for this one: with/without dots, yellow or green, zero or dash for unchanged stats.
Just removing the dots looks too empty imo (screenshot 08).
Removing the dots but adding dash for unchanged stats was a close contender though (screenshot 07). Do you think that one is better than the dots?
(note: old screenshots with wrong stat order)


We already have Soldier Diaries in so why not also put Infoscreens into the Soldier Diaries, to see Statincreases for the Soldier in the Mission that occured.
And maybe a overview for Missions, to see this infofield, not only after battle but also in the diary screen.

Sure, that would be a nice addition. :)
Maybe I'll add it some time.
« Last Edit: December 10, 2015, 02:14:22 am by Roujin »