Author Topic: New feature discussion: inventory templates  (Read 31749 times)

Offline redv

  • Colonel
  • ****
  • Posts: 335
    • View Profile
Re: New feature discussion: inventory templates
« Reply #30 on: July 14, 2014, 06:48:33 pm »
You can use tooltips!

When mouse hover over "copy" button you can write "Left MB - copy; right MB - clear".
When mouse hover over "paste" button you can write "Left MB - paste; right MB - clear".

Something like this :)

Offline Falko

  • Commander
  • *****
  • Posts: 802
    • View Profile
Re: New feature discussion: inventory templates
« Reply #31 on: July 14, 2014, 06:57:31 pm »
i am not sure why/when i need the clear-functionality
i never missed it in using templates

Offline myk002

  • Colonel
  • ****
  • Posts: 227
    • View Profile
Re: New feature discussion: inventory templates
« Reply #32 on: July 15, 2014, 02:53:13 am »
Removing the clear template feature could be an option too.  I tend to use it just to get a nice visual representation of all the equipment in one place: the ground.  then I equip one soldier, create template, and apply across a bunch of them, keeping visual tabs on what remains on the ground.

Offline SupSuper

  • Lazy Developer
  • Administrator
  • Commander
  • *****
  • Posts: 2161
    • View Profile
Re: New feature discussion: inventory templates
« Reply #33 on: July 15, 2014, 07:23:12 am »
It also seems the new buttons cover up the weapon hover text which didn't happen before: https://github.com/SupSuper/OpenXcom/commit/a6145bb9638a354bad0a13dea73325a425287e96#commitcomment-6998860

Offline myk002

  • Colonel
  • ****
  • Posts: 227
    • View Profile
Re: New feature discussion: inventory templates
« Reply #34 on: July 15, 2014, 07:27:48 am »
Ugh, I didn't notice that text/button conflict.  I'd be happy with removing the new button and keeping just the hotkey.

edit: pull request submitted: https://github.com/SupSuper/OpenXcom/pull/899
« Last Edit: July 15, 2014, 07:47:03 am by myk002 »

Offline SupSuper

  • Lazy Developer
  • Administrator
  • Commander
  • *****
  • Posts: 2161
    • View Profile
Re: New feature discussion: inventory templates
« Reply #35 on: July 15, 2014, 09:51:23 pm »
Btw, have you got any ideas regarding making the functionality of the buttons clearer? The current icons still seem to cause confusion, I think people expect something styled like Load/Save or Copy/Paste buttons.

Offline Falko

  • Commander
  • *****
  • Posts: 802
    • View Profile
Re: New feature discussion: inventory templates
« Reply #36 on: July 15, 2014, 10:03:51 pm »
something like that ?

Offline Aldorn

  • Commander
  • *****
  • Posts: 750
    • View Profile
Re: New feature discussion: inventory templates
« Reply #37 on: July 15, 2014, 10:31:20 pm »
something like that ?
I would say b1 + b4

Offline redv

  • Colonel
  • ****
  • Posts: 335
    • View Profile
Re: New feature discussion: inventory templates
« Reply #38 on: July 15, 2014, 10:34:25 pm »
something like that ?

In floppy disk one corner was cut.

Offline Falko

  • Commander
  • *****
  • Posts: 802
    • View Profile
Re: New feature discussion: inventory templates
« Reply #39 on: July 15, 2014, 10:38:06 pm »
yeah i need 4 images floppy disk with and without template changes b2/b3
and with a floppy just 9 pixel cutting a small corner is not really possible i think

Offline redv

  • Colonel
  • ****
  • Posts: 335
    • View Profile
Re: New feature discussion: inventory templates
« Reply #40 on: July 15, 2014, 11:01:36 pm »
and with a floppy just 9 pixel cutting a small corner is not really possible i think

Why not? Easy :)

Offline myk002

  • Colonel
  • ****
  • Posts: 227
    • View Profile
Re: New feature discussion: inventory templates
« Reply #41 on: July 15, 2014, 11:31:18 pm »
re: copy/paste icons vs disk (save) icons, I think the disk icons (as offered above) are a good choice.  I tried making convincing copy/paste icons in the space allocated and was miserably unsucessful.  Of course, most of my icons are miserably unsuccessful, but that is not the point : p

Offline redv

  • Colonel
  • ****
  • Posts: 335
    • View Profile
Re: New feature discussion: inventory templates
« Reply #42 on: July 15, 2014, 11:44:23 pm »
Marked floppy:

Offline myk002

  • Colonel
  • ****
  • Posts: 227
    • View Profile
Re: New feature discussion: inventory templates
« Reply #43 on: July 16, 2014, 01:21:38 am »
so how about:
filenamewasbecomes
invcopy.png
invcopy_active.png
invpaste_empty.png
invpaste.png

maybe make the disk image part the same in both the copy and paste icons
the copy and copy_active icons could be the same -- what do you think?  do we need to differentiate both the copy and paste icons when there is a template stored or just the paste one?

edit: actually, invpaste_empty should be a greyed out/disabled icon, since it now does nothing when there is no template/an empty template stored (it used to clear the inventory when in that situation, but warboy disabled that behavior because it was confusing and looked like a bug).  clearing the inventory is now done with a hotkey ('x' by default)
« Last Edit: July 16, 2014, 01:24:40 am by myk002 »

Offline Falko

  • Commander
  • *****
  • Posts: 802
    • View Profile
Re: New feature discussion: inventory templates
« Reply #44 on: July 16, 2014, 02:13:57 am »
the icons should be the same not 2 icons with a smaller label area and two with a bigger one
i modelled my icon after the save button seen in many windows programs
redv looks more like a real floppy (label area was bigger)
i think mine is better recognizable but i do not really care either way regardless it should be the same disk"type"
'save into a "loaded" template' should differ from 'save into a "empty" template'
for one easy reason if i click on the button the first time there should be a visible change of state if that is a darkening of the label area or the appearance of a check mark again i dont care