aliens

Author Topic: Is it possible to reopen a bugtracker issue?  (Read 5025 times)

Offline Align

  • Colonel
  • ****
  • Posts: 196
    • View Profile
Is it possible to reopen a bugtracker issue?
« on: November 21, 2013, 09:39:02 am »
I made https://openxcom.org/bugs/openxcom/issues/394, after noticing that the rearmRate for cannons was 100 instead of 50 in the default ruleset while I was tinkering with my own mod, and though it says resolved, it's still got that error in there.

Offline Warboy1982

  • Administrator
  • Commander
  • *****
  • Posts: 2333
  • Developer
    • View Profile
Re: Is it possible to reopen a bugtracker issue?
« Reply #1 on: November 21, 2013, 01:16:01 pm »
sorry, what's your point? the issue has been resolved, has it not?

the value in the ruleset is correct, see for yourself:

Code: [Select]
name
      range
            accuracy
                  damage
                        reload time (ufopaedia)
                              fire rate (ufopaedia)
                                    max ammo
                                          rearm rate
                                                ammo type
40 02 1E 00 46 00 46 00 01 00 0F 00 06 00 01 00 06 00  stingray
41 02 3C 00 50 00 64 00 03 00 14 00 03 00 01 00 07 00  avalanche
42 02 0A 00 19 00 0A 00 08 00 02 00 C8 00 64 00 08 00  cannon
43 02 41 00 64 00 E6 00 05 00 19 00 02 00 01 00 09 00  fusion
44 02 15 00 23 00 46 00 0A 00 04 00 00 00 32 00 00 00  laser
45 02 34 00 32 00 8C 00 0C 00 06 00 00 00 32 00 00 00  plasma

Offline SupSuper

  • Lazy Developer
  • Administrator
  • Commander
  • *****
  • Posts: 2162
    • View Profile
Re: Is it possible to reopen a bugtracker issue?
« Reply #2 on: November 21, 2013, 08:28:16 pm »
Yes, each cannon item has "50 ammo" but the cannons reload at a rate of "100 ammo" per cycle, we have added new fields to the ruleset to match this.

Offline Align

  • Colonel
  • ****
  • Posts: 196
    • View Profile
Re: Is it possible to reopen a bugtracker issue?
« Reply #3 on: November 21, 2013, 08:53:20 pm »
Ah, so did the function of rearmRate get changed or am I hallucinating?

Offline SupSuper

  • Lazy Developer
  • Administrator
  • Commander
  • *****
  • Posts: 2162
    • View Profile
Re: Is it possible to reopen a bugtracker issue?
« Reply #4 on: November 22, 2013, 01:22:52 am »
"rearmRate" now explicitly refers to "amount of ammo rearmed per cycle", while the craft weapon clip size was moved to the respective item's "clipSize": https://github.com/SupSuper/OpenXcom/commit/68bab8c5dd7d943c9f93490e93454faed01a793d

Old mods should still work the same, but if you want different rearm/clip ratios, well... now you can. :P

Offline Warboy1982

  • Administrator
  • Commander
  • *****
  • Posts: 2333
  • Developer
    • View Profile
Re: Is it possible to reopen a bugtracker issue?
« Reply #5 on: November 22, 2013, 01:28:06 am »
as for the original question: if you comment on an issue that's been closed, i get an email, and can re-open it.
optionally you can open a new issue that refers to the closed one and say "this issue is still present"