[MERGED] Soldier Diaries 1.0

[ibanix]

It shouldn't be that difficult, but code has to be well tested before being committed.

[SupSuper]

I agree. Having to continuously update for nightlies that don't even affect the functions of the mod has to get old after a while. Unfortunately, merging it with the build might would take some of the creative freedom of the mod out of Shoes' hands.

Shoes can still do whatever maintenance he wants before and after the mod's integrated, it's open-source. If it makes it simpler, he can always just keep his Commendation Medals as a separate mod, while the stats part is integrated into the main game, so it just becomes a regular ruleset mod like all the others.
The main delays in integrating are:
1. From this thread's recent posts, there are still issues to work out.
2. His changes involve over 5000 changed lines of code (much bigger than your typical PR) that have to be carefully reviewed to make sure they don't cause any problems to existing players.

[BlackLibrary]

5000 lines of code?  Shoes...you are one dedicated mofo.  Thank you!  Do what you do.

[arrakis69ct]

5000 oh my god. More than the game original XD

[Aldorn]

5000 lines of code?  Shoes...you are one dedicated mofo.  Thank you!  Do what you do.

Beware, I suspect Sup to be the Cydonian Brain, whose we try to beat an illusion in the final mission 

[BlackLibrary]

Beware, I suspect Sup to be the Cydonian Brain, whose we try to beat an illusion in the final mission 

You know...that would explain quite a few things I've noticed.  Quite a few things...

[ibanix]

The last actual working version seems to be the 06/22 build.

[Shoes]

I've been lazy as of late :3

I am pretty certain I have fixed the legacy bug of commendations being given too often, so I am going to publish what I have now for legacy and nightly and see what happens. I am less hesitant to do this now that I've added a debug command to clear a soldier of his commendations.

edit: I think I just figured out the part-two of the "everyone gets commendations" bug... I haven't been bundling my updated ruleset in the zip... >.>

[PegasusOrgans]

Is there are a chance this can be added to Final Mod? I can't imagine playing it without these amazing features!

[Solarius Scorch]

Is there are a chance this can be added to Final Mod? I can't imagine playing it without these amazing features!

Hopefully it will be added to the main game, so there will be no need for this.

As for the Final Mod Pack, perhaps; but not at this moment, since I don't want to get into modifying the exe, especially since the Commendations mod is unfinished. Nevertheless, there's no problem with running the FMP and the Commendations mod at the same time; they shouldn't conflict with each other.

[wsmithjr]

Nevertheless, there's no problem with running the FMP and the Commendations mod at the same time; they shouldn't conflict with each other.

I run them both without any problems.

[Hobbes]

I run them both without any problems.

Yup, just tried the Legacy Debug and the promotions seem to be working again

However, the text for the strings STR_MISSIONS_UC and several others are missing.

[Shoes]

Yup, just tried the Legacy Debug and the promotions seem to be working again

Yes!

However, the text for the strings STR_MISSIONS_UC and several others are missing.

Crap! Maybe I should test my stuff better :x Oh! I bet I know what happened! I am working towards getting this merged into the game, so I moved "stats" strings to the main game, and "commendations" strings are still in the ruleset. You (everyone, both versions) are missing the "stats" strings. Oops :3

edit: it's up; I am sure that was the problem, but let me know if it wasn't!

[Hobbes]

edit: it's up; I am sure that was the problem, but let me know if it wasn't!

Everything looks OK now, thanks for the work

[Shoes]

Awesome. Now you mentioned at one point that the "winning a mission with one soldier" commendation wasn't working; I haven't looked into it, but it very well could be. Do you know of any other commendations that are wonky?